From: Simon Horman <horms@kernel.org>
To: Luca Weiss <luca.weiss@fairphone.com>
Cc: Alex Elder <elder@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Alexander Koskovich <akoskovich@pm.me>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/6] net: ipa: fix event ring index not programmed for IPA v5.0+
Date: Wed, 8 Apr 2026 17:35:03 +0100 [thread overview]
Message-ID: <20260408163503.GF469338@kernel.org> (raw)
In-Reply-To: <20260403-milos-ipa-v1-2-01e9e4e03d3e@fairphone.com>
On Fri, Apr 03, 2026 at 06:43:48PM +0200, Luca Weiss wrote:
> From: Alexander Koskovich <akoskovich@pm.me>
>
> For IPA v5.0+, the event ring index field moved from CH_C_CNTXT_0 to
> CH_C_CNTXT_1. The v5.0 register definition intended to define this
> field in the CH_C_CNTXT_1 fmask array but used the old identifier of
> ERINDEX instead of CH_ERINDEX.
>
> Without a valid event ring, GSI channels could never signal transfer
> completions. This caused gsi_channel_trans_quiesce() to block
> forever in wait_for_completion().
>
> At least for IPA v5.2 this resolves an issue seen where runtime
> suspend, system suspend, and remoteproc stop all hanged forever. It
> also meant the IPA data path was completely non functional.
>
> Fixes: faf0678ec8a0 ("net: ipa: add IPA v5.0 GSI register definitions")
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-04-08 16:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 16:43 [PATCH 0/6] IPA v5.2 support for Milos and Fairphone (Gen. 6) Luca Weiss
2026-04-03 16:43 ` [PATCH 1/6] net: ipa: fix GENERIC_CMD register field masks for IPA v5.0+ Luca Weiss
2026-04-08 16:34 ` Simon Horman
2026-04-03 16:43 ` [PATCH 2/6] net: ipa: fix event ring index not programmed " Luca Weiss
2026-04-08 16:35 ` Simon Horman [this message]
2026-04-03 16:43 ` [PATCH 3/6] dt-bindings: net: qcom,ipa: add Milos compatible Luca Weiss
2026-04-05 8:03 ` Krzysztof Kozlowski
2026-04-03 16:43 ` [PATCH 4/6] net: ipa: add IPA v5.2 configuration data Luca Weiss
2026-04-08 16:36 ` Simon Horman
2026-04-03 16:43 ` [PATCH 5/6] arm64: dts: qcom: milos: Add IPA node Luca Weiss
2026-04-03 19:27 ` Dmitry Baryshkov
2026-04-07 10:30 ` Konrad Dybcio
2026-04-09 7:58 ` [5/6] " Paolo Abeni
2026-04-09 8:00 ` Krzysztof Kozlowski
2026-04-03 16:43 ` [PATCH 6/6] arm64: dts: qcom: milos-fairphone-fp6: Enable IPA Luca Weiss
2026-04-03 19:27 ` Dmitry Baryshkov
2026-04-09 8:26 ` Luca Weiss
2026-04-09 7:46 ` [PATCH 0/6] IPA v5.2 support for Milos and Fairphone (Gen. 6) Paolo Abeni
2026-04-09 8:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408163503.GF469338@kernel.org \
--to=horms@kernel.org \
--cc=akoskovich@pm.me \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox