public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Xu Du <xudu@redhat.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	horms@kernel.org, shuah@kernel.org, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC net-next 2/4] selftests: drv-net: tso: add helpers for double tunneling GSO
Date: Wed, 8 Apr 2026 17:27:41 -0700	[thread overview]
Message-ID: <20260408172741.39e65ab3@kernel.org> (raw)
In-Reply-To: <CAA92KxmXOpH=CUqEdVV2948XhU1oFh8PBYLUt=ktSsK3sOh40g@mail.gmail.com>

On Wed, 8 Apr 2026 10:04:09 +0800 Xu Du wrote:
> On Tue, Apr 7, 2026 at 11:08 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Tue,  7 Apr 2026 10:45:09 +0800 Xu Du wrote:  
> > > As the YNL Python module cannot be invoked across different devices or
> > > environments directly in its current form, the helper abstracts the
> > > YNL CLI calls to ensure proper configuration of the tunneling device
> > > features.  
> >
> > Can you explain more? Why can't you use class RtnlFamily?
> 
> I want to test the gro-hint parameter functionality of the GENEVE tunnel,
> so I intend to use YNL for the testing. I am conducting the test between
> two machines using SSH type. I want to add the gro-hint parameter on
> both the local and remote nodes; however, I am unable to invoke class
> RtnlFamily on the remote node via SSH.

Oh. But that's not really what you're doing:

+def ynlcli(family, args, json=None, ns=None, host=None):
+    if (KSFT_DIR / "kselftest-list.txt").exists():
+        cli = KSFT_DIR / "net/lib/ynl/pyynl/cli.py"
+        spec = KSFT_DIR / f"net/lib/specs/{family}.yaml"
+    else:
+        cli = KSRC / "tools/net/ynl/pyynl/cli.py"
+        spec = KSRC / f"Documentation/netlink/specs/{family}.yaml"
+    if not cli.exists():
+        raise FileNotFoundError(f"cli not found at {cli}")
+    args = f"--spec {spec} --no-schema {args}"
+    return tool(cli.as_posix(), args, json=json, ns=ns, host=host, shell=True)

You're not deploying anything to the remote system.
Are you assuming that the remote system magically has the same
filesystem layout?

You can use the ynl CLI but it has to be whatever version is on 
the remote system. Just call ynl --family rt-link, don't dig
around for the spec paths etc.

  reply	other threads:[~2026-04-09  0:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  2:45 [RFC net-next 0/4] selftests: drv-net: tso: add double tunneling GSO tests Xu Du
2026-04-07  2:45 ` [RFC net-next 1/4] selftests: drv-net: tso: retry connect on EHOSTUNREACH Xu Du
2026-04-07  2:45 ` [RFC net-next 2/4] selftests: drv-net: tso: add helpers for double tunneling GSO Xu Du
2026-04-07 15:08   ` Jakub Kicinski
2026-04-08  2:04     ` Xu Du
2026-04-09  0:27       ` Jakub Kicinski [this message]
2026-04-09  7:35         ` Xu Du
2026-04-07  2:45 ` [RFC net-next 3/4] selftests: drv-net: tso: add Geneve double tunneling GSO test Xu Du
2026-04-07  2:45 ` [RFC net-next 4/4] selftests: drv-net: tso: expand double tunnel GSO test coverage Xu Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408172741.39e65ab3@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=xudu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox