From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D34922339; Thu, 9 Apr 2026 00:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775695038; cv=none; b=uZqTh3+BbEX/EJuALC4aCiy/0SoJO4TdSSYW6TTUm4XURw19hhx0FsXadattdf0hciJ1gNoId3oD60ob5ypxUEKo/xN70kpNQ7tah74azWiDo6N94QlN6mx0pDmjetgO8wWdBI4x2waWi1XyGfP5LHswG8vTzM+YQPTe0zGVVdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775695038; c=relaxed/simple; bh=Lnf0KvVHrpWGAgDszvd4p/cDYRWH8oXxi8NAc7GrJqI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OOdYE8XYSmCVNfFeYZRSvXGkG/NgWCc+f49Oo9h2mSgoNM+E07rls5DFFa3cdl88vqSlYPaW8j2jJa6xFVm9xp/PQ5jHjYdTPS7jId5r7adzrvs7F3tMj1VzwagHDofWyL2nH5BDOmUDE0fXgqmAoX/jzvKzH0G6loSfytkCbSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U+gWrai0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U+gWrai0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEDB6C19421; Thu, 9 Apr 2026 00:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775695038; bh=Lnf0KvVHrpWGAgDszvd4p/cDYRWH8oXxi8NAc7GrJqI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U+gWrai02H++LdRf4jJ4Nttoj9vl+DwuXfEqWtuRzjLA8lAG2l5JdWmHRwirEx7G6 +GbWKgz1q8wMdoGY3ZsZAJr17rDisooB+8nQMsoOf45jGWLIg/r6fdN2Z0fXvHALiD 2PqLoUVbSKIcm003IcRnjpC9byGJXGBNVcZKv6hfpwqT3PR6EYCDagHmzn3oW4LNPF spueR9Hcnb6t3H7/w9nyU3BmwvLUNE/5A9SOAEnDzTriR9nEB1to9reY74NhnA4QPN yUjdTQAWCOdT07AC1CjMfHV46D9bGAXTYjODF2Wgj8ewffdJr91TZn2LGV1+xO39Kf xyUlIDTyDvi/w== Date: Wed, 8 Apr 2026 17:37:16 -0700 From: Jakub Kicinski To: Stanislav Fomichev Cc: Hangbin Liu , Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 1/5] tools: ynl: move ethtool.py to selftest Message-ID: <20260408173716.0dedf22c@kernel.org> In-Reply-To: References: <20260408-b4-ynl_ethtool-v2-0-7623a5e8f70b@gmail.com> <20260408-b4-ynl_ethtool-v2-1-7623a5e8f70b@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 8 Apr 2026 09:42:33 -0700 Stanislav Fomichev wrote: > > @@ -8,7 +8,7 @@ KSELFTEST_KTAP_HELPERS="$(dirname "$(realpath "$0")")/../../../testing/selftests > > source "$KSELFTEST_KTAP_HELPERS" > > > > # Default ynl-ethtool path for direct execution, can be overridden by make install > > -ynl_ethtool="../pyynl/ethtool.py" > > +ynl_ethtool="./ethtool.py" > > > > readonly NSIM_ID="1337" > > readonly NSIM_DEV_NAME="nsim${NSIM_ID}" > > Do we need to add some expects/asserts to the script to really make it into > a test? Right now it just prints things, so it's not really a test. This file is full of asserts? It's a bash script that runs ethtool.py and checks the output. Which one of us is missing the point ? :)