From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3CA038737C for ; Wed, 8 Apr 2026 20:02:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775678550; cv=none; b=rbruf3iQuFwf+hN64jWlTGOJ9w28Yk8iYmPq9VxSuoduILGlrk+3hIBgeXXs8Z35frcbhQG8uZPldcBJBJCdVMKIaFr+wzbTZyiXiW0SyaDuiTKizm/BPfs/qg6yl/TSk/FV+4LEzciFdz2g3794YAR6IZ2BqvgJk1AbQoSJnUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775678550; c=relaxed/simple; bh=nT2X+0ltTDZpc2Ke/Nts5WB2aC9+0FZsv4JIXPNa2T0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WyGkn9MRlJmyTRsCWMxXyD22q3kN/s/RFtowzL6RiotTvNWoans6zorhORA5RglbAt43ix5lAAx6aPzXSTGdL7672Nd00XyQBiTQNPPNsCRkCZQtf1zwYUNlCgKKaraqiWfrhFJQxL+TVswrz8Wf8MqwYMk27pd5/J7YM3Df8NQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZQEjQ78y; arc=none smtp.client-ip=209.85.161.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZQEjQ78y" Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-67c250805ccso62764eaf.1 for ; Wed, 08 Apr 2026 13:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775678548; x=1776283348; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6DJe7q9AzKIA5JE9j9dS7BkLMe6yLjsp/ulkOtgleYM=; b=ZQEjQ78yH0b7zLihoAvH8Yyr+aZd0i7Zuv8pDTylgazJO7IK44dfJGmiloP+XnMg4d dJqktUMRkjh++YaBrYrJykiWkxyve4N/1JZDhWrbt7pJInaSx1j3B/ud0vJ185ZC/YP5 NsSQy+71B6VKhsTgtWGaum+OebsqCa/Tl74J68dCxAn7RHKNMjEiTH+LBOJjn8e5HRIK 7NQvRmekakHhb7/R44ZUQTueuTuDRzMkNnTN38xQ78gI/scbztje6wmsIgA3Oot03zBJ lbN6Y6n4zRW4aGhoejkTbZgWGDmHkj70C+ln/d1fdTVQWbtiOxfJ7nfiJOj8FK/lB46D HKPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775678548; x=1776283348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6DJe7q9AzKIA5JE9j9dS7BkLMe6yLjsp/ulkOtgleYM=; b=qHtiyXJkRA4wgluof/OyA7qsFuT84RPn9cotUoTQdQ1GtGSqJ9cEwBlCovmx4cKGJW TV/VcZGOLqx46Doi/0VP1JG/HcrqGsVJQ6/2SUaP2WieapZuTsd5CURBjIiWNRWBRqCC sd4/J0UwpI4GtNIzpUfNOC/V895vmjdEsO4sz/BrefLOGIYek9hbH1IFeBw7T1eq8VPz XlVnLJ/TMhHsD+IVV7WqONRVQZ2ZKmBCnhFfVml5nAfguLorziOcu9UwheYpT/BGdUmo Pxh9mqN+VyQNUFVlShHOPvS3TVFdvthEc0Sp0w+mTFimnAflPKU8/LoxGd8tE7bklMMM KB3g== X-Gm-Message-State: AOJu0Yx/7uVfUCLAw+a+iQy0IWWWgIAyp7HQXF1kwyg5oK1wmGdokLDE 19VXAM5lPbUiYZhsb0KcLhzdSmY/xK9hVbGff5TybybijuZScANUWLI1RoWw1w== X-Gm-Gg: AeBDiesGCNcDEMXzNzNQY+ySNP9AlIh3DAVduHOamaJmEwFxK7UapLls3kVfXRAtRFR o3dz7uAyik2YTexO1MGvGjwRQIvVx8j1QkMPYtorKHffQ9Ox2flGjBuSkNmQI9srCyYexwN5uyr CRQ44+1sUrAT51xuXZD6xmJUaTJd9tLUhKx+OsMXKiUC+COde604s6ecu6aWVUfEuHPI6mAkbBF bcWGSO6S6YkYj0cr0qFRr3ghKVNIT5Ux/JejT3cokl2zbZdSp3zvH1cGKYNUTuwKILQi5grz8fk hRgjvS4+d1hHnny6n2HdubEOfwjcGClfgNM6IDyxruB/dXkm6pPtNhuuMsIng1344EkXGZldZSy S90Dv+2cLFC7VV9wiF+TB+mVNdidLdtNePpFqz/tAPLOjJ15czib9OxpieEoZw/bsReKz8ulPyF ImFA0ElXyf2pnG+ovHDPYk4vrOcvexVMFjodsWJxExHpeKlS9dbgGOYCTxubQ0GxAXr1DmSsYAc c0yppF4ji+eNQ== X-Received: by 2002:a05:6820:1628:b0:680:89db:fd78 with SMTP id 006d021491bc7-68a6177f993mr553030eaf.1.1775678547711; Wed, 08 Apr 2026 13:02:27 -0700 (PDT) Received: from frodo.raven-morpho.ts.net (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 006d021491bc7-680a63c7fd1sm12254208eaf.8.2026.04.08.13.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 13:02:27 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, jbaron@akamai.com, louis.chauvet@bootlin.com, Jim Cromie Subject: [PATCH v13 11/36] dyndbg: make ddebug_class_param union members same size Date: Wed, 8 Apr 2026 14:01:46 -0600 Message-ID: <20260408200211.43821-12-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408200211.43821-1-jim.cromie@gmail.com> References: <20260408200211.43821-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least they will both see the same value. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index a10adac8e8f0..441305277914 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -104,7 +104,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index a9caf84ddb22..ffa1cf7c2c72 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -811,7 +811,7 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp) case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; } -- 2.53.0