From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FCF138736C for ; Wed, 8 Apr 2026 20:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775678553; cv=none; b=JLTDMKTirWn0iWLsu2ifYZu+KReTW2HSvqiMDRXoVKFNniOQrtqw/Kh+9YbiVzuAXsYAi48uPWT3bQ8xYO5UQaYyJIH6VTfzi1RxHyK2G7+QHU6beiGZcuJPYBi7ZtatFBRvkepoR7ce6XmmFh/IEt9QOvA4QCUsl16ikjxyIFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775678553; c=relaxed/simple; bh=S6gUrn6AElwN551VfXZR8sAzEWfpnwUQMkcCkNtZGhE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hbnAnfSgFUuV59QOwn9gLUe+iGFVftgw0gWnMHb1zPBtxQzYtUC9tLh3GTWQzjyfGJCGkk9lwQJvIrP/MDXuKuoIFyCrURBZohFqII7vgzd26hd2b6C8yNZWAePGiAs8PYSOK5OtHDOSZ6oFfNw7LPdITCdTyUzrY/PUotxM3b0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=buN7LjIB; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="buN7LjIB" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7d7e9b97a73so80671a34.0 for ; Wed, 08 Apr 2026 13:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775678551; x=1776283351; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sNdSdlXltBKavjCpq8HaVo39jGQFAT2gyMj0g9RRu6w=; b=buN7LjIBdDwGxsZU9pZuoI7WSRkxu6bpS4G0Pygr3K4T7PTQufffvzpwSrYm7+N2T1 c6ktwd2iISdF3g37tKE6CaLQeitjMMCO4txTqJk6gzBG1vzUUUlNGOACydAqaB6jNYuT F/Y8+RsGkKSPDb5AM3HB0Xo5fl4+F/1M18zl0nLFwaSq6gX4eGJ7h0Q2OoRGXCqVPsOX RfaOn4/KwLoX9qOzfPD3ngFsQJFOePGnMKo1VI1827s3iMdiQBB8CY8JInXUqBJi8jGA V/Ls83HpF1ka9gZHGmZdBplZl35G+cCh582qbGxKUCWByDKdzCj98drBopbWYrZOAzmS xiKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775678551; x=1776283351; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sNdSdlXltBKavjCpq8HaVo39jGQFAT2gyMj0g9RRu6w=; b=hky+SX3AIx5HUffjtoA3phR/8dcbQUc/DjV/6e8TZ+FcxMXYNZnwraKCfXR04DiHqa 3zME/msOQo1t06OP+6Pn6T4F4UAiOkgIfivTN89Y8dZGms1K8qiDw0IS1d9mWxma8IkM YDJ1cwYiumSrOC6uns9vN5HFCgIkNewkDdaDkN51U3mqqO7Pr8PsFscQWHgzIHdYitah 27jR4mY3shgcjwdb8ceG2oRoJDzotb7vVVJKBKTCA19GeUmNWNVG8wk1YJZkajeRnyZ7 MgrK8oy2dkqH7AZyCL/DG7afiRY0pH+RIjqBkcMyCU9tNUBxwjEW9VC+9m4h7EN8vYQj enrA== X-Gm-Message-State: AOJu0YyzaR/95CjadXOlJRmBxLu8xMNu395b6PsAzA4Fw3ONcjq9wzIH lvsPGl8+eErRgRgeoe1roBgvAAEwxeNl+WBHUQON2R4o33w8tniqp3qdUo41Zw== X-Gm-Gg: AeBDieuorYGXWTbSe+gR8YeL2jAs6ThOo/JZFyX4kt83uLW6gJVcGda5ThJQZTC6ng7 S+y0y5ne2bbDDPisTTkZ+PiaIKzU03ZDwe4SDGE1PzvHrSUGIg6d+d8TbCv7g/QHN4jHs/y9AZH RbvsJMi57n5GaBC7Cv56/a08/nkm5vuI/EshyLS4gAEvhRSVb++tfvNDRGLgAx86qWeV1nd0GmP rcv4goHLA212xz5XPUtm6n0+3PtX9YM71DF+i3rkTqMZf0Cuu23pmA8Baxkrd29UdaQxp/cKXU2 WmQgSR7TBzNhP+ZFyyQChZrUvsHY+JENXbNNjXpdcoPPnNdOjF5wY6i7FqUHREV7Q68rJQ7l6SW NzCp1awFFXHlWwsr2l4EFOaUcooz5p7Q2fLb3zS2rXsh9xLl0fM29Wkn9YDUWR1P17ctV1TJLxf pMwno/8cQgGNcqkjBs8UGcdqEes25fVr6KqWcFv2Im8i2NMTBneDtthf0nFZnLUpLaXs0A6gjhh jk= X-Received: by 2002:a05:6820:2908:b0:688:e883:8846 with SMTP id 006d021491bc7-68a69fdf054mr413117eaf.9.1775678550818; Wed, 08 Apr 2026 13:02:30 -0700 (PDT) Received: from frodo.raven-morpho.ts.net (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 006d021491bc7-680a63c7fd1sm12254208eaf.8.2026.04.08.13.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 13:02:30 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, jbaron@akamai.com, louis.chauvet@bootlin.com, Jim Cromie Subject: [PATCH v13 14/36] dyndbg: reduce verbose/debug clutter Date: Wed, 8 Apr 2026 14:01:49 -0600 Message-ID: <20260408200211.43821-15-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408200211.43821-1-jim.cromie@gmail.com> References: <20260408200211.43821-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0xffffffff dyndbg: parsed: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: no matches for query dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' flags=0x1 *flagsp=0x1 *maskp=0xffffffff dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: processed 1 queries, with 0 matches, 0 errs Also reduce verbose=3 messages in ddebug_add_module When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 9575b92a8deb..3ae9ecabdad1 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -276,9 +276,6 @@ static int ddebug_change(const struct ddebug_query *query, } mutex_unlock(&ddebug_lock); - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } @@ -511,7 +508,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op='%c'\n", op); for (; *str ; ++str) { for (i = ARRAY_SIZE(opt_array) - 1; i >= 0; i--) { @@ -525,7 +521,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=0x%x\n", modifiers->flags); /* calculate final flags, mask based upon op */ switch (op) { @@ -541,7 +536,7 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) modifiers->flags = 0; break; } - v3pr_info("*flagsp=0x%x *maskp=0x%x\n", modifiers->flags, modifiers->mask); + v3pr_info("op='%c' flags=0x%x maskp=0x%x\n", op, modifiers->flags, modifiers->mask); return 0; } @@ -551,7 +546,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) struct flag_settings modifiers = {}; struct ddebug_query query = {}; #define MAXWORDS 9 - int nwords, nfound; + int nwords; char *words[MAXWORDS]; nwords = ddebug_tokenize(query_string, words, MAXWORDS); @@ -569,10 +564,7 @@ static int ddebug_exec_query(char *query_string, const char *modname) return -EINVAL; } /* actually go and implement the change */ - nfound = ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); - - return nfound; + return ddebug_change(&query, &modifiers); } /* handle multiple queries in query string, continue on error, return @@ -1246,11 +1238,10 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname) { struct ddebug_table *dt; - v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs); - if (!di->num_descs) { - v3pr_info(" skip %s\n", modname); + if (!di->num_descs) return 0; - } + + v3pr_info("add-module: %s %d sites\n", modname, di->num_descs); dt = kzalloc_obj(*dt); if (dt == NULL) { -- 2.53.0