From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AAC8220F49 for ; Thu, 9 Apr 2026 05:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711100; cv=none; b=RvLz7FTkmgy03VSNlfBzJ82jdIoMQR6mymHHflV/T/lvt5eRg5otuJ5vrgbiRaKlmAEvl5RuZ7Juk4YiG4U2VEdHHPmG1fQWBbcgPfY3kqILWIdxI/RZRCcvh6Xgz6Z9yHX1BU0l7spiLwFCtSuWX91A4eaLbQIN3PPkAZdXCC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711100; c=relaxed/simple; bh=d1yUUwZxSMTH4Mhr1vdB7tMvupSoxWq48gto3tesvWo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pNCtRzT0mopwwdsFvn0GMeGh1nPbLT0b8LTOOzwk/g7Lq+mYubH05xITN+Fs/3MZ8iht1Ui8F1Tk95nqQV47SVQAZSzX5MXpKSkFfMw2XJGBEAyoUuGQyJ2F/dW6d2mX7csACm46DWg88noG4jtColGIuH+JsHPO0w2wV8ejffM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mA/qiPbI; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mA/qiPbI" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2b24fcc2b5dso3720515ad.1 for ; Wed, 08 Apr 2026 22:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775711098; x=1776315898; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TnlvJQe4yhPb84lvxXeuW/a2CDGHMe2shk7LZ1M+Eo4=; b=mA/qiPbIp1zJWkA9bpOCYgShWxU0ulOA9gE5fvMdYTX1nzyeJ3AdaS6xjsoOhVMusx uNFLGVbePo3GjwCLveWRczaQCX40sTnPvJydDNo3AnoNdOybu+kwvcQfFafjNEhv91kF kyo17l4s2F3EGSLAkZ53bqwFY5J/aei1gXR7WyJoqq/cp0jM4ZzHDlyRntAzuAhAc9Ks KoZqiaKv76+pyGrcjKk0rdBm5ihl8LUwcaKV2om2P++HfxfpNhPua9UfINitphhZocEW W5EQvjf6int9VqQ9s3xxiBfZH8f6/wjPlT95qssSsH2UssKInnrO3sVGwbJkbKPuJgoU NyNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775711098; x=1776315898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TnlvJQe4yhPb84lvxXeuW/a2CDGHMe2shk7LZ1M+Eo4=; b=bBNFfYL/m8oIc9Obmzw7/rHW1W+u9SdB4NyyOS3ASwMino+lLa21bChQd6khjo75MN w4TIg1hoqKnhRTnRzrFPrTFpxxRVtikQICsKo8LVs9hrtweuUXK+Qz9pGaalxoaJ+ZQC RRECvwougsSevPYI2KOh26x9NUKlrdxuXDMJgW1RDU2Qb7lwQm63MMfh/RFY/jC+P8mX Mb40YxtzU2xBQ800n7eyo2DIDiMDCmNylpR2crfARP6zHcSuMzK9N87yNdcyPyfaMCIc zwcpeiC6evvhj/oe8eY1MxeuOYV/tcck0GUWrmcGdW/NEVG9FUzJYJ4TFYtIL+nJw6na czLA== X-Forwarded-Encrypted: i=1; AJvYcCUfkNOq/v/yyUe+XKHJNiukU+kQBxtJzuZwuIuYJkX27gnumyhthHQjR1wOrgN4G59t/e+nIX8znRp32tU=@vger.kernel.org X-Gm-Message-State: AOJu0YyJFMRnG6Ne3LH3amjtnG7SmngJ8YjZuqb6Qa47zpwER/2j1Jno Vgc1UBM9g+lGX69I+fgikrI+Jk+mZbOZyrEi92eL35sRrN6RGiX2A2xQ X-Gm-Gg: AeBDieuWsbnsVw5hHlkkHVh5d17ogYMZ0yrq62IzES0jkhJPm2twBFq6In8UneftYmi t+OS6DMJNIOLpexMq3CI8GCkYidGZwEonevNucKSr7crujtMRt2clj1K8kNCwnNmVF4NT8cGj+O DyJp8KgVY/tbACjMkwRNa8Ih/L3VsQEnd07D8dpo2pdlhvuiyl41qbd6zDmtPTw/s0EYHhO9/zQ uts3sHJWCeQd5ztNJk/kNcytdONZdPdtPPzGY6kT628CWkblwl/rKdNnxAbvNv9Oc1cm5apAC/e QO/WJ0isJGEj7AXvx0wPujyde4iRqSvUs8F48BT/XRRaKSi3F4nxbVRL3E34NvUyzHFk9hnECPb MnDd2sgXXIhLuzKatotB9bfajzJKq+F1WqQ++PcXW3xRiIny+t9BFPZvP8HMIY2/SvBhJmTBRng I+pL5yhBou7EgDEo/jeTk2k7Ck57Baq33hSB05aJI+7ygQ9C7equ1AMg== X-Received: by 2002:a17:903:22c6:b0:2ae:3b9b:db34 with SMTP id d9443c01a7336-2b28188da6amr250662535ad.42.1775711098419; Wed, 08 Apr 2026 22:04:58 -0700 (PDT) Received: from localhost (as040201.dynamic.ppp.asahi-net.or.jp. [150.9.40.201]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2b2a488caa2sm135280875ad.14.2026.04.08.22.04.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 22:04:58 -0700 (PDT) From: osjin83@gmail.com To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, osjin83@gmail.com Subject: [PATCH v2 1/4] staging: rtl8723bs: fix spacing around operators in rtl8723b_phycfg.c Date: Thu, 9 Apr 2026 14:04:49 +0900 Message-ID: <20260409050452.97774-2-osjin83@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260409050452.97774-1-osjin83@gmail.com> References: <20260409050452.97774-1-osjin83@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jinemon Tama Fix various spacing issues reported by checkpatch.pl to improve code readability and conform to the Linux kernel coding style. These changes are purely cosmetic and do not alter the functional behavior of the driver. Signed-off-by: Jinemon Tama --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 44 +++++++++---------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c index 7fac1c2ba8e0..cfa00775341b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -19,7 +19,7 @@ static u32 phy_CalculateBitShift(u32 BitMask) u32 i; for (i = 0; i <= 31; i++) { - if (((BitMask>>i) & 0x1) == 1) + if (((BitMask >> i) & 0x1) == 1) break; } return i; @@ -109,18 +109,18 @@ static u32 phy_RFSerialRead_8723B( NewOffset = Offset; if (eRFPath == RF_PATH_A) { - tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord); - tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | (NewOffset<<23) | bLSSIReadEdge; /* T65 RF */ - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord, tmplong2&(~bLSSIReadEdge)); + tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWord); + tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | (NewOffset << 23) | bLSSIReadEdge; /* T65 RF */ + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWord, tmplong2 & (~bLSSIReadEdge)); } else { - tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter2|MaskforPhySet, bMaskDWord); - tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | (NewOffset<<23) | bLSSIReadEdge; /* T65 RF */ - PHY_SetBBReg(Adapter, rFPGA0_XB_HSSIParameter2|MaskforPhySet, bMaskDWord, tmplong2&(~bLSSIReadEdge)); + tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter2 | MaskforPhySet, bMaskDWord); + tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | (NewOffset << 23) | bLSSIReadEdge; /* T65 RF */ + PHY_SetBBReg(Adapter, rFPGA0_XB_HSSIParameter2 | MaskforPhySet, bMaskDWord, tmplong2 & (~bLSSIReadEdge)); } - tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord); - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord, tmplong2 & (~bLSSIReadEdge)); - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord, tmplong2 | bLSSIReadEdge); + tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWord); + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWord, tmplong2 & (~bLSSIReadEdge)); + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWord, tmplong2 | bLSSIReadEdge); udelay(10); @@ -129,16 +129,16 @@ static u32 phy_RFSerialRead_8723B( udelay(10); if (eRFPath == RF_PATH_A) - RfPiEnable = (u8)PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter1|MaskforPhySet, BIT8); + RfPiEnable = (u8)PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter1 | MaskforPhySet, BIT8); else if (eRFPath == RF_PATH_B) - RfPiEnable = (u8)PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter1|MaskforPhySet, BIT8); + RfPiEnable = (u8)PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter1 | MaskforPhySet, BIT8); if (RfPiEnable) { /* Read from BBreg8b8, 12 bits for 8190, 20bits for T65 RF */ - retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBackPi|MaskforPhySet, bLSSIReadBackData); + retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBackPi | MaskforPhySet, bLSSIReadBackData); } else { /* Read from BBreg8a0, 12 bits for 8190, 20 bits for T65 RF */ - retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack|MaskforPhySet, bLSSIReadBackData); + retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack | MaskforPhySet, bLSSIReadBackData); } return retValue; @@ -203,7 +203,7 @@ static void phy_RFSerialWrite_8723B( /* */ /* Put write addr in [5:0] and write data in [31:16] */ /* */ - DataAndAddr = ((NewOffset<<20) | (Data&0x000fffff)) & 0x0fffffff; /* T65 RF */ + DataAndAddr = ((NewOffset << 20) | (Data & 0x000fffff)) & 0x0fffffff; /* T65 RF */ /* */ /* Write Operation */ /* */ @@ -266,7 +266,7 @@ void PHY_SetRFReg_8723B( if (BitMask != bRFRegOffsetMask) { Original_Value = phy_RFSerialRead_8723B(Adapter, eRFPath, RegAddr); BitShift = phy_CalculateBitShift(BitMask); - Data = ((Original_Value & (~BitMask)) | (Data<nCur40MhzPrimeSC>>1)); + PHY_SetBBReg(Adapter, rCCK0_System, bCCKSideBand, (pHalData->nCur40MhzPrimeSC >> 1)); PHY_SetBBReg(Adapter, rOFDM1_LSTF, 0xC00, pHalData->nCur40MhzPrimeSC); - PHY_SetBBReg(Adapter, 0x818, (BIT26|BIT27), (pHalData->nCur40MhzPrimeSC == HAL_PRIME_CHNL_OFFSET_LOWER) ? 2 : 1); + PHY_SetBBReg(Adapter, 0x818, (BIT26 | BIT27), (pHalData->nCur40MhzPrimeSC == HAL_PRIME_CHNL_OFFSET_LOWER) ? 2 : 1); break; default: break; -- 2.53.0