From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013009.outbound.protection.outlook.com [40.93.196.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C06D227E04C for ; Thu, 9 Apr 2026 05:19:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.9 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711972; cv=fail; b=h80tkMqDWGQZi48yP3JOCP7vckID7bSeOO2vZUdie2erfc6gV5fmKgXURtSu3QEyKzHIHRnyZ3+TxQSxhspRWvJoNQUQe93tZ3140JCzlYNcLfShaP2tHnOzNNcjr5bevjJVML7lWVsfaE1y74s+Y+He3a434tQd75QwM7e7+ss= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711972; c=relaxed/simple; bh=6c9BDi7HWfQf2wxjk28jwfS5cgYvgvLzcqywcJERI1I=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=roBcvqOiJ6ZYUoaP0NUcV8qb/qk8j/xg3VholiLDWWVnkp7dSf/IVsyiY06eCXOmpmpMhNWgCFniG2aG5/JMHbXstqIwSKdfT6SzFh+udjot1pfnAH6BR2gqra561PkoOm9RDM+ueRkfyISIJ7UXKUSxVAiEkZAlI5KDA7ND6Ac= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Z7CGgTuL; arc=fail smtp.client-ip=40.93.196.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Z7CGgTuL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dUzy+3l4QB36n8aeyBs5ulVua1JE8cw6/PFt9nF8XqE7spvgCXOuBK2n+Sot2iFroRyZsnfTnDQyXI61vnL7kywLS5zDqLlTlK6HREefdmfTYU0orVC3y9P7dB2rkJV2kpXGUCA4m8pOKMYpnHkBcvat6CU//04fU3V1/L/M3OBGfjP5enfNZX+UPz4hXrzfhraJGDdRDTHC6zBJ3g5oi/jURJvR/811sWo4/dIx0EHRHz5kh4SMj6XdGAeC/3RJZMtwR4qe56AwTBSeZ0Av/NSd685xlsMSx35hGfBntvr1pozqz406enLGIdYSuEYnWHa8KDuDwFKFG9IKWjtUkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FzRCyoH1qCgG2zPfXArUCvnYbJF8/6hPJRYJlB7rlnU=; b=cOswhXBHbzRF4DZvSWPo4Zqf6C0KcZVgqmfJ3yM0V6I1HbfkXjSX2kbFRuNfw2e93be1i1JrQcxxaZEh46OHOTxxA+TwswJPD4NAoKTO4E2ozl0O5o+R4NG8rrLIJruAyXUgkDA3Qu2jCEHhp3xW9zEhS+VWr/WMuAGgQVRloHqib6tNzIupjM4PQq7PRE0Ep2Nio9RMPd0HFv2z4Tibf5noS5NsmEx6ETc+lFuIRPWC4GPSkB9OpHIAwFPnD8qVCERGJHS6FS6l7SWe9M5pzHRG+IdqYh0lg88SzgmWxv6SOrQasJ4vj92IbZd4MXHhA5YHBgJfcoT5hHmRF8tWjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FzRCyoH1qCgG2zPfXArUCvnYbJF8/6hPJRYJlB7rlnU=; b=Z7CGgTuL3tuAZBvw/gwi30q+OMHCu/dsQ/D4oC7cjyX2O2SzYwPha7lttd+up4G4TaKZElZAThttdPMmP0VtBXUFAZn+mCuf0J0xU7H6SPPfK6KKSQFscHlVq0SkhGByyN0SxKyrH7XWVIcx0iWVXCh6eAPX28mxJHzpAHJlpYfMiX+s2yrzIV5hG7YBLeb9EBVu9ImoFamXA1B4+1xAJpGkdj0OBm++7PHcESAKrPIZbgv5KfKKiA7m67r4yxeqTivDw6fB7fhDqHjl9ErcQHQurWcw5a1tPuP8s5GfKglaEkntTd1n+3TtyzXjN6HI76uyUeDKvejwCwls03MBWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2370.namprd12.prod.outlook.com (2603:10b6:207:47::27) by PH7PR12MB7455.namprd12.prod.outlook.com (2603:10b6:510:20e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Thu, 9 Apr 2026 05:19:26 +0000 Received: from BL0PR12MB2370.namprd12.prod.outlook.com ([fe80::86cf:c3ec:2cf5:74c8]) by BL0PR12MB2370.namprd12.prod.outlook.com ([fe80::86cf:c3ec:2cf5:74c8%3]) with mapi id 15.20.9769.018; Thu, 9 Apr 2026 05:19:26 +0000 From: Richard Cheng To: dave.jiang@intel.com, jgg@ziepe.ca, saeedm@nvidia.com Cc: Jonathan.Cameron@huawei.com, linux-kernel@vger.kernel.org, jan@nvidia.com, newtonl@nvidia.com, kristinc@nvidia.com, sreddym@nvidia.com, skomatineni@nvidia.com, vidyas@nvidia.com, kaihengf@nvidia.com, mochs@nvidia.com, Richard Cheng Subject: [PATCH] fwctl: Fix class init ordering to avoid NULL pointer dereference on device removal Date: Thu, 9 Apr 2026 13:19:02 +0800 Message-Id: <20260409051902.40218-1-icheng@nvidia.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TPYP295CA0060.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:8::19) To BL0PR12MB2370.namprd12.prod.outlook.com (2603:10b6:207:47::27) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2370:EE_|PH7PR12MB7455:EE_ X-MS-Office365-Filtering-Correlation-Id: 420f57cf-c7fc-4208-b795-08de95f790f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: 0ekBCqL0YQdgzzeRgz1yXUdlt14YowZfSscmf1OhRtLvhweieuwIautvJ5VxdR9bjto5/RelpdMedF4lSwEYHiJ49q5zxoUFPEM/ZL/jXB/TXO9ux/VinXCim4n/B/x3YMdDmlbtOf83YVfvvM9xCdmBTYRfH/5ud8ikbNuUF20//q7vtgOqYbC/K5k0pEJ+1Mm/PvrFpHM//rZ3WJnWYunlSEjuO/VN6zrnJgFcfHvOOtIK5yR+2pKwh5OWuRjdgBIL+/WpAiDcvD+klq/NiMDstO/5fM6oEzBDL6KbaZmkjSe4YKstQD1dT60PdAuILfyCbTJYVuQ7SpCki91jovsdvcBFPl8K+HYN3vFPjgc0aK5c7unuGU4ZBbYdoi+R3GrP4UDPUAHmZG+WUTZowVS6zTGDrD3Xye1gau0IoNS/BubsrEqWoPJqeYIUHzLS8MCbBJgOxQmDKOLNME3g+LGXwU3lesoo0nw0f6/Wla99o3og7k5ByRMNJetOV2ujbs31D/TMROMWtN3UOPscFc9k2lJdJ5AyIPPaVAGrtvjkEL4gHguW4mNXH6vfdIfIyLz/dHSNV7HfPLHDqgIhi2pXoR2RV6KjXq0Y7VYgwU5wAuEQ97Lz7uIs9vCpaLlCepkidEDCOQvx2aw0d8FhzLOwfSPeSr8zwVZB6z5GgFmjO/XI/pRIobyV2qxjO3BiHJ+FlLjBwTI53AfjUpct8UBmjgcSCQ40xiWGFgDbvqU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2370.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YPMD5X8t5I2+F3ivYq+I59+8jrxdwB3NPnFMLZBCZRESBXa9gDc0KkvtlFuH?= =?us-ascii?Q?iWmzCZz/cJsRdWwQQgWpY2VBSAODClWW8/79P7yemQEByOEij5TrOMQvynti?= =?us-ascii?Q?VDoBo19FMjOD77u3fBZkqGp7WqUBdNCo3f1I/y6dB6LGwItrZhcBoLzWaRqo?= =?us-ascii?Q?zr8J0NM2bkop/ud6TWbpDUQO00f2DNPp3BLHF0scwcHpEEHxEq1RZiFoEpab?= =?us-ascii?Q?FvYpiNMISQlUgGog/x4K1t2f7TAudJvovGAwxWqENV7G4UydhLzelw0e5npf?= =?us-ascii?Q?ooUjTaOLPjgK7t/asHxAIEib+4esk10DntYhEaq6H+xZUQEBu0Rner7jmP9Q?= =?us-ascii?Q?tewDaI01IMgZTgF03THN8GMTvjxkMHH6K5pZm3wCgp5YTV1d3Q+BsvtBJlmT?= =?us-ascii?Q?ZWfTHU+oZucfUqn7j3i/5HGnpw2exy/e1NLjh4XbNeo6T6GOPjjQ4VawRBxv?= =?us-ascii?Q?v9zwMYt5WrHvGY0S/O1cMnzCG4U3tBYrdSoeSd4WIyaWST24A4Wy0B8vVfQ+?= =?us-ascii?Q?4O0gqPOWx1GGQ/iP05P75ri4mH9DgwSStmXVT7Nu9Pbt6aBhu4P/u66aP7F0?= =?us-ascii?Q?SE7qG+gWUshvETAJoDyUlgccgyQY/v8ubWK6L+C3t3yVs9tEU2TYRSSkjhua?= =?us-ascii?Q?YM2p0MHj51k3FChsbkN52ddihVVy/NkdE69pv+vXPhVTJh9y25+gbpHryZ+I?= =?us-ascii?Q?VbVWTsaSmg2zu0/D4CdvTQe4+gISKxWkaXGlz5Ps8yyK60U901uDWIyC5NiH?= =?us-ascii?Q?BxJ3YpscjQCIGpmwlIhl3f+QH8wezG69ILE1hcQiAsffcJK3KuGt1OyLmX4H?= =?us-ascii?Q?nL0hPg2TDyIPEb5AU1hKH4XYPjDkZmrvFjZyN16gOt1cVz7JEZnPZoYh4MS2?= =?us-ascii?Q?2jiar7RIZupM37ueXorwICb4lJjjBIh/K0l1jKJF/IzbQA/VNqcQb7xaDpUW?= =?us-ascii?Q?z2YnEfb7IXnmIClFsyfJIHe+WP5uoYaSZbud7hxzRLEB8h1OM5Ll39mP9gB7?= =?us-ascii?Q?IhsfhcDk9mBogXgHGDmlIQouG+SpDHWNeU5z3wQRcegiwPJxp9uN8riSUp7V?= =?us-ascii?Q?YA3iQ+aU4s9/03gYKuZLeefatWHRmcizNp4HTSOY5496sssjZlkOYmGEEUZj?= =?us-ascii?Q?bJovNO1v2wm9yMQQTkX9Ygxxe4NVmIpmcVIti9YU8HEDPYvnPpjiMBUnMJ0y?= =?us-ascii?Q?7xeoB/sj+aaRC4U63UhYm9geI04Z/j4HUTv8eseNTxOxpCkfDsFV54HawiNU?= =?us-ascii?Q?Y2siu1nV8ZwlqeLkflqNliGQZlepXkQzfgbL3NbG0x/tJFta8YaDIfTbaObQ?= =?us-ascii?Q?91VfW+NMbFGHHxl7GU7h7LDXCxXvIssyQQdbFtC/4Q7ZN/K2h5NvXqxb6nG7?= =?us-ascii?Q?TDdIXQoicTXAxxbB2zf7RJbRCI7FXCWs8WpfVRD7HuCmeYBWAxcQucd2HjsO?= =?us-ascii?Q?watVxKVdk9GsVMgIo6BmN0lpqnIyNIQQqlGN2nYEMjinFQCSOLbUYQIslvq4?= =?us-ascii?Q?LAuPcxXCpUdc9irAiVf3W36RcAindFJ3aPjBLppXlKwXR3qgpZhj09gAKK+p?= =?us-ascii?Q?PiFlm4phpkHgXrJtYLXdapzKTLVq4F1Msc6a/NVNZw38H9MLYmtlh3Gf1Xoj?= =?us-ascii?Q?sAhnIqR5Zb2EL5l3QD3bIQrhMOlTp/GP5jknAZBJe/c1TZqdUPY9z4Gad3EM?= =?us-ascii?Q?fiVQzbue68TdRE/qQgCdvjTUJKXgqrEQ4U4Yv9vwAX3aBZGqlQP+zHP87qpw?= =?us-ascii?Q?bxZ6MlWx3Q=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 420f57cf-c7fc-4208-b795-08de95f790f7 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2370.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2026 05:19:25.9787 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qmSyf/YnRqABpsc0BDuRTn+wD25I9dDlBPQtMfe4BWfzKomYFRIGb2Vt3HBEGP8OnxXXCxBWpGJNtkUDg12SGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7455 CXL is linked before fwctl in drivers/Makefile. Both use `module_init, so `cxl_pci_driver_init()` runs first. When `cxl_pci_probe()` calls `fwctl_register()` and then `device_add()`, fwctl_class is not yet registered because fwctl_init() hasn't run, causing `class_to_subsys()` to return NULL and skip knode_class initialization. On device removal, `class_to_subsys()` returns non-NULL, and `device_del()` calls `klist_del()` on the uninitialized knode, triggering a NULL pointer dereference [1]. Fixes: 858ce2f56b52 ("cxl: Add FWCTL support to CXL") Signed-off-by: Richard Cheng Reviewed-by: Kai-Heng Feng --- [1]: The error is triggered on with 7.0.0-rc6 kernel with CXL device. The PCI topology is as below ``` $ sudo lspci -tv -[0001:00]---00.0-[01]--+-00.0 Mellanox Technologies CX8 Family [ConnectX-8] +-00.1 Mellanox Technologies CX8 Family [ConnectX-8] +-00.2 Mellanox Technologies CX8 Family [ConnectX-8] \-00.3 Mellanox Technologies CX8 Family [ConnectX-8] -[0002:00]---00.0-[01]-- -+-[0003:00]---00.0-[01]----00.0 Montage Technology Co., Ltd. Device c002 \-[0003:80]---00.0-[81]----00.0 Montage Technology Co., Ltd. Device c002 -[0004:00]---00.0-[01]-- -+-[0005:00]---00.0-[01]----00.0 Samsung Electronics Co Ltd Device a810 +-[0005:40]---00.0-[41]----00.0 Samsung Electronics Co Ltd Device a810 +-[0005:c0]---00.0-[c1]----00.0 Intel Corporation I210 Gigabit Network Connection \-[0005:e0]---00.0-[e1-e2]----00.0-[e2]--+-00.0 ASPEED Technology, Inc. ASPEED Graphics Family \-02.0 ASPEED Technology, Inc. Device 2603 -+-[0006:00]---00.0-[01]-- \-[0006:80]---00.0-[81]-- ``` The CXL device is on 0003:01:00.0 CXL [0502]: Montage Technology Co., Ltd. Device [1b00:c002] (rev 03) and another one is 0003:81:00.0 CXL [0502]: Montage Technology Co., Ltd. Device [1b00:c002] (rev 03). The one we are targeting is 0003:01:00.0. The kernel should be built with CONFIG_FWCTL=y and CONFIG_CXL_FEATURES=y, otherwise the bug won't be triggered. With `sudo setpci -v -s 0003:00:00.0 CAP_EXP+0x10.b=0x10:0x10` to bring its root port link down and the error log in dmesg is like the following ``` [ 890.137377] pcieport 0003:00:00.0: pciehp: Slot(0-2): Link Down [ 890.145201] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020 [ 890.145203] Mem abort info: [ 890.145205] ESR = 0x0000000096000006 [ 890.145207] EC = 0x25: DABT (current EL), IL = 32 bits [ 890.145208] SET = 0, FnV = 0 [ 890.145209] EA = 0, S1PTW = 0 [ 890.145211] FSC = 0x06: level 2 translation fault [ 890.145212] Data abort info: [ 890.145213] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000 [ 890.145214] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [ 890.145215] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 890.145216] user pgtable: 4k pages, 48-bit VAs, pgdp=00000001d1937000 [ 890.145218] [0000000000000020] pgd=08000001d193e403, p4d=08000001d193e403, pud=08000001d193d403, pmd=0000000000000000 [ 890.145223] Internal error: Oops: 0000000096000006 [#1] SMP [ 890.214749] Modules linked in: nft_masq nft_ct nft_reject_ipv4 nf_reject_ipv4 nft_reject act_csum cls_u32 sch_htb nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables bridge stp llc qrtr cfg80211 binfmt_misc nls_iso8859_1 ast cxl_pmu dax_hmem nvidia_cspmu acpi_power_meter coresight_trbe sbsa_gwdt ipmi_ssif acpi_ipmi cxl_acpi arm_smmuv3_pmu coresight arm_cspmu_module arm_spe_pmu ipmi_devintf ipmi_msghandler cxl_pmem cppc_cpufreq sch_fq_codel dm_multipath nvme_fabrics efi_pstore nfnetlink dmi_sysfs ip_tables x_tables autofs4 btrfs libblake2b raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor xor_neon raid6_pq raid1 raid0 linear mlx5_ib macsec ib_uverbs ib_core mlx5_dpll ghash_ce sm4_ce_gcm nvme sm4_ce_ccm mlx5_core nvme_core sm4_ce mlxfw nvme_keyring sm4_ce_cipher tls sm4 igb nvme_auth sm3_ce arm_smccc_trng i2c_algo_bit hkdf psample aes_neon_bs aes_neon_blk aes_ce_blk [ 890.294573] CPU: 28 UID: 0 PID: 1350 Comm: irq/156-pciehp Not tainted 7.0.0-rc6-richard+ #3 PREEMPT(full) [ 890.304108] Hardware name: , BIOS buildbrain-gcid-sbios-44706962 Mon Mar 30 03:04:08 PM UTC 2026 [ 890.312959] pstate: 61400009 (nZCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--) [ 890.319660] pc : klist_put+0x2c/0x140 [ 890.323441] lr : klist_del+0x18/0x38 [ 890.327050] sp : ffff80008cfd39e0 [ 890.330229] x29: ffff80008cfd39e0 x28: 0000000000000018 x27: ffffd9f0a1a9deb0 [ 890.337275] x26: ffffd9f0a1a9a2b8 x25: ffff00009c3ebe78 x24: ffff00009c3ebe00 [ 890.344321] x23: ffff00008d1cc800 x22: 0000000000000001 x21: ffff00009c3ebe68 [ 890.351367] x20: 0000000000000000 x19: ffff00009afc7188 x18: ffff80008cfb50a8 [ 890.358413] x17: 0000000000000000 x16: 0000000000000000 x15: 633d4d4554535953 [ 890.365459] x14: 42555300302e306d x13: 5300302e306d656d x12: 5f756d702f302e30 [ 890.372504] x11: 0035333033343d4d x10: 0000000000000000 x9 : ffffd9f0a31b9a5c [ 890.379551] x8 : 0101010101010101 x7 : 7fff7f7f7f7f7f7f x6 : 339eff3033746f62 [ 890.386597] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 [ 890.393642] x2 : 0000000000000000 x1 : 0000000000000001 x0 : 0000000000000000 [ 890.400689] Call trace: [ 890.402923] klist_put+0x2c/0x140 (P) [ 890.406703] klist_del+0x18/0x38 [ 890.409968] device_del+0x120/0x3c8 [ 890.413148] cdev_device_del+0x2c/0xa8 [ 890.416928] fwctl_unregister+0x11c/0x128 [ 890.420967] free_memdev_fwctl+0x24/0x50 [ 890.424919] devm_action_release+0x20/0x48 [ 890.428786] release_nodes+0x68/0xc8 [ 890.432481] devres_release_all+0x9c/0x130 [ 890.436348] device_unbind_cleanup+0x24/0xb0 [ 890.440730] device_release_driver_internal+0x234/0x2e0 [ 890.445627] device_release_driver+0x24/0x50 [ 890.450096] pci_stop_bus_device+0x88/0x100 [ 890.453962] pci_stop_and_remove_bus_device+0x24/0x58 [ 890.459118] pciehp_unconfigure_device+0xb4/0x1e0 [ 890.463758] pciehp_disable_slot+0x7c/0x190 [ 890.467710] pciehp_handle_presence_or_link_change+0x94/0x518 [ 890.473554] pciehp_ist+0x1c8/0x310 [ 890.476819] irq_thread_fn+0x38/0xd0 [ 890.480599] irq_thread+0x1ac/0x450 [ 890.483779] kthread+0x13c/0x150 [ 890.487215] ret_from_fork+0x10/0x20 [ 890.490739] Code: 12001c36 f9400014 927ffa94 aa1403e0 (f9401295) [ 890.496668] ---[ end trace 0000000000000000 ]--- [ 890.552081] genirq: exiting task "irq/156-pciehp" (1350) is an active IRQ thread (irq 156) ``` Best regards, Richard Cheng. --- drivers/fwctl/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fwctl/main.c b/drivers/fwctl/main.c index bc6378506296..098c3824ad75 100644 --- a/drivers/fwctl/main.c +++ b/drivers/fwctl/main.c @@ -415,7 +415,7 @@ static void __exit fwctl_exit(void) unregister_chrdev_region(fwctl_dev, FWCTL_MAX_DEVICES); } -module_init(fwctl_init); +subsys_initcall(fwctl_init); module_exit(fwctl_exit); MODULE_DESCRIPTION("fwctl device firmware access framework"); MODULE_LICENSE("GPL"); -- 2.43.0