From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9DCB33B95E for ; Thu, 9 Apr 2026 07:06:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775718419; cv=none; b=BkdyX8cMIRJr/lswnUIprsKuwaDiOMuJR0MfeQoKDv1rMM4JB1ARH2TghaYf3hCUw/VkNylCjsR2mBULQmgf+7+h4HP25UBSZ9T5vs/YG2QklRuURksTZw6w+xeUyZcr8AuRO89RVLeRgwSBatH9Z+oJOIM9bR6j/xgTwJT8Ldc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775718419; c=relaxed/simple; bh=HqDHRNm9BlO10tBUdSahIpJVMdUXQ+Kkwot9S1XzJoQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oFhuWZ+IezmJmDCa3fxp5RZ3sLFbkKxXSkgJe4oaQm5ceg9mTuBXg/eLsSx4e1yl7FQp5EJ1JrfyZJUZUD9kjRu75hyaG3lcy0/ml6WBWeka3EEhrsnVZNi/RjRDRrMKhvjLQ+WRPBKxK5/CLxcxq+q/MISQ5A5IhjCww6m9j+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BlLs+WxP; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BlLs+WxP" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-35da9c0c007so605989a91.2 for ; Thu, 09 Apr 2026 00:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775718417; x=1776323217; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AbcoiDxqvm3yVuuY+3FJXoEqdX3dggqK0L2trSGSZKo=; b=BlLs+WxPXUUmJ367bf1Fufd2wgnqQh5IbH66lhOLlAyrx3gr1yS0H/uWxtLcFKnCOs tObtzRVDl7JlPfQ/o51/wXVHUaVGcirqHsUu9wmskX2Su4Tqpa4hATArVBZFl99LAmeM tULwNYCeu6ZdcnIR+Ef4F4i8xpIMPh7eKqCnDULYr2+8pqiItD+UBsLt3W2i7MnHbgQU XTyJsjFbfGi0xxhKqidnwIt+sFYM9NAs+oJTcNr32/3k74xTxlH2uVFIfuc5FZVjZDU4 j2LbCjXC8y/eFDrx5RUqeylozbLUPmSsrbErHny7sASXRe2UZPggVG36rWHZ9g4kfXIL u8mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775718417; x=1776323217; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AbcoiDxqvm3yVuuY+3FJXoEqdX3dggqK0L2trSGSZKo=; b=kIXDXExKm2AJOCZKSnxV2H/NNSGNl3cozbyxgYaz/0jgJoqSVqSkRCZ8HRPy26PXbt /eCs3lqYM0Oqc2L//CgMcbIQOlmAKfVOyc8qhwSHHKmLdh9NLhwCklwOBvc/Csp1jfo7 veVe//ZHI1KNqyPW4jpQ2juBNcOkcya1IV55jzt141xquTW18CWWEz7HwCBE3hWGHnOf xEXvueOFM5npY3QFj27dqKsX7tOH9wf/wstJ4UpjIT0L/9wyeJxHuKaH74wBVAdhPsN4 bz5sA41eJp8ONuqyLbGNKxZIQXmYv5IUYSGqZoH+k2+xxcHqXMLvitHWlxSSEFaYdFCR 38Vw== X-Forwarded-Encrypted: i=1; AJvYcCWMCokQqZ5Qg7QMnyPSW9Y7KDCIpxz8ZH7+1w3y70iJWYBHWaxSdnb9nHL3csGw01xU0IPXFOhbZqR0IKU=@vger.kernel.org X-Gm-Message-State: AOJu0YwrdEdW2G2NRwIGqrP3JfSc9KpbdW3obtIWwF1VNdibXvVzxHk6 XicAbRFUjP2AuUErNa/xL6ONBoDvQkJF/HP5KMvIAh0222HCLkSu8T5U X-Gm-Gg: AeBDiesvUgpdiNP8efygNGPWlxBFrgAynBbz9wbe1O1FQIur1m6Ebk8kwgD15OX7B6l qv4CZ/EkfahLNDZCSfPXHUMDZ3lMC+vh0VL0lDK6idj1IibBJRc5YZ+Xz6stF7JKLo+0Icf7W71 G+1AwaCn/Rf/5F1IVK0OPTN3hFvUrL72ecIKsbBPeCP+YJ2wx+OE6ZYLmwO0xDKQakmSVe40yRi tw4wQ6Ug1bK6zY07tKysXyn0qXHSyqm50ax2JSypSXl3wUQNOvZ57KSTWKIQFw88LBk0Vs0XCUm PBMjgDjRceN1dByCcGjZBmBJZK3SruUy1XWzN1QjH/WXIeRnTEo7Tq9Xz7rp1S3uHXEH3GLcbub Nh2SIkstoKjcIA5PsL3wpZfo6eHNeuO5DUHThjvh575iW0Px6YK7Z8QTTWjmkfQUjoL2LhiuPE1 JW6UhZ54xL4Qs+Cv+3G2qpmzsQlz7+urgGKv0zhFCg96Lyccl1fHbpq2IFyazLTMnv6YJIUSf1M kJyZgjv X-Received: by 2002:a17:903:3205:b0:2b2:4eec:9806 with SMTP id d9443c01a7336-2b28182ca4cmr282342715ad.8.1775718417185; Thu, 09 Apr 2026 00:06:57 -0700 (PDT) Received: from kernel-fuzz.. ([138.199.21.245]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27472d55fsm297666265ad.11.2026.04.09.00.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 00:06:56 -0700 (PDT) From: ZhengYuan Huang To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, r33s3n6@gmail.com, zzzccc427@gmail.com, ZhengYuan Huang Subject: [PATCH v2] ocfs2: validate bg_bits during freefrag scan Date: Thu, 9 Apr 2026 15:06:24 +0800 Message-ID: <20260409070624.3357378-1-gality369@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [BUG] A crafted filesystem can trigger an out-of-bounds bitmap walk when OCFS2_IOC_INFO is issued with OCFS2_INFO_FL_NON_COHERENT. BUG: KASAN: use-after-free in instrument_atomic_read include/linux/instrumented.h:68 [inline] BUG: KASAN: use-after-free in _test_bit include/asm-generic/bitops/instrumented-non-atomic.h:141 [inline] BUG: KASAN: use-after-free in test_bit_le include/asm-generic/bitops/le.h:21 [inline] BUG: KASAN: use-after-free in ocfs2_info_freefrag_scan_chain fs/ocfs2/ioctl.c:495 [inline] BUG: KASAN: use-after-free in ocfs2_info_freefrag_scan_bitmap fs/ocfs2/ioctl.c:588 [inline] BUG: KASAN: use-after-free in ocfs2_info_handle_freefrag fs/ocfs2/ioctl.c:662 [inline] BUG: KASAN: use-after-free in ocfs2_info_handle_request+0x1c66/0x3370 fs/ocfs2/ioctl.c:754 Read of size 8 at addr ffff888031bce000 by task syz.0.636/1435 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0xbe/0x130 lib/dump_stack.c:120 print_address_description mm/kasan/report.c:378 [inline] print_report+0xd1/0x650 mm/kasan/report.c:482 kasan_report+0xfb/0x140 mm/kasan/report.c:595 check_region_inline mm/kasan/generic.c:186 [inline] kasan_check_range+0x11c/0x200 mm/kasan/generic.c:200 __kasan_check_read+0x11/0x20 mm/kasan/shadow.c:31 instrument_atomic_read include/linux/instrumented.h:68 [inline] _test_bit include/asm-generic/bitops/instrumented-non-atomic.h:141 [inline] test_bit_le include/asm-generic/bitops/le.h:21 [inline] ocfs2_info_freefrag_scan_chain fs/ocfs2/ioctl.c:495 [inline] ocfs2_info_freefrag_scan_bitmap fs/ocfs2/ioctl.c:588 [inline] ocfs2_info_handle_freefrag fs/ocfs2/ioctl.c:662 [inline] ocfs2_info_handle_request+0x1c66/0x3370 fs/ocfs2/ioctl.c:754 ocfs2_info_handle+0x18d/0x2a0 fs/ocfs2/ioctl.c:828 ocfs2_ioctl+0x632/0x6e0 fs/ocfs2/ioctl.c:913 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:597 [inline] __se_sys_ioctl fs/ioctl.c:583 [inline] __x64_sys_ioctl+0x197/0x1e0 fs/ioctl.c:583 ... [CAUSE] ocfs2_info_freefrag_scan_chain() uses on-disk bg_bits directly as the bitmap scan limit. The coherent path reads group descriptors through ocfs2_read_group_descriptor(), which validates the descriptor before use. The non-coherent path uses ocfs2_read_blocks_sync() instead and skips that validation, so an impossible bg_bits value can drive the bitmap walk past the end of the block. [FIX] Compute the bitmap capacity from the filesystem format with ocfs2_group_bitmap_size(), report descriptors whose bg_bits exceeds that limit, and clamp the scan to the computed capacity. This keeps the freefrag report going while avoiding reads beyond the buffer. Signed-off-by: ZhengYuan Huang --- v2: - Use ocfs2_group_bitmap_size() instead of the on-disk bg_size field - Clamp bg_bits to the computed bitmap capacity and continue scanning --- fs/ocfs2/ioctl.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c index b6864602814c..fa0ca014c6d5 100644 --- a/fs/ocfs2/ioctl.c +++ b/fs/ocfs2/ioctl.c @@ -441,7 +441,7 @@ static int ocfs2_info_freefrag_scan_chain(struct ocfs2_super *osb, struct buffer_head *bh = NULL; struct ocfs2_group_desc *bg = NULL; - unsigned int max_bits, num_clusters; + unsigned int max_bits, max_bitmap_bits, num_clusters; unsigned int offset = 0, cluster, chunk; unsigned int chunk_free, last_chunksize = 0; @@ -474,11 +474,28 @@ static int ocfs2_info_freefrag_scan_chain(struct ocfs2_super *osb, } bg = (struct ocfs2_group_desc *)bh->b_data; + max_bits = le16_to_cpu(bg->bg_bits); + max_bitmap_bits = 8U * + ocfs2_group_bitmap_size(osb->sb, 1, + osb->s_feature_incompat); + + /* + * Non-coherent scans read raw blocks and do not get the + * bg_bits validation from + * ocfs2_read_group_descriptor(). + */ + if (max_bits > max_bitmap_bits) { + mlog(ML_ERROR, + "Group desc #%llu has %u bits, max bitmap bits %u\n", + (unsigned long long)blkno, + max_bits, + max_bitmap_bits); + max_bits = max_bitmap_bits; + } if (!le16_to_cpu(bg->bg_free_bits_count)) continue; - max_bits = le16_to_cpu(bg->bg_bits); offset = 0; for (chunk = 0; chunk < chunks_in_group; chunk++) { -- 2.43.0