From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E3003290B7 for ; Thu, 9 Apr 2026 07:38:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775720305; cv=none; b=MCY2exSdV2n6Ry69fDdtkx21PHHHjYz0GOpHF1+O2FkYg5fD2BQmV2Pg+lRMbyiwVajB+Ys9XqJDr2CfReTAp4cFdrqwxFCS3v88L4B7bM6IniWW5vgsybenrbR57mhD+fz211STDija6dO5mT7Z2FP59NdvEfmva8tmryhtS6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775720305; c=relaxed/simple; bh=8xXXIyEyFcsv2WEY6XC1McBLZV1mz4fpXbk4JS0/CGU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iflhve28IP7IFwE3vZQGY4zjZ/oJnYadAx3qDEWMkrVRIWEuS27PDzADw9CGOfYJtI5ObBYnNtNR3dEwrQ6Gi4wdgYFIRqH6hc2hpYpjs6EX3ayCRk5DFi0xLhJgTtbjDz+GmovRGvYPJDm4MW0N30UW//05fnR7c+3Dl3n5SXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=dCdabzY7; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="dCdabzY7" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1775720291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=XO95DJgYuIRiki/em3gJ46nrj4GuCDSSRhhf89cQDVQ=; b=dCdabzY7Vtmn2JPhi/tvJjImF+9bugoSmpITqOutVd79xknoN1x2SPvRbo/V6mA3QrDsBX gToAaBu2ZMtWsaHTNti5M2XPnkrr+yaVMo2LVRlHnJD23JsbaSG2S1/VgWdRJCy4e0nK/G CtRsUWrcn8fSSaFJm30ZYlGDtw4QtbU= From: Thorsten Blum To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Tim Bird , Thorsten Blum Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND net-next 1/2] keys, dns: drop unused upayload->data NUL terminator Date: Thu, 9 Apr 2026 09:37:11 +0200 Message-ID: <20260409073711.57020-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1180; i=thorsten.blum@linux.dev; h=from:subject; bh=8xXXIyEyFcsv2WEY6XC1McBLZV1mz4fpXbk4JS0/CGU=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDJnXw9VXserX9Z8TnZpYa7XZf9+D42wRZ97Y33L5u3T+n vMOZ2zfdpSyMIhxMciKKbI8mPVjhm9pTeUmk4idMHNYmUCGMHBxCsBEvj1k+CsWs2DhpoXJzmmH S8r/LuKIT6xqWNuafOCc+3k+3eWsNgEM/wuv9beVFMfH7T59SIFvQ4XJ9MqjjyYk7Z97Q1Qo2sf BmQ8A X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT In dns_resolver_preparse(), do not NUL-terminate ->data and allocate one byte less. The NUL terminator is never used and only ->datalen bytes are accessed. Signed-off-by: Thorsten Blum --- Resending this because patch 2/2 didn't go to netdev@ (Jakub) Cc: netdev@vger.kernel.org --- net/dns_resolver/dns_key.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/dns_resolver/dns_key.c b/net/dns_resolver/dns_key.c index c3c8c3240ef9..451247864a63 100644 --- a/net/dns_resolver/dns_key.c +++ b/net/dns_resolver/dns_key.c @@ -203,7 +203,7 @@ dns_resolver_preparse(struct key_preparsed_payload *prep) kdebug("store result"); prep->quotalen = result_len; - upayload = kmalloc_flex(*upayload, data, result_len + 1); + upayload = kmalloc_flex(*upayload, data, result_len); if (!upayload) { kleave(" = -ENOMEM"); return -ENOMEM; @@ -211,7 +211,6 @@ dns_resolver_preparse(struct key_preparsed_payload *prep) upayload->datalen = result_len; memcpy(upayload->data, data, result_len); - upayload->data[result_len] = '\0'; prep->payload.data[dns_key_data] = upayload; kleave(" = 0");