[PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Prithvi Tambewagh]

This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
majorly focusing on fixing checkpatch warnings of constant being on right
side of test in comparisons, deletion of empty if block ,use of
read_poll_timeout_atomic(), and other code simplifications.

Changes since v3:
- Rebased the patches on top of staging-next
- Remove compilation output from cover letter
- Add changes in each patch version in cover letter

v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534

Changes since v2:
- Create patch series, each doing one logical thing
- Use read_poll_timeout_atomic() in _is_fw_read_cmd_down()
- Use single return statement instead of if-else blocks containing return 
  true and return false, in IsFrameTypeCtrl()
- Remove unnecessary changes from the patches
- Convey testing status of the patches 

v2 link: https://lore.kernel.org/linux-staging/20260403094647.fmgop6xh2cjpit3s@inspiron/T/#m3d08fd012119772ea55df48eea80abbea34e8548

Changes since v1:
- Check for more changes of the type of placing constant on right side of 
  comparison/test in drivers/staging/rtl8723bs/

v1 link: https://lore.kernel.org/linux-staging/20260323145214.ubhshy2gwp52j5zh@inspiron/T/#mc3b693b37c49fbdde89171b7f1bf61b7ba8eb964

This patch series is compile tested using the following commands, which
include setting the necessary configurations:
        1. make defconfig
        2. scripts/config --enable CONFIG_STAGING
        3. scripts/config --module CONFIG_MMC
        4. scripts/config --module CONFIG_RTL8723BS
        5. make olddefconfig
        6. make -j$(nproc)
        7. git rebase -i --exec "make -j$(nproc) M=drivers/staging/rtl8723bs" HEAD~5 

However, as Luka reviewed v3 - since these are only style changes, testing
is not necessary, so I dropped RFT tag from the patch series.

Prithvi Tambewagh (5):
  staging: rtl8723bs: move constant to right side of test in comparison
  staging: rtl8723bs: remove empty if statement block
  staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl()
  staging: rtl8723bs: use read_poll_timeout_atomic in
    _is_fw_read_cmd_down
  staging: rtl8723bs: remove duplicate rate checks in
    PHY_GetTxPowerIndexBase()

 .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c    |  4 ++--
 drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c |  5 +----
 drivers/staging/rtl8723bs/hal/hal_com.c        |  2 +-
 drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 11 +++++------
 drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c   | 18 +++++++-----------
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c  | 18 +++++++++---------
 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c |  2 +-
 drivers/staging/rtl8723bs/include/ieee80211.h  |  4 ++--
 drivers/staging/rtl8723bs/include/wifi.h       |  5 +----
 9 files changed, 29 insertions(+), 40 deletions(-)

-- 
2.34.1

[PATCH v4 1/5] staging: rtl8723bs: move constant to right side of test in comparison

[Prithvi Tambewagh]

Move constant from the left side to the right side of the test in a
comparison, where ==, !=, <=, >=, <, > operators are used, fixing the
checkpatch warning: Comparisons should place the constant on the right
side of the test.

Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
---
 .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c    |  4 ++--
 drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c |  2 +-
 drivers/staging/rtl8723bs/hal/hal_com.c        |  2 +-
 drivers/staging/rtl8723bs/hal/hal_com_phycfg.c |  4 ++--
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c  | 18 +++++++++---------
 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c |  2 +-
 drivers/staging/rtl8723bs/include/ieee80211.h  |  4 ++--
 7 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
index d32dbf94858f..58f6cf063498 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
@@ -2211,7 +2211,7 @@ static void halbtc8723b2ant_RunCoexistMechanism(struct btc_coexist *pBtCoexist)
 	}
 
 	algorithm = halbtc8723b2ant_ActionAlgorithm(pBtCoexist);
-	if (pCoexSta->bC2hBtInquiryPage && (BT_8723B_2ANT_COEX_ALGO_PANHS != algorithm)) {
+	if (pCoexSta->bC2hBtInquiryPage && (algorithm != BT_8723B_2ANT_COEX_ALGO_PANHS)) {
 		halbtc8723b2ant_ActionBtInquiry(pBtCoexist);
 		return;
 	} else {
@@ -2490,7 +2490,7 @@ void EXhalbtc8723b2ant_BtInfoNotify(
 		return;
 	}
 
-	if (BT_INFO_SRC_8723B_2ANT_WIFI_FW != rspSource) {
+	if (rspSource != BT_INFO_SRC_8723B_2ANT_WIFI_FW) {
 		pCoexSta->btRetryCnt = pCoexSta->btInfoC2h[rspSource][2] & 0xf; /* [3:0] */
 
 		pCoexSta->btRssi = pCoexSta->btInfoC2h[rspSource][3] * 2 + 10;
diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
index 8f6849f2277e..0780847e287d 100644
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
@@ -301,7 +301,7 @@ static void GetDeltaSwingTable_8723B(
 	u16 rate = *(pDM_Odm->pForcedDataRate);
 	u8 channel = pHalData->CurrentChannel;
 
-	if (1 <= channel && channel <= 14) {
+	if (channel >= 1 && channel <= 14) {
 		if (IS_CCK_RATE(rate)) {
 			*TemperatureUP_A   = pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_P;
 			*TemperatureDOWN_A = pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_N;
diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 728a2171fbcb..5473dca13695 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -107,7 +107,7 @@ u8 hal_com_config_channel_plan(
 	pHalData->bDisableSWChannelPlan = false;
 	chnlPlan = def_channel_plan;
 
-	if (0xFF == hw_channel_plan)
+	if (hw_channel_plan == 0xFF)
 		auto_load_fail = true;
 
 	if (!auto_load_fail) {
diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index bdd595a99b98..2746da0a9846 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
@@ -466,11 +466,11 @@ u8 PHY_GetTxPowerIndexBase(
 
 	if (IS_CCK_RATE(Rate))
 		txPower = pHalData->Index24G_CCK_Base[RFPath][chnlIdx];
-	else if (MGN_6M <= Rate)
+	else if (Rate >= MGN_6M)
 		txPower = pHalData->Index24G_BW40_Base[RFPath][chnlIdx];
 
 	/*  OFDM-1T */
-	if ((MGN_6M <= Rate && Rate <= MGN_54M) && !IS_CCK_RATE(Rate))
+	if ((Rate >= MGN_6M && Rate <= MGN_54M) && !IS_CCK_RATE(Rate))
 		txPower += pHalData->OFDM_24G_Diff[RFPath][TX_1S];
 
 	if (BandWidth == CHANNEL_WIDTH_20) { /*  BW20-1S, BW20-2S */
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index e794fe3caf9d..b15899580893 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -405,11 +405,11 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter, bool  bUsedWoWLANFw)
 			break;
 	}
 	_FWDownloadEnable(padapter, false);
-	if (_SUCCESS != rtStatus)
+	if (rtStatus != _SUCCESS)
 		goto fwdl_stat;
 
 	rtStatus = _FWFreeToGo(padapter, 10, 200);
-	if (_SUCCESS != rtStatus)
+	if (rtStatus != _SUCCESS)
 		goto fwdl_stat;
 
 fwdl_stat:
@@ -1165,15 +1165,15 @@ s32 rtl8723b_InitLLTTable(struct adapter *padapter)
 
 static void hal_get_chnl_group_8723b(u8 channel, u8 *group)
 {
-	if (1  <= channel && channel <= 2)
+	if (channel >= 1 && channel <= 2)
 		*group = 0;
-	else if (3  <= channel && channel <= 5)
+	else if (channel >= 3 && channel <= 5)
 		*group = 1;
-	else if (6  <= channel && channel <= 8)
+	else if (channel >= 6 && channel <= 8)
 		*group = 2;
-	else if (9  <= channel && channel <= 11)
+	else if (channel >= 9 && channel <= 11)
 		*group = 3;
-	else if (12 <= channel && channel <= 14)
+	else if (channel >= 12 && channel <= 14)
 		*group = 4;
 }
 
@@ -1221,7 +1221,7 @@ static void Hal_ReadPowerValueFromPROM_8723B(
 
 	memset(pwrInfo24G, 0, sizeof(struct TxPowerInfo24G));
 
-	if (0xFF == PROMContent[eeAddr+1])
+	if (PROMContent[eeAddr+1] == 0xFF)
 		AutoLoadFail = true;
 
 	if (AutoLoadFail) {
@@ -2037,7 +2037,7 @@ static void hw_var_set_bcn_func(struct adapter *padapter, u8 variable, u8 *val)
 		val8 &= ~(EN_BCN_FUNCTION | EN_TXBCN_RPT);
 
 		/*  Always enable port0 beacon function for PSTDMA */
-		if (REG_BCN_CTRL == bcn_ctrl_reg)
+		if (bcn_ctrl_reg == REG_BCN_CTRL)
 			val8 |= EN_BCN_FUNCTION;
 
 		rtw_write8(padapter, bcn_ctrl_reg, val8);
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index f50726d2ed0c..ff39077deb69 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -415,7 +415,7 @@ int rtl8723bs_xmit_thread(void *context)
 		if (signal_pending(current)) {
 			flush_signals(current);
 		}
-	} while (_SUCCESS == ret);
+	} while (ret == _SUCCESS);
 
 	complete(&pxmitpriv->SdioXmitTerminate);
 
diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index fbb12fe31a6c..a3f519e2f6d2 100644
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -394,8 +394,8 @@ enum {
 };
 
 #define IS_HT_RATE(_rate)				(_rate >= MGN_MCS0 && _rate <= MGN_MCS31)
-#define IS_CCK_RATE(_rate)				(MGN_1M == _rate || _rate == MGN_2M || _rate == MGN_5_5M || _rate == MGN_11M)
-#define IS_OFDM_RATE(_rate)				(MGN_6M <= _rate && _rate <= MGN_54M  && _rate != MGN_11M)
+#define IS_CCK_RATE(_rate)				(_rate == MGN_1M || _rate == MGN_2M || _rate == MGN_5_5M || _rate == MGN_11M)
+#define IS_OFDM_RATE(_rate)				(_rate >= MGN_6M && _rate <= MGN_54M  && _rate != MGN_11M)
 
 
 /* NOTE: This data is for statistical purposes; not all hardware provides this
-- 
2.34.1

[PATCH v4 2/5] staging: rtl8723bs: remove empty if statement block

[Prithvi Tambewagh]

Remove empty if statement block for cleaning up code.

Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
---
 drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
index 0780847e287d..6ab65e9e8bee 100644
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
@@ -1415,9 +1415,6 @@ static void phy_IQCalibrate_8723B(
 		}
 	}
 
-	if (0x00 == PathAOK) {
-	}
-
 /* path B IQK */
 	if (is2T) {
 
-- 
2.34.1

[PATCH v4 3/5] staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl()

[Prithvi Tambewagh]

Replace the simple if-else statement which checked value of
GetFrameType(pframe), if equal to WIFI_CTRL_TYPE, function
IsFrameTypeCtrl() returned true else false, with a single return
statement returning true only if GetFrameType(pframe) == WIFI_CTRL_TYPE
otherwise returns false.

Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
---
 drivers/staging/rtl8723bs/include/wifi.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h
index 230b2c4ffd3b..2876f15f13d1 100644
--- a/drivers/staging/rtl8723bs/include/wifi.h
+++ b/drivers/staging/rtl8723bs/include/wifi.h
@@ -275,10 +275,7 @@ static inline unsigned char *get_hdr_bssid(unsigned char *pframe)
 
 static inline int IsFrameTypeCtrl(unsigned char *pframe)
 {
-	if (WIFI_CTRL_TYPE == GetFrameType(pframe))
-		return true;
-	else
-		return false;
+	return GetFrameType(pframe) == WIFI_CTRL_TYPE;
 }
 /*-----------------------------------------------------------------------------
 			Below is for the security related definition
-- 
2.34.1

[PATCH v4 4/5] staging: rtl8723bs: use read_poll_timeout_atomic in _is_fw_read_cmd_down

[Prithvi Tambewagh]

Replace the existing rtw_read8() and do-while loop mechanism with
read_poll_timeout_atomic() from <linux/iopoll.h>, in _is_fw_read_cmd_down()
which is a standard Linux macro, ensuring polling REG_HMETFR efficiently.

Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
index 12416e499ac3..4bdc8e314015 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
@@ -8,6 +8,7 @@
 #include <drv_types.h>
 #include <rtl8723b_hal.h>
 #include <linux/etherdevice.h>
+#include <linux/iopoll.h>
 #include "hal_com_h2c.h"
 
 #define MAX_H2C_BOX_NUMS	4
@@ -18,20 +19,15 @@
 
 static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num)
 {
-	u8 read_down = false;
-	int retry_cnts = 100;
-
 	u8 valid;
+	int ret;
 
-	do {
-		valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num);
-		if (0 == valid) {
-			read_down = true;
-		}
-	} while ((!read_down) && (retry_cnts--));
-
-	return read_down;
+	ret = read_poll_timeout_atomic(rtw_read8,
+				       valid, !(valid & BIT(msgbox_num)),
+				       0, 500, false,
+				       padapter, REG_HMETFR);
 
+	return !ret;
 }
 
 
-- 
2.34.1

[PATCH v4 5/5] staging: rtl8723bs: remove duplicate rate checks in PHY_GetTxPowerIndexBase()

[Prithvi Tambewagh]

The code previously checked (Rate >= MGN_MCS0 && Rate <= MGN_MCS7)
condition twice - once for the (BandWidth == CHANNEL_WIDTH_20) check and
once for the (BandWidth == CHANNEL_WIDTH_40) check. Fix if statement
formatting to move that if check as an outer if check to improve code
formatting.

Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index 2746da0a9846..45dbe1782bae 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
@@ -473,11 +473,10 @@ u8 PHY_GetTxPowerIndexBase(
 	if ((Rate >= MGN_6M && Rate <= MGN_54M) && !IS_CCK_RATE(Rate))
 		txPower += pHalData->OFDM_24G_Diff[RFPath][TX_1S];
 
-	if (BandWidth == CHANNEL_WIDTH_20) { /*  BW20-1S, BW20-2S */
-		if (MGN_MCS0 <= Rate && Rate <= MGN_MCS7)
+	if (Rate >= MGN_MCS0 && Rate <= MGN_MCS7) {
+		if (BandWidth == CHANNEL_WIDTH_20) /*  BW20-1S, BW20-2S */
 			txPower += pHalData->BW20_24G_Diff[RFPath][TX_1S];
-	} else if (BandWidth == CHANNEL_WIDTH_40) { /*  BW40-1S, BW40-2S */
-		if (MGN_MCS0 <= Rate && Rate <= MGN_MCS7)
+		else if (BandWidth == CHANNEL_WIDTH_40) /*  BW40-1S, BW40-2S */
 			txPower += pHalData->BW40_24G_Diff[RFPath][TX_1S];
 	}
 
-- 
2.34.1

Re: [PATCH v4 1/5] staging: rtl8723bs: move constant to right side of test in comparison

[Luka Gejak]

On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> Move constant from the left side to the right side of the test in a
> comparison, where ==, !=, <=, >=, <, > operators are used, fixing the
> checkpatch warning: Comparisons should place the constant on the right
> side of the test.
>
> Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
> ---

...

LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

Re: [PATCH v4 2/5] staging: rtl8723bs: remove empty if statement block

[Luka Gejak]

On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> Remove empty if statement block for cleaning up code.
>
> Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> index 0780847e287d..6ab65e9e8bee 100644
> --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> @@ -1415,9 +1415,6 @@ static void phy_IQCalibrate_8723B(
>  		}
>  	}
>  
> -	if (0x00 == PathAOK) {
> -	}
> -
>  /* path B IQK */
>  	if (is2T) {
>  

LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

Re: [PATCH v4 3/5] staging: rtl8723bs: simplify boolean return in IsFrameTypeCtrl()

[Luka Gejak]

On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> Replace the simple if-else statement which checked value of
> GetFrameType(pframe), if equal to WIFI_CTRL_TYPE, function
> IsFrameTypeCtrl() returned true else false, with a single return
> statement returning true only if GetFrameType(pframe) == WIFI_CTRL_TYPE
> otherwise returns false.
>
> Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
> ---
>  drivers/staging/rtl8723bs/include/wifi.h | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h
> index 230b2c4ffd3b..2876f15f13d1 100644
> --- a/drivers/staging/rtl8723bs/include/wifi.h
> +++ b/drivers/staging/rtl8723bs/include/wifi.h
> @@ -275,10 +275,7 @@ static inline unsigned char *get_hdr_bssid(unsigned char *pframe)
>  
>  static inline int IsFrameTypeCtrl(unsigned char *pframe)
>  {
> -	if (WIFI_CTRL_TYPE == GetFrameType(pframe))
> -		return true;
> -	else
> -		return false;
> +	return GetFrameType(pframe) == WIFI_CTRL_TYPE;
>  }
>  /*-----------------------------------------------------------------------------
>  			Below is for the security related definition

LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

Re: [PATCH v4 4/5] staging: rtl8723bs: use read_poll_timeout_atomic in _is_fw_read_cmd_down

[Luka Gejak]

On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> Replace the existing rtw_read8() and do-while loop mechanism with
> read_poll_timeout_atomic() from <linux/iopoll.h>, in _is_fw_read_cmd_down()
> which is a standard Linux macro, ensuring polling REG_HMETFR efficiently.
>
> Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> index 12416e499ac3..4bdc8e314015 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> @@ -8,6 +8,7 @@
>  #include <drv_types.h>
>  #include <rtl8723b_hal.h>
>  #include <linux/etherdevice.h>
> +#include <linux/iopoll.h>
>  #include "hal_com_h2c.h"
>  
>  #define MAX_H2C_BOX_NUMS	4
> @@ -18,20 +19,15 @@
>  
>  static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num)
>  {
> -	u8 read_down = false;
> -	int retry_cnts = 100;
> -
>  	u8 valid;
> +	int ret;
>  
> -	do {
> -		valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num);
> -		if (0 == valid) {
> -			read_down = true;
> -		}
> -	} while ((!read_down) && (retry_cnts--));
> -
> -	return read_down;
> +	ret = read_poll_timeout_atomic(rtw_read8,
> +				       valid, !(valid & BIT(msgbox_num)),
> +				       0, 500, false,
> +				       padapter, REG_HMETFR);
>  
> +	return !ret;
>  }
>  
>  

LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

Re: [PATCH v4 5/5] staging: rtl8723bs: remove duplicate rate checks in PHY_GetTxPowerIndexBase()

[Luka Gejak]

On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> The code previously checked (Rate >= MGN_MCS0 && Rate <= MGN_MCS7)
> condition twice - once for the (BandWidth == CHANNEL_WIDTH_20) check and
> once for the (BandWidth == CHANNEL_WIDTH_40) check. Fix if statement
> formatting to move that if check as an outer if check to improve code
> formatting.
>
> Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> index 2746da0a9846..45dbe1782bae 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> @@ -473,11 +473,10 @@ u8 PHY_GetTxPowerIndexBase(
>  	if ((Rate >= MGN_6M && Rate <= MGN_54M) && !IS_CCK_RATE(Rate))
>  		txPower += pHalData->OFDM_24G_Diff[RFPath][TX_1S];
>  
> -	if (BandWidth == CHANNEL_WIDTH_20) { /*  BW20-1S, BW20-2S */
> -		if (MGN_MCS0 <= Rate && Rate <= MGN_MCS7)
> +	if (Rate >= MGN_MCS0 && Rate <= MGN_MCS7) {
> +		if (BandWidth == CHANNEL_WIDTH_20) /*  BW20-1S, BW20-2S */
>  			txPower += pHalData->BW20_24G_Diff[RFPath][TX_1S];
> -	} else if (BandWidth == CHANNEL_WIDTH_40) { /*  BW40-1S, BW40-2S */
> -		if (MGN_MCS0 <= Rate && Rate <= MGN_MCS7)
> +		else if (BandWidth == CHANNEL_WIDTH_40) /*  BW40-1S, BW40-2S */
>  			txPower += pHalData->BW40_24G_Diff[RFPath][TX_1S];
>  	}
>  

LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

Re: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Luka Gejak]

On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
> majorly focusing on fixing checkpatch warnings of constant being on right
> side of test in comparisons, deletion of empty if block ,use of
> read_poll_timeout_atomic(), and other code simplifications.
>
> Changes since v3:
> - Rebased the patches on top of staging-next
> - Remove compilation output from cover letter
> - Add changes in each patch version in cover letter
>
> v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534

...

Hi Prithvi,
this seems better, but I have one question. Did patch series appear on 
mailing list to you, because I cant find it and my emails sent today 
don't appear either. Not to be misunderstood I don't believe this is 
your fault but I would like to know if you are experiencing the same 
problem.
Best regards,
Luka Gejak

Re: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Prithvi]

On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote:
> On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> > This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
> > majorly focusing on fixing checkpatch warnings of constant being on right
> > side of test in comparisons, deletion of empty if block ,use of
> > read_poll_timeout_atomic(), and other code simplifications.
> >
> > Changes since v3:
> > - Rebased the patches on top of staging-next
> > - Remove compilation output from cover letter
> > - Add changes in each patch version in cover letter
> >
> > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
> 
> ...
> 
> Hi Prithvi,
> this seems better, but I have one question. Did patch series appear on 
> mailing list to you, because I cant find it and my emails sent today 
> don't appear either. Not to be misunderstood I don't believe this is 
> your fault but I would like to know if you are experiencing the same 
> problem.
> Best regards,
> Luka Gejak

Hi Luka,

I just observed I am also facing the same issue - I am not able to see the 
patch series on the mailing list, no idea why :( However I received the 
sent patches as well as your reviewed by tags on mail but I am not sure why 
the patch series is not visible on the mailing list.

Shall I resend the patch series?

Best Reagrds,
Prithvi

Re: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Luka Gejak]

On April 9, 2026 4:50:45 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote:
>On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote:
>> On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
>> > This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
>> > majorly focusing on fixing checkpatch warnings of constant being on right
>> > side of test in comparisons, deletion of empty if block ,use of
>> > read_poll_timeout_atomic(), and other code simplifications.
>> >
>> > Changes since v3:
>> > - Rebased the patches on top of staging-next
>> > - Remove compilation output from cover letter
>> > - Add changes in each patch version in cover letter
>> >
>> > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
>> 
>> ...
>> 
>> Hi Prithvi,
>> this seems better, but I have one question. Did patch series appear on 
>> mailing list to you, because I cant find it and my emails sent today 
>> don't appear either. Not to be misunderstood I don't believe this is 
>> your fault but I would like to know if you are experiencing the same 
>> problem.
>> Best regards,
>> Luka Gejak
>
>Hi Luka,
>
>I just observed I am also facing the same issue - I am not able to see the 
>patch series on the mailing list, no idea why :( However I received the 
>sent patches as well as your reviewed by tags on mail but I am not sure why 
>the patch series is not visible on the mailing list.
>
>Shall I resend the patch series?
>
>Best Reagrds,
>Prithvi

Not necessarily, that is probably caused by mailing list lagging 
behind, so let's just wait and see(it should stop lagging in some 
time). Patches as well as reviews should appear then. Also, did you 
receive two emails per patch from me or one because my email client is
saying two.
Best regards,
Luka Gejak

Re: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Greg KH]

On Thu, Apr 09, 2026 at 08:20:45PM +0530, Prithvi wrote:
> On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote:
> > On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> > > This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
> > > majorly focusing on fixing checkpatch warnings of constant being on right
> > > side of test in comparisons, deletion of empty if block ,use of
> > > read_poll_timeout_atomic(), and other code simplifications.
> > >
> > > Changes since v3:
> > > - Rebased the patches on top of staging-next
> > > - Remove compilation output from cover letter
> > > - Add changes in each patch version in cover letter
> > >
> > > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
> > 
> > ...
> > 
> > Hi Prithvi,
> > this seems better, but I have one question. Did patch series appear on 
> > mailing list to you, because I cant find it and my emails sent today 
> > don't appear either. Not to be misunderstood I don't believe this is 
> > your fault but I would like to know if you are experiencing the same 
> > problem.
> > Best regards,
> > Luka Gejak
> 
> Hi Luka,
> 
> I just observed I am also facing the same issue - I am not able to see the 
> patch series on the mailing list, no idea why :( However I received the 
> sent patches as well as your reviewed by tags on mail but I am not sure why 
> the patch series is not visible on the mailing list.
> 
> Shall I resend the patch series?

No, please wait, lore.kernel.org is currently having some problems.

But next time, trim your "who do I cc:" list, as it is _way_ too big,
how did you generate it?

thanks,

greg k-h

Re: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Prithvi]

On Thu, Apr 09, 2026 at 04:57:20PM +0200, Luka Gejak wrote:
> On April 9, 2026 4:50:45 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote:
> >On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote:
> >> On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> >> > This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
> >> > majorly focusing on fixing checkpatch warnings of constant being on right
> >> > side of test in comparisons, deletion of empty if block ,use of
> >> > read_poll_timeout_atomic(), and other code simplifications.
> >> >
> >> > Changes since v3:
> >> > - Rebased the patches on top of staging-next
> >> > - Remove compilation output from cover letter
> >> > - Add changes in each patch version in cover letter
> >> >
> >> > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
> >> 
> >> ...
> >> 
> >> Hi Prithvi,
> >> this seems better, but I have one question. Did patch series appear on 
> >> mailing list to you, because I cant find it and my emails sent today 
> >> don't appear either. Not to be misunderstood I don't believe this is 
> >> your fault but I would like to know if you are experiencing the same 
> >> problem.
> >> Best regards,
> >> Luka Gejak
> >
> >Hi Luka,
> >
> >I just observed I am also facing the same issue - I am not able to see the 
> >patch series on the mailing list, no idea why :( However I received the 
> >sent patches as well as your reviewed by tags on mail but I am not sure why 
> >the patch series is not visible on the mailing list.
> >
> >Shall I resend the patch series?
> >
> >Best Reagrds,
> >Prithvi
> 
> Not necessarily, that is probably caused by mailing list lagging 
> behind, so let's just wait and see(it should stop lagging in some 
> time). Patches as well as reviews should appear then. Also, did you 

Okay...thanks

> receive two emails per patch from me or one because my email client is
> saying two.

I received just one email per patch from you

> Best regards,
> Luka Gejak

Best Reagrds,
Prithvi

Re: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Luka Gejak]

On April 9, 2026 5:30:10 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote:
>On Thu, Apr 09, 2026 at 04:57:20PM +0200, Luka Gejak wrote:
>> On April 9, 2026 4:50:45 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote:
>> >On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote:
>> >> On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
>> >> > This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
>> >> > majorly focusing on fixing checkpatch warnings of constant being on right
>> >> > side of test in comparisons, deletion of empty if block ,use of
>> >> > read_poll_timeout_atomic(), and other code simplifications.
>> >> >
>> >> > Changes since v3:
>> >> > - Rebased the patches on top of staging-next
>> >> > - Remove compilation output from cover letter
>> >> > - Add changes in each patch version in cover letter
>> >> >
>> >> > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
>> >> 
>> >> ...
>> >> 
>> >> Hi Prithvi,
>> >> this seems better, but I have one question. Did patch series appear on 
>> >> mailing list to you, because I cant find it and my emails sent today 
>> >> don't appear either. Not to be misunderstood I don't believe this is 
>> >> your fault but I would like to know if you are experiencing the same 
>> >> problem.
>> >> Best regards,
>> >> Luka Gejak
>> >
>> >Hi Luka,
>> >
>> >I just observed I am also facing the same issue - I am not able to see the 
>> >patch series on the mailing list, no idea why :( However I received the 
>> >sent patches as well as your reviewed by tags on mail but I am not sure why 
>> >the patch series is not visible on the mailing list.
>> >
>> >Shall I resend the patch series?
>> >
>> >Best Reagrds,
>> >Prithvi
>> 
>> Not necessarily, that is probably caused by mailing list lagging 
>> behind, so let's just wait and see(it should stop lagging in some 
>> time). Patches as well as reviews should appear then. Also, did you 
>
>Okay...thanks
>
You are always welcome.
>> receive two emails per patch from me or one because my email client is
>> saying two.
>
>I received just one email per patch from you
>
Thanks for the info, I guess my email client is messing with me for 
this patch series(idk why).
>> Best regards,
>> Luka Gejak
>
>Best Reagrds,
>Prithvi

Re: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Prithvi]

On Thu, Apr 09, 2026 at 05:02:16PM +0200, Greg KH wrote:
> On Thu, Apr 09, 2026 at 08:20:45PM +0530, Prithvi wrote:
> > On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote:
> > > On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
> > > > This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
> > > > majorly focusing on fixing checkpatch warnings of constant being on right
> > > > side of test in comparisons, deletion of empty if block ,use of
> > > > read_poll_timeout_atomic(), and other code simplifications.
> > > >
> > > > Changes since v3:
> > > > - Rebased the patches on top of staging-next
> > > > - Remove compilation output from cover letter
> > > > - Add changes in each patch version in cover letter
> > > >
> > > > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
> > > 
> > > ...
> > > 
> > > Hi Prithvi,
> > > this seems better, but I have one question. Did patch series appear on 
> > > mailing list to you, because I cant find it and my emails sent today 
> > > don't appear either. Not to be misunderstood I don't believe this is 
> > > your fault but I would like to know if you are experiencing the same 
> > > problem.
> > > Best regards,
> > > Luka Gejak
> > 
> > Hi Luka,
> > 
> > I just observed I am also facing the same issue - I am not able to see the 
> > patch series on the mailing list, no idea why :( However I received the 
> > sent patches as well as your reviewed by tags on mail but I am not sure why 
> > the patch series is not visible on the mailing list.
> > 
> > Shall I resend the patch series?
> 
> No, please wait, lore.kernel.org is currently having some problems.
> 
> But next time, trim your "who do I cc:" list, as it is _way_ too big,
> how did you generate it?
> 
> thanks,
> 
> greg k-h

Understood...here I used all the email addresses generated from the 
get_maintainer.pl script. Next time, I'll be sure to trim it down just to 
maintainers and reviewers.

Thanks,
Prithvi

Re: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Luka Gejak]

On April 9, 2026 5:32:33 PM GMT+02:00, Luka Gejak <luka.gejak@linux.dev> wrote:
>On April 9, 2026 5:30:10 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote:
>>On Thu, Apr 09, 2026 at 04:57:20PM +0200, Luka Gejak wrote:
>>> On April 9, 2026 4:50:45 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote:
>>> >On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote:
>>> >> On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
>>> >> > This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
>>> >> > majorly focusing on fixing checkpatch warnings of constant being on right
>>> >> > side of test in comparisons, deletion of empty if block ,use of
>>> >> > read_poll_timeout_atomic(), and other code simplifications.
>>> >> >
>>> >> > Changes since v3:
>>> >> > - Rebased the patches on top of staging-next
>>> >> > - Remove compilation output from cover letter
>>> >> > - Add changes in each patch version in cover letter
>>> >> >
>>> >> > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
>>> >> 
>>> >> ...
>>> >> 
>>> >> Hi Prithvi,
>>> >> this seems better, but I have one question. Did patch series appear on 
>>> >> mailing list to you, because I cant find it and my emails sent today 
>>> >> don't appear either. Not to be misunderstood I don't believe this is 
>>> >> your fault but I would like to know if you are experiencing the same 
>>> >> problem.
>>> >> Best regards,
>>> >> Luka Gejak
>>> >
>>> >Hi Luka,
>>> >
>>> >I just observed I am also facing the same issue - I am not able to see the 
>>> >patch series on the mailing list, no idea why :( However I received the 
>>> >sent patches as well as your reviewed by tags on mail but I am not sure why 
>>> >the patch series is not visible on the mailing list.
>>> >
>>> >Shall I resend the patch series?
>>> >
>>> >Best Reagrds,
>>> >Prithvi
>>> 
>>> Not necessarily, that is probably caused by mailing list lagging 
>>> behind, so let's just wait and see(it should stop lagging in some 
>>> time). Patches as well as reviews should appear then. Also, did you 
>>
>>Okay...thanks
>>
>You are always welcome.
>>> receive two emails per patch from me or one because my email client is
>>> saying two.
>>
>>I received just one email per patch from you
>>
>Thanks for the info, I guess my email client is messing with me for 
>this patch series(idk why).
>>> Best regards,
>>> Luka Gejak
>>
>>Best Reagrds,
>>Prithvi
>

I want to add that as the mailing list is slowly getting uncluttered, 
the patch series appeared, and it applies cleanly on top of the 
staging-next.
Best regards,
Luka Gejak

Re: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Luka Gejak]

On April 9, 2026 5:39:58 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote:
>On Thu, Apr 09, 2026 at 05:02:16PM +0200, Greg KH wrote:
>> On Thu, Apr 09, 2026 at 08:20:45PM +0530, Prithvi wrote:
>> > On Thu, Apr 09, 2026 at 04:18:28PM +0200, Luka Gejak wrote:
>> > > On Thu Apr 9, 2026 at 3:50 PM CEST, Prithvi Tambewagh wrote:
>> > > > This patch series focuses on code cleanup in drivers/staging/rtl8723bs,
>> > > > majorly focusing on fixing checkpatch warnings of constant being on right
>> > > > side of test in comparisons, deletion of empty if block ,use of
>> > > > read_poll_timeout_atomic(), and other code simplifications.
>> > > >
>> > > > Changes since v3:
>> > > > - Rebased the patches on top of staging-next
>> > > > - Remove compilation output from cover letter
>> > > > - Add changes in each patch version in cover letter
>> > > >
>> > > > v3 link: https://lore.kernel.org/linux-staging/1D11A73B-4869-47DB-B8F5-FB3F0D7FF932@linux.dev/T/#m3190af744bc1e1f151e9e8503c7d20951fe27534
>> > > 
>> > > ...
>> > > 
>> > > Hi Prithvi,
>> > > this seems better, but I have one question. Did patch series appear on 
>> > > mailing list to you, because I cant find it and my emails sent today 
>> > > don't appear either. Not to be misunderstood I don't believe this is 
>> > > your fault but I would like to know if you are experiencing the same 
>> > > problem.
>> > > Best regards,
>> > > Luka Gejak
>> > 
>> > Hi Luka,
>> > 
>> > I just observed I am also facing the same issue - I am not able to see the 
>> > patch series on the mailing list, no idea why :( However I received the 
>> > sent patches as well as your reviewed by tags on mail but I am not sure why 
>> > the patch series is not visible on the mailing list.
>> > 
>> > Shall I resend the patch series?
>> 
>> No, please wait, lore.kernel.org is currently having some problems.
>> 
>> But next time, trim your "who do I cc:" list, as it is _way_ too big,
>> how did you generate it?
>> 
>> thanks,
>> 
>> greg k-h
>
>Understood...here I used all the email addresses generated from the 
>get_maintainer.pl script. Next time, I'll be sure to trim it down just to 
>maintainers and reviewers.
>
>Thanks,
>Prithvi

Upon testing myself, get_maintainer.pl doesn't list all of those 
people when ran on a directory or a file in staging.
Best regards,
Luka Gejak

Re: [PATCH v4 0/5] staging: rtl8723bs: Code cleanup in drivers/staging/rtl8723bs

[Andy Shevchenko]

On Thu, Apr 09, 2026 at 05:44:24PM +0200, Luka Gejak wrote:
> On April 9, 2026 5:39:58 PM GMT+02:00, Prithvi <activprithvi@gmail.com> wrote:
> >On Thu, Apr 09, 2026 at 05:02:16PM +0200, Greg KH wrote:
> >> On Thu, Apr 09, 2026 at 08:20:45PM +0530, Prithvi wrote:

...

> >> But next time, trim your "who do I cc:" list, as it is _way_ too big,
> >> how did you generate it?
> >
> >Understood...here I used all the email addresses generated from the 
> >get_maintainer.pl script. Next time, I'll be sure to trim it down just to 
> >maintainers and reviewers.
> 
> Upon testing myself, get_maintainer.pl doesn't list all of those 
> people when ran on a directory or a file in staging.

Also you may check my script [1] that I use on everyday basis to send patches
to Linux kernel. It has some heuristics that showed to be almost suitable.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

-- 
With Best Regards,
Andy Shevchenko