From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBD053D3CE5 for ; Thu, 9 Apr 2026 13:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742700; cv=none; b=iNtiNgsPrX7jaP82IHhnyujxv8f6XeL46uxmbxVxweL4xYfKFMi4lk7KWf4hGLtmnHr9wRr6klxC68ljIu+YXQnj04CjTXc05YMsyIiqjphSVuEhNHNxhgwJg3JNAO0REhfj3rnByY8+YcqVqcQ3OzxBwDpjMiXQ/ru9NzvWY8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775742700; c=relaxed/simple; bh=b9XVrchuap9fqBpVQL3AJRB7as8Aiw+odeeQjTqQVaU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sEZ5f+jlngFRFE8wR5QtRIKFOFC2yceYagYgOsSzMtbDWbpO2KOtxRdL0MxENcNMjuzCO2VHuQ5JRKKyMF0b/KjFYzvHRaPvR22Ed6Kr0cNJx7muOtVst9ZrT8A2z1eRowC5TCki+pjM6Z7p3EYUhBMCpwF94Qs/qK4VSNmoKI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DbbBwBV3; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DbbBwBV3" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2b0afa0210bso4170235ad.2 for ; Thu, 09 Apr 2026 06:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775742698; x=1776347498; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MVEWLl/Od3ufIPmI59zrfVuf3ZvRBpYOxIc+qkV+R0o=; b=DbbBwBV3/TPydc5/yc3clUvAHUPHAFMIyQGRDZeXNjavgkNMT1ox0URU/Do5z80mnr KsYYMVFKrT2H65wiM9cHR0VxVlFQI53Umds3bskhN9sk0oBP4BIw99vVxfTvKEof9lQz 4oDQ+nbFSyM5J9QShpuosb3+r/zjC/wYgODwHzw+5OFxprkUExc4Ux9DoQ5+fEneB+yu u5HS7RGYb2aP+9XKySzBJSBWZr3qSb1NoLHdcQZMVNn3hPpSJ1xmlods42xK3mg7n6ik o4bSajZ7734EK+uCuzpy8g/k6Gx9yoCKYpqf0opOBOSOBtxuB2QjPMuze8ABj1oS9duo XDJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775742698; x=1776347498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MVEWLl/Od3ufIPmI59zrfVuf3ZvRBpYOxIc+qkV+R0o=; b=B6h3rKJH1rhDnHYyXEteJLRTVPu4D4H+jkEfM0XLp3aCEQTq8GxVES+rCvkeWlY52i wLAoDaJ0v42PEgNx+kKRCBuRXfhRjJsULqjtIzAsj5zQAOrweRJ3jFOIMirTtToMLxUk P8S0kwz4feec/H12qxemIcrLZmpE65tz89rOT4466EMVkBW/Y3W3Qk2T5jiwo0iqO1fK uqTx217ejDB4QJdBCHxqjB/Eio1yNmCUwY59j6+vwSoYdEVjWtPS/ZAdbZd6syXv0wCS vqw2FH+lONI4PTDGTFGGwhcyKutGKnAgxls4TkCJ+GWWs+iXjh7TXJBV+KoCU0MUZp9f 5j2A== X-Forwarded-Encrypted: i=1; AJvYcCUfkmntDEmjgWuyCEqkr1XkhIg83rTmyRJ8kTVG8FwbgF9tzbRMm81qTRSTk3SKS29ADc0N2dNAUUowXuA=@vger.kernel.org X-Gm-Message-State: AOJu0YydZW9RfmsS00OXmK0bVsvfT5HN3LJgsAAQpUBX5/MYNVGnKO03 pEXJAF0egHQQrh3AJfUNt4HWctUFJhUtAQ5qG1K4qesVgmsL4a+46Hp5 X-Gm-Gg: AeBDietJN3oH4x679wUlgQ65LHpVtvNch0dfSc305r0nhdQwOKz8ScM+YAl4o3ObDQU 8FA09D1aNHUps9lKoaEAzwEyIy4jhX/x89UeMasEF30T56MHNlx3c6QIY7sbIGQc79llIZLq/+U VdF+o/SSkOqUI+LGIAYs3io8IyDtllDcQvx77lAb/yIa211oBe5iwLrSdqoJR+9NiZcLLw8qkkr PcFkCen5FppzVVSM/NoTK9OeHJVQGu/06HFcKRAEyj7oSzwWpMW+/QrcFhVYMW5YotAPkvJMApD BCP3d53t49tBec7DB8V+EZEkRtFBviF58Sg65yBvGx6NtB9K+RAqRH4NJRlWoEEXTtOyQnW7NdN B0iBSllfN0e1iKXNp+ApBSgE/cmoGHRG31jboY47NAjVv3v+cS5tXn973nIZ2MZfzS2aW8S6r6u bGEOLxrPrVbyUeh1jcahwvPWQWEwTSLIXl+qkAjwtC X-Received: by 2002:a17:902:ccc7:b0:2ae:c5fc:b2ef with SMTP id d9443c01a7336-2b2818b3b4amr288059425ad.30.1775742698107; Thu, 09 Apr 2026 06:51:38 -0700 (PDT) Received: from localhost.localdomain ([111.125.237.246]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27478945asm315288855ad.28.2026.04.09.06.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 06:51:37 -0700 (PDT) From: Prithvi Tambewagh To: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, b9788213@gmail.com, straube.linux@gmail.com, tmimiharoen@gmail.com, filippo.muschera@gmail.com, ethantidmore06@gmail.com, andriy.shevchenko@linux.intel.com, rayfraytech@gmail.com, david@cardinalsystem.net, weibu@redadmin.org, dharanitharan725@gmail.com, ignacio.pena87@gmail.com, dan.carpenter@linaro.org, karanja99erick@gmail.com, luka.gejak@linux.dev, khushalchitturi@gmail.com, suunj1331@gmail.com, s9430939@naver.com, nikolayof23@gmail.com, bryant.boatright@proton.me, ysinghcin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Prithvi Tambewagh Subject: [PATCH v4 4/5] staging: rtl8723bs: use read_poll_timeout_atomic in _is_fw_read_cmd_down Date: Thu, 9 Apr 2026 19:20:25 +0530 Message-Id: <20260409135026.137904-5-activprithvi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260409135026.137904-1-activprithvi@gmail.com> References: <20260409135026.137904-1-activprithvi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the existing rtw_read8() and do-while loop mechanism with read_poll_timeout_atomic() from , in _is_fw_read_cmd_down() which is a standard Linux macro, ensuring polling REG_HMETFR efficiently. Signed-off-by: Prithvi Tambewagh --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c index 12416e499ac3..4bdc8e314015 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -8,6 +8,7 @@ #include #include #include +#include #include "hal_com_h2c.h" #define MAX_H2C_BOX_NUMS 4 @@ -18,20 +19,15 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num) { - u8 read_down = false; - int retry_cnts = 100; - u8 valid; + int ret; - do { - valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num); - if (0 == valid) { - read_down = true; - } - } while ((!read_down) && (retry_cnts--)); - - return read_down; + ret = read_poll_timeout_atomic(rtw_read8, + valid, !(valid & BIT(msgbox_num)), + 0, 500, false, + padapter, REG_HMETFR); + return !ret; } -- 2.34.1