From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 704E63321AA for ; Thu, 9 Apr 2026 15:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775749626; cv=none; b=dCXdGkvK4kGcv6aG5SePXwkazvXThb+lpc6J2yqPlXXgUA4h65OLW1bpZVe8Dl/WYkTWYQRJ5KB7ssHGhzFz1yDu35DDn0SEA1OQSrdfD/jK7LJBrMOFftv2GYJmE2Hn+K2bn6+kYYSbZbfasIgzLmP4xBmtNzm7K6gQv2js0fU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775749626; c=relaxed/simple; bh=ltl8tl7LY9Yc/LcZI9NUoPzqx2MsoXnzCioP2vkGbtQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XhxWS3QXqd9deagxoXVaqd7FcR+yu3IpAe+HiNOm025AW9oloXkQRWsWl5a0Tm0/wBmAh2TKhDTs/7HbTAwmHKh/H5cCyylWIh0y3rvlslLWKsG1AammdDrIropzQqIRyqZm8MKTJLd5IW7Ui+3iGziZewIvQfOW6XNbxavVFHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U2hU6F7x; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U2hU6F7x" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488971db0fdso10623905e9.0 for ; Thu, 09 Apr 2026 08:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775749620; x=1776354420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MEV02bcyH2Pdvd6Qd6GHWOafkuvPxsNvzJnUHt7jdc0=; b=U2hU6F7xrGf1BDgipo1KriCq4y6rc1AvyZNoNByCS+5ECFYnXHVvqsFROCKe9wIgqp tgUku+jW4rV/N43+mbn3UJSyaJEV/PhJ9yzfFpQLKs8odvWJLJM+XcolA0N4Dci8+MBx 8tPCt4nDBBW5odlzRSQghsEJPOKIQPoBnRttKPUK7JN/YMw8jHRi3cVCLzlyGZhC0UHF Uz8UtdC6/qPAwRnU/zYsYIUwltvwx4ulGWfXvxHzUNv5iuVaUDDKyxVytYjIMT7wucKe MNwrnxBvWtOyLzKoaWMKBDl1/pHBccerLMqo2NFlN3hQVY/rgqvXMa5w5cQRXvEHJ82f lbAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775749620; x=1776354420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MEV02bcyH2Pdvd6Qd6GHWOafkuvPxsNvzJnUHt7jdc0=; b=LivdwhIVN00YNxdRRC+/BJNChYNsN+TT6ZIBHsZX+4MgP+7d29xiiMd/0Vob9P3rr1 aWz53ETZ3rnaIAmKpByVfSYbo3R4Bb0gd21gR9q0ijc2tLRtvlVMb70omXNlxqAGWp/E 8Hqxq7pnTXeo+TNZcNTO96xUMSo2YlvXRFyqg+rehfFaXEawsk3OlOpfolyDGwZE3oo5 QwTM3Oe5cTDWrisPlxYg+k4AP2Qxfi85jG9+YE7wUq2K1UHrAl9YB5WxdjJ0XNcaaqKq Ekrjk7KJ383H1TnIgfjc0c2FlEhK8umoqHAyHCOkcjDnK6z7tComWt6S02FYrydhYf+Y YWWQ== X-Forwarded-Encrypted: i=1; AJvYcCU8u7vZzpJjaiYSLsQKKwvgB/vEXhe//kzZkLpPlSAsiYNULocGmyW6yiyQUgJjs6QIovL0kuGf9a74u0U=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3Trz+3DeERDwEu+huGNJN72ASAOVnzXs3AZUDUuwKEOMK2foW 1zVDZxDdsis1HZchdFytTKr812EH+OaaIJr8Ee8AH7e/FyKu298PN23k X-Gm-Gg: AeBDieuTTz4808uJrmWqBJpwmKRMiFn8n8PAtMLuBMfsw/ant0wGqz7N3R3GpV/4JYm YFd4JWH9hmZxwGB9APIdcojBcKgD2Tb16Ukokwwv2R5INR3G0R5bZPv0RuUQy5CF+VIiwpaPPBi zbq85PgkYbFeGiymjJ3J/LNBqgW2cKCfuZYA9FGrUb9CACV8hH1UOWtYz6ObcsxcciJEOO4ln3S lFcKWgrGJ8Gj0EW/TWY37VlXSCQ8WORbfQOjMskc94LfGf3r6OC4LTToorCE1bhMHMgTWRXwd7M /j5dCeI/f01qGE/CJNMWlzNx9JHB/UDCumaaV0ugYDwu4HCg7pTJx+vRnBOcqmKHvis35ZsK783 hWBXzrkAaQgT+fF72+xwQDEaA65QlSfJyX6XxSZfpIyJE+XzWDGJAm+N0PBGnufXmaewIzgFvx7 gfika9gcmOchF9Atg3od1fj6Dav/ci6M0NxP3Iqfc= X-Received: by 2002:a05:600c:37c7:b0:485:9a50:3384 with SMTP id 5b1f17b1804b1-488cd05a06dmr58089375e9.25.1775749619783; Thu, 09 Apr 2026 08:46:59 -0700 (PDT) Received: from hisam ([2400:adcc:119:1300:e749:40f7:4497:4ea7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488cd1d171dsm41612405e9.5.2026.04.09.08.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 08:46:59 -0700 (PDT) From: Hisam Mehboob To: Sean Christopherson , Shuah Khan Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Aqib Faruqui , shuah@kernel.org, pbonzini@redhat.com, Hisam Mehboob Subject: [PATCH v2] KVM: selftests: Guard execinfo.h inclusion for non-glibc builds Date: Thu, 9 Apr 2026 20:38:47 +0500 Message-ID: <20260409153846.1502656-2-hisamshar@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260319000842.1213426-2-hisamshar@gmail.com> References: <20260319000842.1213426-2-hisamshar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The backtrace() function and execinfo.h are GNU extensions available in glibc but not in non-glibc C libraries such as musl. Building KVM selftests with musl-gcc fails with: lib/assert.c:9:10: fatal error: execinfo.h: No such file or directory Fix this by guarding the inclusion of execinfo.h and the stack dumping logic under #ifdef __GLIBC__. For non-glibc builds, provide a local stub for test_dump_stack(). Suggested-by: Aqib Faruqui Suggested-by: Sean Christopherson Signed-off-by: Hisam Mehboob --- Changes in v2: - Replaced the __weak stub approach with a single #ifdef __GLIBC__ and a local stub inside assert.c as suggested by Sean Christopherson. tools/testing/selftests/kvm/lib/assert.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/lib/assert.c b/tools/testing/selftests/kvm/lib/assert.c index b49690658c60..8be0d09ecf0f 100644 --- a/tools/testing/selftests/kvm/lib/assert.c +++ b/tools/testing/selftests/kvm/lib/assert.c @@ -6,11 +6,14 @@ */ #include "test_util.h" -#include + #include #include "kselftest.h" +#ifdef __GLIBC__ +#include + /* Dumps the current stack trace to stderr. */ static void __attribute__((noinline)) test_dump_stack(void); static void test_dump_stack(void) @@ -57,6 +60,9 @@ static void test_dump_stack(void) system(cmd); #pragma GCC diagnostic pop } +#else +static void test_dump_stack(void) {} +#endif static pid_t _gettid(void) { -- 2.51.0