From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CBE32EBB89 for ; Thu, 9 Apr 2026 18:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775759396; cv=none; b=Sb0zgksqzj7U352f+KEoyXzPMaRAyTIMGIXT/+BVCrJ6cQxeXDoOlJvd0gUnBjH7wyQEQIULuB4Giph2DKwycSwHGE9YdxodaDv+BLdC1XxDp/TZQXAidlvpm3M548jlly2d6jGJKd7Wncqec73Udn9eNFLJQVYDVjITfe8ZJz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775759396; c=relaxed/simple; bh=ODMC7InBF06GWssENCFF35L7QXBK/pKM+fNN466Ya8k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Flvvk9/KtNSiRZenqguFoqpAzFzOOEFzisLO2JRfQH4LTA4ujuXbd4LX78N22sPs1CaWgxHWrPwyPrf7kXNlhF3/7HVArO+OB5O50kl4DLFTDPaD1JYe804z0PX9lRrGRVbKh+hhTpKqUNGE80a+xebtSx6ydOGpGIWhccI+wvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=ALSXN4mT; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="ALSXN4mT" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-50babbce85fso12982361cf.2 for ; Thu, 09 Apr 2026 11:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1775759392; x=1776364192; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VPyWPfO2ahQ7vvuDxRFUZN9wGMKQdVim3FCtdZSzgeM=; b=ALSXN4mT/AM1Hbu/Ejp+oSBdD4pCQEHtury/9cJzy5ugho7HwvAHZv0gpL8mlowAJk iIbexFFmuDYOSDE6zAF6k/q7vuTXa9EXbLdqyNa5JHlrlmrfYRez/2dHVeA213mwsoJU T4pouXPIBVzxfwnDwdU56DJOyt97RYWhKK/mccwaU/N0jPgkULiJlpYLK42VTuZSMRXI tBTGBFxOdeDHulYDjReohqW/MegGL2DHnND29jsLQWMzO2IdCmT7hSxbdJv0hwWqG28W XUbYWzEOe7B12hWzVgIKfqZl1V2A6k+8YMNVXDO5izUCM1wJkh/zgVeT+1AjxpZWykg8 pe6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775759392; x=1776364192; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VPyWPfO2ahQ7vvuDxRFUZN9wGMKQdVim3FCtdZSzgeM=; b=T6nY1oMkicIdyVYf4TM/QUun/5fmUakaepusvRJKKtKT690WqCpaIrwqW7lOHMADOd L+SCGbRQvXpygGGy+DUbfl8EKi/bxfmSxpZYt5ef4+C7yYi+Lk/gafbZtb7ABKOB6sGS nn9EOnWjtgVawP2ceGWJ/1OdhDMwgM0Tl3RNd2BdLuNbOLx5MKOVFMFOCuIPFChHpwU3 4De5KBq2LsgBm9Lu4b7iDDhO7FixKgU2CIdh4hoCqa8Sjb4zZBrzmAGaMlnzc2ENGWP8 2Sg9MWvhND66VPGXihJkGNk0HtvNyZzY26Z7FDoZIWjs+tp0LqbvtWF5Vn+weV2brTAn p1RQ== X-Forwarded-Encrypted: i=1; AJvYcCUW9tcJD5HiendpCJbyV5+IRI/gTgcaK0KmzVmkpoBMe0DChX8hIivkLchbjWMP2s3LdlCWLTdlEVnhNU4=@vger.kernel.org X-Gm-Message-State: AOJu0YyTGmAPMciMv/lqxgk4wpICubztf/MNaH4RzGzdweqUqK98QCqW tks5dYpVx7LoqiKqdhQpZ3tdEqy8q3ZTEGJFAwBq5sJlAMHEKYmcm3VG/4zwrLbYBjk= X-Gm-Gg: AeBDiesUDw6wLxaJrwM/2jymDooxsQtWJC+WmpXhxTCrIn9XoeM9B1W647jH4/0+bPj aUvYCgRJw0coQD/QKterIZbC/IHbJzr8Ywj0NbVBXj/OLxF9hl0OIrqIxWpq+JDTwnIh67MEAJz 2RXwHokkfs6uABF6JLUKdIFfmI6bLbYP0TsyWWYj/OR8SoyZetz54B3vhrFyMlAnuTju1usx/a9 oQQJzmJHmpqU3CMU1N2HY50plpc4ixPQsacCOtv7jdWOSf5zrJPK4le8JuT8CQQqSVgFzEpzNW+ yJd5IDxmtcAtAhuy/aw5SEFswXgGesWjOCb/hRCkvi/A614gFt6SxW4/Dq8j01H4AeIMFSyEDoM zoCsHo6s3v63ljq5Az8vm/kqL39LpO0HnnsWMqXW9k/imHCxTpenPxkUxdkOkE/qzB6r3K0bJpp aTnHEGam+/mSG2i/oTD46MSfTOoqLfve70jb9xa9E9HyUeXpQsKSbpzSiAsqdvLxIh5bSfFA== X-Received: by 2002:ac8:5855:0:b0:50b:a9d3:2e20 with SMTP id d75a77b69052e-50dd5c5de8fmr4147251cf.49.1775759392454; Thu, 09 Apr 2026 11:29:52 -0700 (PDT) Received: from ziepe.ca (mctnnbsa70w-159-2-73-22.dhcp-dynamic.fibreop.nb.bellaliant.net. [159.2.73.22]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50dd53e1f45sm2885961cf.8.2026.04.09.11.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 11:29:51 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wAu8V-00000009EkY-1bgt; Thu, 09 Apr 2026 15:29:51 -0300 Date: Thu, 9 Apr 2026 15:29:51 -0300 From: Jason Gunthorpe To: Konstantin Khorenko Cc: Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , Peter Oberparleiter , Mikhail Zaslonko , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Pavel Tikhomirov , Vasileios Almpanis Subject: Re: [PATCH v2] iommu/generic_pt: use __always_inline for amdv1pt_install_leaf_entry() Message-ID: <20260409182951.GS2551565@ziepe.ca> References: <20260402141012.1437095-1-khorenko@virtuozzo.com> <20260409170117.2014479-1-khorenko@virtuozzo.com> <20260409170117.2014479-2-khorenko@virtuozzo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409170117.2014479-2-khorenko@virtuozzo.com> On Thu, Apr 09, 2026 at 08:01:17PM +0300, Konstantin Khorenko wrote: > With -fprofile-update=atomic in CFLAGS_GCOV, GCC fails to eliminate > an impossible branch in FIELD_PREP() inside amdv1pt_install_leaf_entry() > when the function is merely "static inline". GCC may choose not to > inline it, and without seeing the constant arguments at the call site > it cannot prove the FIELD_PREP value fits the field. > > Change from "static inline" to "static __always_inline" so GCC is > forced to inline the function and can see the constant values, > allowing dead code elimination of the impossible branch. > > Signed-off-by: Konstantin Khorenko > --- > drivers/iommu/generic_pt/fmt/amdv1.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) It was already merged: commit 8b72aa5704c77380742346d4ac755b074b7f9eaa Author: Sherry Yang Date: Thu Mar 26 09:17:19 2026 -0700 iommupt/amdv1: mark amdv1pt_install_leaf_entry as __always_inline After enabling CONFIG_GCOV_KERNEL and CONFIG_GCOV_PROFILE_ALL, following build failure is observed under GCC 14.2.1: