From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2590F2D6E58 for ; Thu, 9 Apr 2026 18:40:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775760020; cv=none; b=J23qJblwMXpN6BfCjFkGwKKMtesez1kSt8iPapFSwEEvH+6/R/+OD/DAIzgiSrfODWFRH/mpK2miDeumuBc6kHZQKkukwZS6GCRug1hL6klLjTTzWgHJbw3OD1sPIrIxxLXzHgkMCpSe3pNz/TjfXo2LXbtr2L2/dshFHZoIRE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775760020; c=relaxed/simple; bh=thQzeiykELo/fwsdgBZVW/jDFIHzD6ZTl+5yJsqQizE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WPwHEWBU8epDDy2Rc9ts2/0yZwkmlhXnUoRs9lRwAXFYWiFUuJP9xhqo4Pf5xxmMIQDV2R3wb5Up/0C7+jN2n0JyGIlKehkU/saOiIBA+/KzHAKZmLOuZ5bekRfbP3Rgm5I3er5BVQJaO5OnD96fJDLivZUndkohDpOf2BP6F4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HJ05Ean1; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HJ05Ean1" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43cf8fe9c2aso806610f8f.2 for ; Thu, 09 Apr 2026 11:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775760017; x=1776364817; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Pbe/Y5t71TqJtBY58+ahinO1W1322QS2uIOhop9klfQ=; b=HJ05Ean1kY0Zjm/WXUgOYgXd/f9sIjlOa28uTsSZjuXP136eD0KWwQUtrnRLZvn+0U 959U8YqAkr4z43xYjb1i7SSpsYJ+Fqd0LFFACi0CKf2wYsEgBbPCXLMIHGfYe/WiK0a5 TBzeGVQxhg695NvYdLuU6zaqXO59cF5alIgNajiIJYLX42Won6jRBkL+wjVQk+1iYIQ2 IOtg011gmERCQWphmuuCXELp4gkIuJNKl6ZImFMEWekcXFliePOPZ2cBrXAj7saunJiZ Z1V+zvJA4LZPwk49kAOGKSt1i46TczdW1nWzbVjEGDAq122BTRZshCxOPhy9Z0R53USt +z/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775760017; x=1776364817; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pbe/Y5t71TqJtBY58+ahinO1W1322QS2uIOhop9klfQ=; b=h9RZdzJ8udzH7mNg9cGG0z1kaT0oQOuDZuXEEe+myXfgNYMMxLWZjjuEYHIz+UaUAY 9nekKHWl9Y79UJp5Je+ZqNOilxKNFPmiWHN0Wp5KxdrLeRqIDmoenIBg9pO1p8agMedq KwfEZIYQmjHygP4MaKxgN2rikG3kOVdXgQJyfvwlA7uOViXn55JTK6rEwbvV0vQCIa5D 675d9e9JJu2SKOyQWGkRjmuGIuH6xTPhm9vcJgi5Y5A6RzGciGee5Z5f0jorLERbTeSa 5y9eAvkX6DERZwGw9yBYNIwulnorDF3dzPLPKL6nXIk1ijOywDhQjV3a65lqLalge/nm GgOQ== X-Forwarded-Encrypted: i=1; AJvYcCXXKi+3Spw3zTX61oAtDgbfDTxdpbdDX3oWqn7Kx4whu2N8mkenOodn9gUss+9wGrfWovnhMA0Ccz/AfKI=@vger.kernel.org X-Gm-Message-State: AOJu0YzXEzHVJTYFkeIRhULJordeS95Qt+vKKy2QwUqB9ncztW2LQkXX SFZQpMI++DwP1OwCvOBK+rUrdDTH9klAY0c/nV4il9pEhm9S5bGtCpoy X-Gm-Gg: AeBDietjDbnNr9nPQwyCJz7HZkdi+E4HK41OCiyUTgg5JzApi8jhetS1IIjx12ztBVy e7xusP92tY+/9ppYcnqX5Xgvi5CH1qC8Egy2bQtZCIleS6UFOkuLebTpFXV3KOoG4FF4nLc/e/8 5haA9YKG5gPmtIoJWiUHjvioM1/U/c0NCArfJf5RvQft5Fza2JhSMjsEJnFpdyFYlvs6wJoAblk xZI3ElvEEI+AsE9wZkxJWwZHrVKw9m+eh+k2zn8tVewTMFvKMpeVt/CvM+XKpyuRTeQmWcFTPlI S/XEMn4FUKWTupGWIbf3rrm4uy6e7t7kHkT73eI3TG9s4uxhAZzHG7UiiSrAh+lR/OQP+YPxqIj 9DtPHI98HBeYEHp9argLpr+FifOnvUunE0T2ZzPfoBSFB4f79Z8LTn6/Q9gMzEgHRt1ZzbY7mfr viP19/16iG2v9tRzax6/JKI7rryhKjG5Cf8z9pKUKdo0hyd54NjLENAf8hFg0QeSSJl7rfCJMyW 4YOWdNzJb50 X-Received: by 2002:a5d:64e6:0:b0:43b:3d54:3154 with SMTP id ffacd0b85a97d-43d64254b01mr278430f8f.7.1775760017303; Thu, 09 Apr 2026 11:40:17 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e5d88bsm560563f8f.37.2026.04.09.11.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 11:40:16 -0700 (PDT) From: David Carlier To: netdev@vger.kernel.org Cc: vburru@marvell.com, sedara@marvell.com, srasheed@marvell.com, sburla@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Carlier Subject: [PATCH net v2 0/2] octeon_ep_vf: fix napi_build_skb() NULL dereference Date: Thu, 9 Apr 2026 19:40:07 +0100 Message-ID: <20260409184009.930359-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit napi_build_skb() can return NULL on allocation failure. In __octep_vf_oq_process_rx(), the result is used directly without a NULL check in both the single-buffer and multi-fragment paths, leading to a NULL pointer dereference. Patch 1 introduces a helper to deduplicate the ring index advance pattern, patch 2 adds the actual NULL checks. --- v1 -> v2: split into refactor + fix per Simon Horman review. v1: https://lore.kernel.org/netdev/Z-6w5kfCJoGhb30g@framework/ David Carlier (2): octeon_ep_vf: introduce octep_vf_oq_next_idx() helper octeon_ep_vf: add NULL check for napi_build_skb() .../marvell/octeon_ep_vf/octep_vf_rx.c | 47 ++++++++++++++----- 1 file changed, 36 insertions(+), 11 deletions(-) -- 2.53.0