From: Jason Gunthorpe <jgg@nvidia.com>
To: Jacob Pan <jacob.pan@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
Alex Williamson <alex@shazbot.org>,
Joerg Roedel <joro@8bytes.org>,
Mostafa Saleh <smostafa@google.com>,
David Matlack <dmatlack@google.com>,
Robin Murphy <robin.murphy@arm.com>,
Nicolin Chen <nicolinc@nvidia.com>,
"Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>,
skhawaja@google.com, pasha.tatashin@soleen.com,
Will Deacon <will@kernel.org>,
Baolu Lu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH V3 07/10] vfio: Enable cdev noiommu mode under iommufd
Date: Thu, 9 Apr 2026 15:48:41 -0300 [thread overview]
Message-ID: <20260409184841.GP3357077@nvidia.com> (raw)
In-Reply-To: <20260403051146.10210-8-jacob.pan@linux.microsoft.com>
On Thu, Apr 02, 2026 at 10:11:43PM -0700, Jacob Pan wrote:
> @@ -392,6 +398,16 @@ void vfio_unregister_group_dev(struct vfio_device *device)
> bool interrupted = false;
> long rc;
>
> + /*
> + * For noiommu devices without a container, thus no dummy group,
> + * simply delete and unregister to balance refcount.
> + */
> + if (device->noiommu && !vfio_device_has_group(device)) {
> + vfio_device_del(device);
> + vfio_device_put_registration(device);
> + return;
> + }
> +
Sashiko points out this can't just skip the waiting even for no-iommu
mode, it isn't linked to groups and containers but the lifecylce of
the open FD.
Maybe just stick a !group inside vfio_device_group_unregister() is
sufficient?
Jason
next prev parent reply other threads:[~2026-04-09 18:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 5:11 Jacob Pan
2026-04-03 5:11 ` [PATCH V3 01/10] iommufd: Support a HWPT without an iommu driver for noiommu Jacob Pan
2026-04-03 5:11 ` [PATCH V3 02/10] iommufd: Move igroup allocation to a function Jacob Pan
2026-04-03 5:11 ` [PATCH V3 03/10] iommufd: Allow binding to a noiommu device Jacob Pan
2026-04-09 17:06 ` Jason Gunthorpe
2026-04-03 5:11 ` [PATCH V3 04/10] iommufd: Add an ioctl IOMMU_IOAS_GET_PA to query PA from IOVA Jacob Pan
2026-04-09 18:26 ` Jason Gunthorpe
2026-04-03 5:11 ` [PATCH V3 05/10] vfio: Allow null group for noiommu without containers Jacob Pan
2026-04-09 18:44 ` Jason Gunthorpe
2026-04-03 5:11 ` [PATCH V3 06/10] vfio: Introduce and set noiommu flag on vfio_device Jacob Pan
2026-04-03 5:11 ` [PATCH V3 07/10] vfio: Enable cdev noiommu mode under iommufd Jacob Pan
2026-04-09 18:48 ` Jason Gunthorpe [this message]
2026-04-03 5:11 ` [PATCH V3 08/10] vfio:selftest: Handle VFIO noiommu cdev Jacob Pan
2026-04-03 5:11 ` [PATCH V3 09/10] selftests/vfio: Add iommufd noiommu mode selftest for cdev Jacob Pan
2026-04-03 5:11 ` [PATCH V3 10/10] Documentation: Update VFIO NOIOMMU mode Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409184841.GP3357077@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex@shazbot.org \
--cc=baolu.lu@linux.intel.com \
--cc=dmatlack@google.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.pan@linux.microsoft.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=pasha.tatashin@soleen.com \
--cc=robin.murphy@arm.com \
--cc=skhawaja@google.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox