From: Jakub Kicinski <kuba@kernel.org>
To: Mashiro Chen <mashiro.chen@mailbox.org>
Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, linux-kernel@vger.kernel.org,
syzbot+abd2b69348e2d9b107a1@syzkaller.appspotmail.com
Subject: Re: [PATCH net v3] net: rose: defer rose_neigh cleanup to workqueue to fix UAF
Date: Thu, 9 Apr 2026 19:49:57 -0700 [thread overview]
Message-ID: <20260409194957.5465e98b@kernel.org> (raw)
In-Reply-To: <20260406170125.175258-1-mashiro.chen@mailbox.org>
On Tue, 7 Apr 2026 01:01:25 +0800 Mashiro Chen wrote:
> rose_neigh_put() frees the rose_neigh object when the reference count
> reaches zero, but does not stop the t0timer and ftimer beforehand.
> If a timer has been scheduled and fires after the object is freed,
> the callback will access already-freed memory, leading to a
> use-after-free.
What if ROSE is built as a module and gets unloaded?
Please don't post the next version until next week, we're drowning in
these AI generated patches.
--
pw-bot: cr
next prev parent reply other threads:[~2026-04-10 2:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 20:44 [PATCH net] net: rose: stop timers before freeing neighbour in rose_neigh_put Mashiro Chen
2026-04-05 12:58 ` [PATCH net v2] " Mashiro Chen
2026-04-06 17:01 ` [PATCH net v3] net: rose: defer rose_neigh cleanup to workqueue to fix UAF Mashiro Chen
2026-04-10 2:49 ` Jakub Kicinski [this message]
2026-04-10 5:08 ` Mashiro Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409194957.5465e98b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mashiro.chen@mailbox.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+abd2b69348e2d9b107a1@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox