* [PATCH v2] staging: rtl8723bs: fix comparison to false
@ 2026-04-09 22:11 Akhil Boyapati
2026-04-10 6:45 ` Luka Gejak
0 siblings, 1 reply; 2+ messages in thread
From: Akhil Boyapati @ 2026-04-09 22:11 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel; +Cc: Akhil Boyapati
Replace '== false' with '!' operator for boolean test
to adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: Using comparison to false is error prone
Signed-off-by: Akhil Boyapati <boyakhil978@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 864cd8b6d1f1..8f18175175ee 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)
rtw_ht_use_default_setting(padapter);
- if (pmlmepriv->htpriv.sgi_20m == false)
+ if (!pmlmepriv->htpriv.sgi_20m)
pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
- if (pmlmepriv->htpriv.sgi_40m == false)
+ if (!pmlmepriv->htpriv.sgi_40m)
pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX))
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: fix comparison to false
2026-04-09 22:11 [PATCH v2] staging: rtl8723bs: fix comparison to false Akhil Boyapati
@ 2026-04-10 6:45 ` Luka Gejak
0 siblings, 0 replies; 2+ messages in thread
From: Luka Gejak @ 2026-04-10 6:45 UTC (permalink / raw)
To: boyakhil978; +Cc: gregkh, linux-kernel, linux-staging, luka.gejak
Hi Akhil,
I am sorry to inform you, but upon checking, I have discovered that
your change was introduced in one patch in the past. You have probably
been working on master branch(one from Linus) and not staging-next.
Therefore, since patch wasn't merged to mainline yet, you didn't see
that your change is already present.
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-10 6:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-09 22:11 [PATCH v2] staging: rtl8723bs: fix comparison to false Akhil Boyapati
2026-04-10 6:45 ` Luka Gejak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox