From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 403883A2542; Thu, 9 Apr 2026 23:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775778234; cv=none; b=ai3DAcsDnhEaSoeXSZOpffn4eCQwapYDp+vAuQYrmlBXzVhqct8Na/QKvGpDabo1Ly7IdRBZC3Ux7H9FfZqrZPtvXbRmKlmqSnLk1LSrbJQL3jiVhgaxG+m4VGhLMfgXrQIt2A9B0RjodqRd8HtUoCZD8y2O05XXaKFJouNjR1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775778234; c=relaxed/simple; bh=gAUOUKeQWfXMQS+gwzMyPSCdGvq7t2FyRZ1piCNyVsw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OHBu+a6YvjrfYH9D1MLlUR41Lokg/QFwKdiNNANq2hWPSHvO4lyxkLCoHrPG4IYZFQ7gS/ecBOdbB54WtslU+ZEFd3LSNV/MLJ8NIzX+nK0EuH1j/Kj8AJ3wllQTTfQVlzcPTwJq98GK4QGm3MLhhhluxFaatfVY6YSgvVtPlvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BAmDpI6p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BAmDpI6p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58292C2BC87; Thu, 9 Apr 2026 23:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775778233; bh=gAUOUKeQWfXMQS+gwzMyPSCdGvq7t2FyRZ1piCNyVsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BAmDpI6p5H0OzeaMLCTzHNoflFqzKwKYdloMNxBi+6kGcMaa4S6XHSQ9wg5Wd2jcP hy+C8CQSJihzNs6WDtWiTnma3TI+IKBcM0eVxqMxPrDOo3PevseGl26/51rvAA4YIG VG3oYhF9d4HAYX/lDdTcrD3jxGWifNabJHPFhl1M/iMjcjiukfx35yyorXaozrTqqP Ox7EUsiNQ8S0sKwtrnMmgH39FKcQqDMQq4v2N+q45JKihxhiEwJVX5k7FpKxDFyUnD IsMTRDGdVcTP0ERDCfC0o8yblXIhHFBYzaJRswWrryilqniMO23nc0rMuc1s83Bjog 09JY03oEqpviA== Date: Fri, 10 Apr 2026 07:43:51 +0800 From: Yixun Lan To: Conor Dooley Cc: Uwe =?utf-8?Q?Kleine-K=F6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Duje =?utf-8?Q?Mihanovi=C4=87?= , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev Subject: Re: [PATCH 1/2] dt-bindings: pwm: marvell,pxa-pwm: Add SpacemiT K3 PWM support Message-ID: <20260409234351-GKA1160389@kernel.org> References: <20260409-03-k3-pwm-drv-v1-0-1307a06fba38@kernel.org> <20260409-03-k3-pwm-drv-v1-1-1307a06fba38@kernel.org> <20260409-laboring-announcer-4a0f9ca152a1@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260409-laboring-announcer-4a0f9ca152a1@spud> Hi Conor, On 16:41 Thu 09 Apr , Conor Dooley wrote: > On Thu, Apr 09, 2026 at 12:45:11AM +0000, Yixun Lan wrote: > > The PWM controller in SpacemiT K3 SoC reuse the same IP as previous K1 > > generation, while the difference is that one additional bus clock is > > added. > > > > Signed-off-by: Yixun Lan > > --- > > .../devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 53 ++++++++++++++++++++-- > > 1 file changed, 50 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > > index 8df327e52810..3427c8ef3945 100644 > > --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > > +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > > @@ -15,7 +15,9 @@ allOf: > > properties: > > compatible: > > contains: > > - const: spacemit,k1-pwm > > + enum: > > + - spacemit,k1-pwm > > + - spacemit,k3-pwm > > then: > > properties: > > "#pwm-cells": > > @@ -26,6 +28,38 @@ allOf: > > const: 1 > > description: | > > Used for specifying the period length in nanoseconds. > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - spacemit,k3-pwm > > + then: > > + properties: > > + clock-names: > > + items: > > + - const: func > > + - const: bus > > This condition here doesn't appear to do anything? It just repeats > what's already done unconditonally below? > You right, I should merge clock-names with below.. > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - spacemit,k3-pwm > > + then: > > + required: > > + - clock-names > > + properties: > > + clocks: > > + minItems: 2 > > + clock-names: > > + minItems: 2 > > + else: > > + properties: > > + clocks: > > + maxItems: 1 > > + clock-names: > > + maxItems: 1 > > > > properties: > > compatible: > > @@ -36,7 +70,9 @@ properties: > > - marvell,pxa168-pwm > > - marvell,pxa910-pwm > > - items: > > - - const: spacemit,k1-pwm > > + - enum: > > + - spacemit,k1-pwm > > + - spacemit,k3-pwm > > - const: marvell,pxa910-pwm > > > > reg: > > @@ -47,7 +83,18 @@ properties: > > description: Number of cells in a pwm specifier. > > > > clocks: > > - maxItems: 1 > > + minItems: 1 > > + items: > > + - description: The function clock > > + - description: An optional bus clock > > + > > + clock-names: > > + minItems: 1 > > + maxItems: 2 > > + oneOf: > > + - items: > > + - const: func > > + - const: bus > > > > resets: > > maxItems: 1 > > > > -- > > 2.53.0 > > -- Yixun Lan (dlan)