From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0760D27A10F for ; Fri, 10 Apr 2026 00:18:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775780323; cv=none; b=YGfMleUUTucZfFdbYloKsuMpWEvR89IyfW9yvHMtZ7TzYY90CNONrVlZTSDl0mPg1NUhhiLBxAOK+lRxcX6t2kTzkojpmO3fvJ9byhQ3mcspxwp+wCdzrm9rph5obEMyNTHz5lgjyOS/+1Kr6zw8EqvdGaJAOEYatuWkrZ2eYso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775780323; c=relaxed/simple; bh=/Q/ll9PivB5oIVa+0s1p+HhzrIQo6pfDmvHg0+GwGp0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GdnU61szfBHDU2u3yqlVT9aIOpMq20Yogw9oms19baCvnPjUJ//23vhWizgu7su25BtaP22gvxYUkx9G4YIpqqKGV5HT+EYdFR1KoAwbfm923gTZENkRmRSikklBHr2GfX7rWnkTrPyCUXydjtT+OOMLIG5CLI0isHKHLGRDJkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iVS3MxUJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iVS3MxUJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BC02C4CEF7; Fri, 10 Apr 2026 00:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775780322; bh=/Q/ll9PivB5oIVa+0s1p+HhzrIQo6pfDmvHg0+GwGp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iVS3MxUJnNfok8BEsH/dviiPNaVrgEYPvv7VzPpgVWHDeCJ5apJff9W6TCLKMuCfH ikX8XHNSK3YAo3oHbI0ET0Cl98IsEB5z3mImJull7hPRg9oKvxpTVVPVvfe/dUuXOe Ging1o40xnrKRKz7oPUf1valFg+7SHBpPU2a18Z557+sdalBIeAPr5wzx7Q7oW+fId hJUjPMco/A0Hz37cUii1S01Jkj8XqT5iTRsJQbBjeoTgbCQzp5i2eJadrNE5RcI/D4 YJIQp/vlJ+fEVHTe4lSEt0Fm4Dtkwj67AqgRI5gDRzPAQrHObLssq5A7EWw0+/773r y8QLSreSJKBaQ== From: SeongJae Park To: Ye Liu Cc: SeongJae Park , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Ye Liu , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/khugepaged: use ALIGN helpers for PMD alignment Date: Thu, 9 Apr 2026 17:18:33 -0700 Message-ID: <20260410001834.77924-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260409014323.2385982-1-ye.liu@linux.dev> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 9 Apr 2026 09:43:22 +0800 Ye Liu wrote: > From: Ye Liu > > PMD alignment in khugepaged is currently implemented using a mix of > rounding helpers and open-coded bitmask operations. > > Use ALIGN() and ALIGN_DOWN() consistently for PMD-sized address range > alignment, matching the preferred style for address and size handling. > > No functional change intended. > > Signed-off-by: Ye Liu Reviewed-by: SeongJae Park > > Changes in v2: > - Switch to ALIGN()/ALIGN_DOWN() per David's suggestion. > - Also convert collapse_scan_mm_slot() to keep PMD alignment helpers > consistent within khugepaged. > - Update the changelog accordingly. > - Link to v1:https://lore.kernel.org/all/20260408093534.2373007-1-ye.liu@linux.dev/ Nit. Changelog should go to the commentary area [1]. [1] https://docs.kernel.org/process/submitting-patches.html#commentary Thanks, SJ [...]