From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1031032D42B for ; Fri, 10 Apr 2026 01:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775785349; cv=none; b=Ye6pugjHyjR2GMzSw07UENbLzRZjSPQO23x4hA2hk6TZDb5OBAccEHAYXXSomTwKXLE6Ep9Gy2VxU0dJ7AgH+XXz4+FsGO5za6xwsR3jDFWQ31jwj2BV79XjMbvCZykynHhnjcUZEozDo1R6EhH1lmRcINv/AGMjumSoMBwET/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775785349; c=relaxed/simple; bh=HT7lQHQ5AJXz1uaBmUZzPS+BLamstIm/SqvIzrmV6ec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V5aOSADfwp4MGXMSZTktk340jR4NOGF391SIf54gNzwe5IOdz873/1RkXGYTkhLu7NuU7rmGPbd1m2dAxH2VqewDYhlVan+sSPUrplzABNoxG8XYmjMlG+VmKrLvWPQojioq7L6JJrkx6Xfr5Y45FRr+r20pHJUtrcMSfQ2nwEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pq3axj0E; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pq3axj0E" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2aae4816912so10817865ad.2 for ; Thu, 09 Apr 2026 18:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775785347; x=1776390147; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z8yKufuZmFyyhr/wDhxT96eTbRmSN02tyOE6Nk86BP0=; b=Pq3axj0EWzd+tY7HHawDB9WVzbcsrqWBzDpcCG/b8w+W8aWBHoE4Fit4KzZnLZ78E0 aTrThY61CaMmJMImz7n2MF5cZe+psgXxzAm6FItemsvMmMPujm79bPRIYU/s93a4CGBH OwGXy2fT8ArtAy6v158dsmuJ/YRYqSACC+/cSs+w3npokD1tIJtIavBVCC8znlaU8bxn eHggxFawpgAtUZEhyjCTjjPftNEelZ3IcQ1dljWlXhGAWQPZxUlxL1Oxhg5O8+2WkbOG Klx3kArHBODHCwiGKMW/tRvYPSWVJ3TG0CjM3OntX/YGyNtL+LgujBqvARlXWND5HjL6 qe+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775785347; x=1776390147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z8yKufuZmFyyhr/wDhxT96eTbRmSN02tyOE6Nk86BP0=; b=Loh4Ij309x75dNsHRTgtQ5lAWr7KjjBAegisOm/oxHct9cwidJSB/m2DS2wOn0liTY WsuvlWubFTOu8fEPyMbmHIeX2FODw02CmRCwmAgsapnR12yai+9OGKlYJgMw5ZXrL5SN PXfCgvp0GwfdqLaLkwpSDjMFkSBgiCMyKMd2rTd8BQzurBE0+RzmJA7SiNUQUuopr+zu U2r+SCkZ3PaS0X/czAF8RLfNkSmXUURxQ7N+7sENFXTiSvcifjE9r1ZGAtN+s7K/ZmuR f2B2DLMpYutMDELNN89BkNRKcWf7pnsL1sqUuTd5bvNL2UxeccA3qpnLTS77hxQOdLSW Q2gQ== X-Forwarded-Encrypted: i=1; AJvYcCWYX9mz5dpenifAPxmNExkGjQ1ihXgoEbTDf6EJX1GCoL1shXtucCB2W83GXX+kNhft2ysgUzjOy/mKePU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6uLQ+V5lmZ+6ehoFSRDu5SXaz0Bjl/3YEPRfQg3onv30OvPF5 DFsw0mzsE0VX32Z/mhhIuZ2nEglcseZx9HBs2HsgcQyk/Wr0nS+wb5I1 X-Gm-Gg: AeBDieukcRA3HOG75C3mm/eMNIM1BCWFDp1DhZBCcqe82TSiwVdBHBu2KCL2xI7n6lm RMmPIX+WXTK5V0pO+GCyZ3NPmevnnc3Opdzs3qIDnzLM1GUvaQpeYOHscOXm4X+z0Tq7I0yHAES LF5IjsG8QBMv9iV/sQAbeRaD38s3DfMON5Pd3cy8CbiMZX//FqesinHYPTaV+VMc2sypAhi4ZdD uCSJ7zBUthSFMDAEr2Uc3FlXvusc/ZN1GAD+N274uMmOBSgXF4/9LHG+TGW32YpB1fXM+M53DVN HyZHYquJNerG97e2wuWQ87mXtCq0PQZ6mq1OMK5G1t8ArQF8z90EKoRNtEulIqda0dIQdIqR4gD t34+MIpMTq/d2L53GG4pLPGQdF6Ej3e3eNk2cyBmZqBcG0XLBuncvv1kPTTflGda45k9X2lYuoJ E9DiOOvi/DLzUq2ihmR6YTrPR2PrmJDnStU8512RPt2xuS9iIpdPz3ZA== X-Received: by 2002:a17:902:7087:b0:2ad:bd4c:a5 with SMTP id d9443c01a7336-2b2d5939849mr9355405ad.1.1775785347265; Thu, 09 Apr 2026 18:42:27 -0700 (PDT) Received: from localhost (as040201.dynamic.ppp.asahi-net.or.jp. [150.9.40.201]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2b2d4ddb742sm9084405ad.27.2026.04.09.18.42.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2026 18:42:26 -0700 (PDT) From: osjin83@gmail.com To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, osjin83@gmail.com Subject: [PATCH v3 1/4] staging: rtl8723bs: fix spacing around operators in rtl8723b_phycfg.c Date: Fri, 10 Apr 2026 10:42:11 +0900 Message-ID: <20260410014214.10684-2-osjin83@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260410014214.10684-1-osjin83@gmail.com> References: <20260410014214.10684-1-osjin83@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jinemon Tama Fix various spacing issues reported by checkpatch.pl to improve code readability and conform to the Linux kernel coding style. These changes are purely cosmetic and do not alter the functional behavior of the driver. Signed-off-by: Jinemon Tama --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 46 +++++++++---------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c index 7fac1c2ba8e0..a7266a758c45 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -19,7 +19,7 @@ static u32 phy_CalculateBitShift(u32 BitMask) u32 i; for (i = 0; i <= 31; i++) { - if (((BitMask>>i) & 0x1) == 1) + if (((BitMask >> i) & 0x1) == 1) break; } return i; @@ -109,18 +109,18 @@ static u32 phy_RFSerialRead_8723B( NewOffset = Offset; if (eRFPath == RF_PATH_A) { - tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord); - tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | (NewOffset<<23) | bLSSIReadEdge; /* T65 RF */ - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord, tmplong2&(~bLSSIReadEdge)); + tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWord); + tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | (NewOffset << 23) | bLSSIReadEdge; /* T65 RF */ + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWord, tmplong2 & (~bLSSIReadEdge)); } else { - tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter2|MaskforPhySet, bMaskDWord); - tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | (NewOffset<<23) | bLSSIReadEdge; /* T65 RF */ - PHY_SetBBReg(Adapter, rFPGA0_XB_HSSIParameter2|MaskforPhySet, bMaskDWord, tmplong2&(~bLSSIReadEdge)); + tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter2 | MaskforPhySet, bMaskDWord); + tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | (NewOffset << 23) | bLSSIReadEdge; /* T65 RF */ + PHY_SetBBReg(Adapter, rFPGA0_XB_HSSIParameter2 | MaskforPhySet, bMaskDWord, tmplong2 & (~bLSSIReadEdge)); } - tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord); - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord, tmplong2 & (~bLSSIReadEdge)); - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord, tmplong2 | bLSSIReadEdge); + tmplong2 = PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWord); + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWord, tmplong2 & (~bLSSIReadEdge)); + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWord, tmplong2 | bLSSIReadEdge); udelay(10); @@ -129,16 +129,16 @@ static u32 phy_RFSerialRead_8723B( udelay(10); if (eRFPath == RF_PATH_A) - RfPiEnable = (u8)PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter1|MaskforPhySet, BIT8); + RfPiEnable = (u8)PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter1 | MaskforPhySet, BIT8); else if (eRFPath == RF_PATH_B) - RfPiEnable = (u8)PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter1|MaskforPhySet, BIT8); + RfPiEnable = (u8)PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter1 | MaskforPhySet, BIT8); if (RfPiEnable) { /* Read from BBreg8b8, 12 bits for 8190, 20bits for T65 RF */ - retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBackPi|MaskforPhySet, bLSSIReadBackData); + retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBackPi | MaskforPhySet, bLSSIReadBackData); } else { /* Read from BBreg8a0, 12 bits for 8190, 20 bits for T65 RF */ - retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack|MaskforPhySet, bLSSIReadBackData); + retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack | MaskforPhySet, bLSSIReadBackData); } return retValue; @@ -203,7 +203,7 @@ static void phy_RFSerialWrite_8723B( /* */ /* Put write addr in [5:0] and write data in [31:16] */ /* */ - DataAndAddr = ((NewOffset<<20) | (Data&0x000fffff)) & 0x0fffffff; /* T65 RF */ + DataAndAddr = ((NewOffset << 20) | (Data & 0x000fffff)) & 0x0fffffff; /* T65 RF */ /* */ /* Write Operation */ /* */ @@ -266,7 +266,7 @@ void PHY_SetRFReg_8723B( if (BitMask != bRFRegOffsetMask) { Original_Value = phy_RFSerialRead_8723B(Adapter, eRFPath, RegAddr); BitShift = phy_CalculateBitShift(BitMask); - Data = ((Original_Value & (~BitMask)) | (Data<nCur40MhzPrimeSC>>1)); + PHY_SetBBReg(Adapter, rCCK0_System, bCCKSideBand, (pHalData->nCur40MhzPrimeSC >> 1)); PHY_SetBBReg(Adapter, rOFDM1_LSTF, 0xC00, pHalData->nCur40MhzPrimeSC); - PHY_SetBBReg(Adapter, 0x818, (BIT26|BIT27), (pHalData->nCur40MhzPrimeSC == HAL_PRIME_CHNL_OFFSET_LOWER) ? 2 : 1); + PHY_SetBBReg(Adapter, 0x818, (BIT26 | BIT27), (pHalData->nCur40MhzPrimeSC == HAL_PRIME_CHNL_OFFSET_LOWER) ? 2 : 1); break; default: break; -- 2.53.0