* [PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test
@ 2026-04-10 6:40 Venkat Rao Bagalkote
2026-04-10 8:31 ` Saket Kumar Bhaskar
2026-04-10 13:52 ` ChenXiaoSong
0 siblings, 2 replies; 4+ messages in thread
From: Venkat Rao Bagalkote @ 2026-04-10 6:40 UTC (permalink / raw)
To: sfrench, pc
Cc: skb99, maddy, linux-cifs, linux-next, linux-kernel,
Venkat Rao Bagalkote
On the latest linux-next following modpost warning is reported:
WARNING: modpost: missing MODULE_DESCRIPTION() in
fs/smb/client/smb1maperror_test.o
Add MODULE_DESCRIPTION() to the test module to fix the warning.
Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
---
Changes in v2:
- Fix typo in MODULE_DESCRIPTION
fs/smb/client/smb1maperror_test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/smb/client/smb1maperror_test.c b/fs/smb/client/smb1maperror_test.c
index 820c0dd3bcce..b93d3ac41f91 100644
--- a/fs/smb/client/smb1maperror_test.c
+++ b/fs/smb/client/smb1maperror_test.c
@@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
kunit_test_suite(maperror_suite);
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("SMB1 error mapping selftest module");
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test
2026-04-10 6:40 [PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test Venkat Rao Bagalkote
@ 2026-04-10 8:31 ` Saket Kumar Bhaskar
2026-04-10 13:52 ` ChenXiaoSong
1 sibling, 0 replies; 4+ messages in thread
From: Saket Kumar Bhaskar @ 2026-04-10 8:31 UTC (permalink / raw)
To: Venkat Rao Bagalkote
Cc: sfrench, pc, maddy, linux-cifs, linux-next, linux-kernel
On Fri, Apr 10, 2026 at 12:10:30PM +0530, Venkat Rao Bagalkote wrote:
> On the latest linux-next following modpost warning is reported:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> fs/smb/client/smb1maperror_test.o
>
> Add MODULE_DESCRIPTION() to the test module to fix the warning.
>
> Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> ---
> Changes in v2:
> - Fix typo in MODULE_DESCRIPTION
>
> fs/smb/client/smb1maperror_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/smb/client/smb1maperror_test.c b/fs/smb/client/smb1maperror_test.c
> index 820c0dd3bcce..b93d3ac41f91 100644
> --- a/fs/smb/client/smb1maperror_test.c
> +++ b/fs/smb/client/smb1maperror_test.c
> @@ -74,3 +74,4 @@ static struct kunit_suite maperror_suite = {
> kunit_test_suite(maperror_suite);
>
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("SMB1 error mapping selftest module");
> --
> 2.45.2
>
LGTM, feel free to add below tag:
Reviewed-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test
2026-04-10 6:40 [PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test Venkat Rao Bagalkote
2026-04-10 8:31 ` Saket Kumar Bhaskar
@ 2026-04-10 13:52 ` ChenXiaoSong
2026-04-10 15:11 ` Venkat Rao Bagalkote
1 sibling, 1 reply; 4+ messages in thread
From: ChenXiaoSong @ 2026-04-10 13:52 UTC (permalink / raw)
To: Venkat Rao Bagalkote, sfrench, pc
Cc: skb99, maddy, linux-cifs, linux-next, linux-kernel
Thanks for your patch. It is "KUnit test" rather than "selftest".
Perhaps the following description would be better: "KUnit tests of SMB1
maperror".
On 2026/4/10 14:40, Venkat Rao Bagalkote wrote:
> +MODULE_DESCRIPTION("SMB1 error mapping selftest module");
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test
2026-04-10 13:52 ` ChenXiaoSong
@ 2026-04-10 15:11 ` Venkat Rao Bagalkote
0 siblings, 0 replies; 4+ messages in thread
From: Venkat Rao Bagalkote @ 2026-04-10 15:11 UTC (permalink / raw)
To: ChenXiaoSong, sfrench, pc
Cc: skb99, maddy, linux-cifs, linux-next, linux-kernel
On 10/04/26 7:22 pm, ChenXiaoSong wrote:
> Thanks for your patch. It is "KUnit test" rather than "selftest".
>
> Perhaps the following description would be better: "KUnit tests of
> SMB1 maperror".
>
> On 2026/4/10 14:40, Venkat Rao Bagalkote wrote:
>> +MODULE_DESCRIPTION("SMB1 error mapping selftest module");
Thank you for the review. I have sent v3, with proposed changes. Please
review v3.
https://lore.kernel.org/all/20260410150247.93178-2-venkat88@linux.ibm.com/
Regards,
Venkat.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-10 15:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-10 6:40 [PATCH v2] smb: client: add missing MODULE_DESCRIPTION() to smb1maperror_test Venkat Rao Bagalkote
2026-04-10 8:31 ` Saket Kumar Bhaskar
2026-04-10 13:52 ` ChenXiaoSong
2026-04-10 15:11 ` Venkat Rao Bagalkote
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox