From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D6963939DE for ; Fri, 10 Apr 2026 07:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775804988; cv=none; b=DznEnMJKFLMLSgr4TNXUymgNntBthYp7KkSQ4e+JxtUbAUt+kTJJTvooZSIcKThzEuxaRravR+Q9g0BClWMgGXZHEfA6XSXKh3UiNL1lbbzCDBVd8xejT/4BGTVjw96JnzG84tbvFCAzDw+mq/irob3op45Lgamid7SDirH4t+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775804988; c=relaxed/simple; bh=/xh8mbmsndrtfR6dGnoexqxNFoHHbegyXk8sqrhDi/g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GBjfNSWlSwqhFsyWLVnf6mOHJxjn5tL9mfRlSVzKuewCg0UnEHYSxDYZviAq7yT2wxpmGpf2lWAbbxj9waVSI/8GbceMuD2oCA9ZgOL3NxMdJZLC+CBBUXA+xMoAGLEVgArkYee+0pByeFxrjIwh9O6xwoTm6Z3DlWM8J1brcKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TDZJbw28; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RNJk9nNP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TDZJbw28"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RNJk9nNP" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63A6s63K1433128 for ; Fri, 10 Apr 2026 07:09:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=5P8NXaOriPkPC2q0IRIWz9wKZcBWfE5/xl+ XEf1jVQ4=; b=TDZJbw28P7WvcFvFthM1dYWl7MpKJOVzb/nmk83ywwpePZQIurg pQLwORmoW6gH15oGMA/yBgtVtZfW62pBWog+rqSyHM0d9S3k1Ty6dTKBndlAA8wN R9NQULd1MQ/+WUaYDgr7LL4Ron4es66rYcDkNXbXeTB9hcE8FMd91Sd3Y8FGLlxG Y26FYG+IcdWTJlMpY70fWiopkb4gka6ARm7t74lZi7zmbW8B3BpkwV0CNZkHM0E+ 1EdwVtLLVU9p3FNnIv1rEIBWucMvFFvqBZuVsE8HFYBvbvaowQWv26dChumtmMwM u+l+9lBe2BI70nrzr3l+d4uxN6RDLQuqI7g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4deckfb5u7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 07:09:45 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50da31af14cso42366101cf.1 for ; Fri, 10 Apr 2026 00:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775804984; x=1776409784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5P8NXaOriPkPC2q0IRIWz9wKZcBWfE5/xl+XEf1jVQ4=; b=RNJk9nNPyS4WHtOo2OiUkqXrKtUEpHWNvpRXbI6Zzt+DKG1EXqkTc1MDqPTbBFFepq DKLIKOqKDG3XZm3K1bAFdOYzyIgmFTGf+wxXkHSbEH/dl83vSTEUvOFHYUh9zFM5fjVz cJ9ubviHKJAqv/pjnOMec87Xal2MxfNeekLWucv+hOROH+dZCqH2zTWUAOXJ/7IHEyj0 P5K9LHF+ZA3/QrUb58qJGzBVkkzoa6CmUApo9Y8po50W1prsjY2aWcp+EZqPGzikImul Xsv8Rv8fLFhC5xEMiRg4ATGY6FH+HURXqqaGzHCbwdpRL3UdHXuGNnL/wEi6k7idVP5q kKfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775804984; x=1776409784; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5P8NXaOriPkPC2q0IRIWz9wKZcBWfE5/xl+XEf1jVQ4=; b=n+gDIzjhbisiE+5ChQb9rjhu/i3au02ytIaWKppmfnxK/rQjaOYidUoS0Ckhk0GGA4 YEh+ndia3HbvnE+ixQX7y8FgWGWb2YxJd+Y7l8YcjDT70fMfHEJ0ilC9sch7gT7x7Mp8 u91IZ/SMn8ydeA0x9DSQwhBDe51m1ylg2hO75ooHLCVF0BSE6XkrQ3A/CWL3fST+mVam sirahWnWdqlbng3U7HRbvV1tZOMdEbr3po7OA5KKMwXInLMNulDPJJcwDYVMBc8yDYVI Wk6/aeY3AJoTfTNO8MkW0IhZDDjEljm9bkNsydkBRhtx5UDQLwHVj0z9YLFcsSn/BHXG O9og== X-Forwarded-Encrypted: i=1; AJvYcCVRlGWR7SlNmeXnIzk2Z9jV8XcTuFRD+LMavrabp6DNiOiTcfVgfHRuqrQ4ieR3Wg3yJfQO2Gdezwes/P0=@vger.kernel.org X-Gm-Message-State: AOJu0YwXR0unTXtErg4Y24fANytpz3ybIoA1O5QlOatZoKJsTVXtMkR1 prKeJ1YYqKk27kjGFMBnNFjEqtCyR5j1QDDF7r/dvyQqzBicgjg7zaKWmhlHbX3YnayNm51m8Ip YqgC1aU4DEk074NhavcIhxzukNidOVBIBZEPjgnOXW0fNSkwH4yg0jgRl7ypZG2dwSrk= X-Gm-Gg: AeBDiesBC5uV1gbi8bRtyFkAY5hamzG2Xq6r55gwQD8c5gsmcak2VqCFpYz9ltqOj9z OuwSLgjvh9MALX2zpYl9fy+aeCwTzVtHECv2dSgj2TTd5eqiXa7y0pgHZRo2K9HMmg2Nv+Ve7+o g38GQHb/O2I+MWUmGS0hDa3QQNmAsEZg6z+voRDgkM984caqJjmlYYXFWIh+vVgwA5NSVwTVbAA qz3hH56+fmBZUexT79e+3OLkFjWIW41Fdkm3goyCJZ88HjJIAyE823IwXwTi6mGvgWc3TwRo3/r 67ilVh1XKZteHnfT9emP6j4S2+LwMLFnXJkJENsBSOacf8cXkDuzihXIJ1muO1snOhWKGguDvzK kh/kB6wl+bO2TH7lTfYFaAp6VrtnR82rC2LHZQ7IBcDstHFKEaA== X-Received: by 2002:a05:622a:834f:b0:50d:aa99:7bbf with SMTP id d75a77b69052e-50dd5c0be6bmr27269021cf.43.1775804984544; Fri, 10 Apr 2026 00:09:44 -0700 (PDT) X-Received: by 2002:a05:622a:834f:b0:50d:aa99:7bbf with SMTP id d75a77b69052e-50dd5c0be6bmr27268711cf.43.1775804984031; Fri, 10 Apr 2026 00:09:44 -0700 (PDT) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:7d6c:c663:fa06:9ee8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e50289sm5338689f8f.28.2026.04.10.00.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 00:09:43 -0700 (PDT) From: Bartosz Golaszewski To: Frank Wunderlich , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski Subject: [PATCH] pinctrl: mediatek: moore: implement gpio_chip::get_direction() Date: Fri, 10 Apr 2026 09:09:35 +0200 Message-ID: <20260410070935.9540-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=S/fpBosP c=1 sm=1 tr=0 ts=69d8a239 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=gdeKHt93fcZDdug0Yb8A:9 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDA2NCBTYWx0ZWRfXzo2aHoyrOotw 2Mjgp//Vq8iC3JtncX7SMayMU+ZPc5x6nA0/9yby/Vsje8cUo68P0NUa3MA633xtgKXPi0ZJBTN LJKWzvsU/+9mwWRIC64IShp2xjhXE6r/JXzuadYWtyCxG7GO5JSYBV56JbPXgCAJ6tZ5/QOETiv JRZQCoTHw6lMA8hxJ3hwzUaVFa3u5INJyiGV09jRLq9iuNaryONZUcfjt8stsYgn7M0PkJ5/SH6 KZpURdYmiMwChWnUw0pUFTnssUFUZiLXfm2m6jP1YUBv3vxNMzp606p2S2qXMVy+tNRezBFkWss r/5Q9ZeX07/fSfIkVIT1Z9oN12OAtKrTHIXhOVYGBMyDSmBqbmE+vzrmK9Z1OjnYv6pvJA7rr2W HC7Krhks97UTVhjPDb3kxaxcQCLQ61QKVdZ3vjEMlYxmc+fycIwDTJKHl4QgknmvcKYnTXQsVYv OFWUCL02U61zCvWwVDA== X-Proofpoint-ORIG-GUID: DOJencuZUxSAUrwDTpEbuEXOY0-Kqe9p X-Proofpoint-GUID: DOJencuZUxSAUrwDTpEbuEXOY0-Kqe9p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_02,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100064 If the gpio_chip::get_direction() callback is not implemented by the GPIO controller driver, GPIOLIB emits a warning. Implement get_direction() for the GPIO part of pinctrl-moore. Fixes: 471e998c0e31 ("gpiolib: remove redundant callback check") Fixes: e623c4303ed1 ("gpiolib: sanitize the return value of gpio_chip::get_direction()") Reported-by: Frank Wunderlich Closes: https://lore.kernel.org/all/20260409132724.126258-1-linux@fw-web.de/ Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-moore.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/pinctrl/mediatek/pinctrl-moore.c b/drivers/pinctrl/mediatek/pinctrl-moore.c index 70f608347a5f6..071ba849e5322 100644 --- a/drivers/pinctrl/mediatek/pinctrl-moore.c +++ b/drivers/pinctrl/mediatek/pinctrl-moore.c @@ -520,6 +520,23 @@ static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, return pinctrl_gpio_direction_output(chip, gpio); } +static int mtk_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) +{ + struct mtk_pinctrl *hw = gpiochip_get_data(chip); + const struct mtk_pin_desc *desc; + int ret, dir; + + desc = (const struct mtk_pin_desc *)&hw->soc->pins[offset]; + if (!desc->name) + return -ENOTSUPP; + + ret = mtk_hw_get_value(hw, desc, PINCTRL_PIN_REG_DIR, &dir); + if (ret) + return ret; + + return dir ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN; +} + static int mtk_gpio_to_irq(struct gpio_chip *chip, unsigned int offset) { struct mtk_pinctrl *hw = gpiochip_get_data(chip); @@ -566,6 +583,7 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw) chip->parent = hw->dev; chip->request = gpiochip_generic_request; chip->free = gpiochip_generic_free; + chip->get_direction = mtk_gpio_get_direction; chip->direction_input = pinctrl_gpio_direction_input; chip->direction_output = mtk_gpio_direction_output; chip->get = mtk_gpio_get; -- 2.47.3