From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9E9C3AC0EA; Fri, 10 Apr 2026 08:18:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809137; cv=none; b=X2qPG76uUv899tJ4AC0firL8t3v2alcsciq549rvG0hBkpIAz8lLdkBuqc0m7N8Ex6BCv9Nu84o9jmy+8vpmTXVta0Or6/wEA23+zrds2QSwKStYb7M11JFJ4Kj6h5jfFnuVxu+BZJr10ojshDEEiZYdArYOAG0d95iXzrUQslA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809137; c=relaxed/simple; bh=PgNF6KIfTsr8geLhQ83j+NHXlo6CNE5QENaScwNL7Kc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lGXGppuT6hTAJ8ArC1UtoKQewM30Yykn6/c1L2k8WxZ0M6LbZGEMF+TyMSI2vmk5omcy3CRA9J91h/HD9bk5l5tIWy5XB9RGXStXj4B6NvSeMXjErVFlCM+hj69xzpqGdiNo0QS+OpBcQatGE5S7oMPzopvHq1kEIUBr+C2g71U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uMjWx2tj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uMjWx2tj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80A15C2BCB2; Fri, 10 Apr 2026 08:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775809136; bh=PgNF6KIfTsr8geLhQ83j+NHXlo6CNE5QENaScwNL7Kc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uMjWx2tjaQHLrgrCDEqoF3ZdepgTOlqmcY0bfBQLr24HI/VvcthqIG/VdjqBxSegF cxsVMQK/tqmkLl22IexLVcXZDq9t49KGjSuGhmQtO0PwCenhLdnBfG8+MfYGtOikz7 F/6M+JqBUnJDbm9FP2VABu4mjk+xGgZ/Nw5zIW3rOPtC8gnVJn5Z/U4Iq1QkM5SIiN YCfiJfClbKXRrtv+opcmKh4K1K992C09yjvXLj3y9UX1+yxsyccWIBlB0/h/uUhzBE EKUoGQWNmri8h5cI364U/Hh6Yc/eSaGffwQgmtGZdZXwjBCkAvBCJVsLv8/wrKrXi1 37r4axlIeYBNw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wB74n-000000026uY-3nLF; Fri, 10 Apr 2026 10:18:53 +0200 From: Johan Hovold To: Mark Brown Cc: Matthias Brugger , AngeloGioacchino Del Regno , Frank Li , Sascha Hauer , Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry , Linus Walleij , Andi Shyti , Tudor Ambarus , Paul Walmsley , Samuel Holland , Orson Zhai , Baolin Wang , Jernej Skrabec , Masahisa Kojima , Jassi Brar , Laxman Dewangan , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 09/26] spi: qup: fix controller deregistration Date: Fri, 10 Apr 2026 10:17:39 +0200 Message-ID: <20260410081757.503099-10-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260410081757.503099-1-johan@kernel.org> References: <20260410081757.503099-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: 64ff247a978f ("spi: Add Qualcomm QUP SPI controller support") Cc: stable@vger.kernel.org # 3.15 Signed-off-by: Johan Hovold --- drivers/spi/spi-qup.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index 6cbdcd060e8c..45d9b4cb75e4 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -1193,7 +1193,7 @@ static int spi_qup_probe(struct platform_device *pdev) pm_runtime_set_active(dev); pm_runtime_enable(dev); - ret = devm_spi_register_controller(dev, host); + ret = spi_register_controller(host); if (ret) goto disable_pm; @@ -1320,6 +1320,10 @@ static void spi_qup_remove(struct platform_device *pdev) struct spi_qup *controller = spi_controller_get_devdata(host); int ret; + spi_controller_get(host); + + spi_unregister_controller(host); + ret = pm_runtime_get_sync(&pdev->dev); if (ret >= 0) { @@ -1339,6 +1343,8 @@ static void spi_qup_remove(struct platform_device *pdev) pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); + + spi_controller_put(host); } static const struct of_device_id spi_qup_dt_match[] = { -- 2.52.0