From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 137913ACA61; Fri, 10 Apr 2026 08:18:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809137; cv=none; b=gxyUuO985I4w6Mqhg6UqP58t3IkJwmrJ6yHLiIKi6idYrvWQGNTu6KR6v/K9A2VBmoJoCzLgkPmbAkZhsChPLHyWS9Jmxm0znW1iERLOCY8KpvYBub+ed3dpCnwStMB2y13pKnocyeH5lUNJaZfoHyVJdB3OcxEpXSnRlST5jYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775809137; c=relaxed/simple; bh=mBOiglv4c8RVhlq0bsWFsH4QCDFb6P9V9vpukqwXKlY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J+TgC9WG9bQD76Ic6IL2LSAKBDFlyA7Kv8h+MpwLnSY3ooXae8Ouv3dBqdp6ZIaCULU/vbpL5iR8omUYrzlBfdibBdTH3oULiu/j8/BmQTrMlp4mvTjEH26Zmy57z8aZMLjIKvyY113jMYi4cHKmG/9230LHmrrVBKOwZDQV/uw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QJeZ5mx8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QJeZ5mx8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83117C2BCB4; Fri, 10 Apr 2026 08:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775809136; bh=mBOiglv4c8RVhlq0bsWFsH4QCDFb6P9V9vpukqwXKlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QJeZ5mx8kF6UrYv1+lcO3dmF7H3Ag1xveS9Id2lWzv3ADKMGFlJ7+lQsP7J1LHdDI g6LQQ6P0L8jWsmV4AhlXcS6y5lnfHLL/8gJEAwfYhFS66RkFxcy6lTfWvV90qhO4WM A9nNdgrCIZ4lvhbkeiyaTYKrrwDjK0xRCeEFeoTjY91GF+bkfcvA2rJyXP8xuY+QIY PynxmrJodL9F0YJ00NS8cRjdE+7aLqT2oExwRjcloGKTzsoc/ACnvXNyxf5r/48pkl ZpVQHs84s4CAUo0aJARYszByWgcaEsO4pBfYaE0h+JZfBtXExV2rYal5TqSRK6PeFK QcMtpUvg2gvVA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wB74n-000000026uU-3iZV; Fri, 10 Apr 2026 10:18:53 +0200 From: Johan Hovold To: Mark Brown Cc: Matthias Brugger , AngeloGioacchino Del Regno , Frank Li , Sascha Hauer , Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry , Linus Walleij , Andi Shyti , Tudor Ambarus , Paul Walmsley , Samuel Holland , Orson Zhai , Baolin Wang , Jernej Skrabec , Masahisa Kojima , Jassi Brar , Laxman Dewangan , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Purna Chandra Mandal Subject: [PATCH 07/26] spi: pic32-sqi: fix controller deregistration Date: Fri, 10 Apr 2026 10:17:37 +0200 Message-ID: <20260410081757.503099-8-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260410081757.503099-1-johan@kernel.org> References: <20260410081757.503099-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure to deregister the controller before releasing underlying resources like DMA during driver unbind. Fixes: 3270ac230f66 ("spi: pic32-sqi: add SPI driver for PIC32 SQI controller.") Cc: stable@vger.kernel.org # 4.7 Cc: Purna Chandra Mandal Signed-off-by: Johan Hovold --- drivers/spi/spi-pic32-sqi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-pic32-sqi.c b/drivers/spi/spi-pic32-sqi.c index 051590038895..41662992dbe5 100644 --- a/drivers/spi/spi-pic32-sqi.c +++ b/drivers/spi/spi-pic32-sqi.c @@ -642,7 +642,7 @@ static int pic32_sqi_probe(struct platform_device *pdev) host->prepare_transfer_hardware = pic32_sqi_prepare_hardware; host->unprepare_transfer_hardware = pic32_sqi_unprepare_hardware; - ret = devm_spi_register_controller(&pdev->dev, host); + ret = spi_register_controller(host); if (ret) { dev_err(&host->dev, "failed registering spi host\n"); free_irq(sqi->irq, sqi); @@ -665,9 +665,15 @@ static void pic32_sqi_remove(struct platform_device *pdev) { struct pic32_sqi *sqi = platform_get_drvdata(pdev); + spi_controller_get(sqi->host); + + spi_unregister_controller(sqi->host); + /* release resources */ free_irq(sqi->irq, sqi); ring_desc_ring_free(sqi); + + spi_controller_put(sqi->host); } static const struct of_device_id pic32_sqi_of_ids[] = { -- 2.52.0