From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF31434D3BF for ; Fri, 10 Apr 2026 09:38:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813898; cv=none; b=Iv3PzBGp0QE5zCfQmJJki658mgFxNkFbl5yV/B2ecIaBQIko/NIFJuAQmsLwq9FABRvQIT4BHF6NlxIqjBxxW8RzzT9vLrtRfiYxGjv5T/4qQGO2n1n8pdD+n9jbl8t0r1NlQOi1uyTuqDy0GENUrXROs1zC8ZI4llGgKvw4gbs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813898; c=relaxed/simple; bh=aSmtDzF2UtcOQnNd2fhRFLoqn9B6xZOun32UWNpl4L0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=fP+3TRH16uuZ5qRR/ySvJPT09Vnij8aeX5Kqu90U2uNcqZL6Ci+c4zm3RwFVkUFMdImUrlfEZlI2m+UxgCGtJ29sYvWwEtJ9CR5RhAka3GqoMjgyhaxbuGv8aEkOiwLY2kChrsjorzxCU7X/vDgOU21a2VGmgaI/quyiW4BvM7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pg5k10e3; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pg5k10e3" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2b24fcc2b5dso13327145ad.1 for ; Fri, 10 Apr 2026 02:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775813896; x=1776418696; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6vwcRPslwhrYVAEmvINakniySZsO6ad72sLfnSB79tI=; b=Pg5k10e3edqh6MG9lfyhZ3C13EqZdLdrRlRLBEVQ+Qfd3KLWMmaBxkHEVhq4lKwXLt cxejg4Qol8AqMuDKfCk7rtifdfMBNfu9AXhZ7BBtlNyQp2r/gg+jHRUzLK9SYjXmX/6o aM4ntSVaYN63Iuyp/3Js/HNJNONNUM1WXeOzZVBAXVWEMHhQ06KrBGRN6qbytYlDMoW0 KtUncfMhNQXM6ws6n8xBgGa4BFYe9jFk+JQD95k+pDb25UcimvDhunft5KKfmwqe1pNw ZEZAyxEBUhIGZDN+o+lqBh875zoplNPlGrQwmCIaXEa+EIn3p2H4awdXRvkUIUf1BoU4 hpRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775813896; x=1776418696; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6vwcRPslwhrYVAEmvINakniySZsO6ad72sLfnSB79tI=; b=e/3I19JRUDmWxpyS1LC8Nig0fT62uRxC5VlOFdKmVF8ny8PlEj9xaOZrtopLYlR9+C fbo20jGHbGJGKXj01iIo0lEZpcRwnoRinaG/5n3dqhi9K/FVUhrJWmlbglM4OxflUN2W WVDm6SeP/Xg6CsfETrPSqeZ1kjwPnR6dHnMpE6t0Up930081IqueMSYo/NKJcm+uxV8I DmFSl/ZYkd9Fxs7T1Td4qGA5B5EZsT9LUgylAkyiu+0PY1FiZXpOk4507dAzn9xtIHyo gOqIcgS6O49u67/iPs66AtRldg/vMlfXOt4wjJlNKZAzTqL7i/lTZc8YJPZDW5bgqv4N m3WA== X-Forwarded-Encrypted: i=1; AJvYcCUPdZ99KsN+RdA0YI3W3/bh3Tf11dvIb2PPwU/wjZG9O6Jt9XqGf/M7M4+HTfuWhJ98009SqD2sJi2OhVk=@vger.kernel.org X-Gm-Message-State: AOJu0YzfzEINd8T0GkJub8V3LGAwuYMdXUui2yHEx+SXZFKeMGHthY4F 1VoMEYzhXVvYgPQENZ1n/ItC+zagdKcips875Yrf2tE/5Wl1mqahWkDZ X-Gm-Gg: AeBDieuwY3XHlC0QiJUc7+cXO5rOSofKyZdXV2cPTLi4dnSN6RpdF7Ei8rEms0Qc9vu w2I2fWoIjLb0u2F4NfjVeDakSSIjRJbSar+gnJmaAx4glfjjdeINnl2Etje4aLDconLLzXylmkC VZCtcLY7qieR7sNV/6ghySLwoaJxzTCzZsXvIHxKcRf4RPCtOc+i9bZnbN1FTIbs6jHDnYGBcWf wCDoyY9GKcndmK/uYhDX10EE+STOfMdBU+sgYr0MGW6yhtroZzoqf36Okb/ztdSplFc7HwNLkRN eZC1sg4NnouYgRNh4dPNxEc01NYHuLCzyQIiwru5/qrHXNo4C7cqEvLbSedG2CflR4DEtJu1rg5 ehKsF9iMRUpIFFRK2EnZ9dmZ5G4DwiYafEKJppGpcSFsOsKRIcfMBrCrjschzeT/F3CIckgyf9N /o4nV1gFMcMOmC2+Ufp5o2 X-Received: by 2002:a17:902:7886:b0:2b2:5042:dd18 with SMTP id d9443c01a7336-2b2d594152bmr20095815ad.3.1775813896134; Fri, 10 Apr 2026 02:38:16 -0700 (PDT) Received: from localhost ([2402:7500:488:8797:fb65:d6e4:65a8:4bfd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2d843c5c2sm14941245ad.12.2026.04.10.02.38.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 02:38:15 -0700 (PDT) From: Jack Wu X-Google-Original-From: Jack Wu To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] platform/x86: dell-dw5826e: Add reset driver for DW5826e Date: Fri, 10 Apr 2026 17:37:52 +0800 Message-Id: <20260410093752.298067-1-jackbb_wu@compal.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If the DW5826e is in a frozen state and unable to receive USB commands, this driver provides a method for the user to reset the DW5826e via ACPI. E.g: echo 1 > /sys/bus/platform/devices/PALC0001\:00/pldr Signed-off-by: Jack Wu --- v2: - Remove extra empty line - Add missing includes and Remove unnecessary includes, sort includes alphabetically - Remove noisy dev_info() - Handle obj->type != ACPI_TYPE_BUFFER as error with proper return code - Replace miscdevice/file_operations with sysfs attribute (DEVICE_ATTR_WO) to reduce boilerplate - Propagate trigger_palc_pldr() return code to userspace - Convert from acpi_driver to platform_driver --- --- drivers/platform/x86/dell/Kconfig | 6 ++ drivers/platform/x86/dell/Makefile | 2 + .../platform/x86/dell/dell-dw5826e-reset.c | 83 +++++++++++++++++++ 3 files changed, 91 insertions(+) create mode 100644 drivers/platform/x86/dell/dell-dw5826e-reset.c diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig index 738c108c2163..c4540c837a88 100644 --- a/drivers/platform/x86/dell/Kconfig +++ b/drivers/platform/x86/dell/Kconfig @@ -276,4 +276,10 @@ config DELL_WMI_SYSMAN To compile this driver as a module, choose M here: the module will be called dell-wmi-sysman. +config DELL_DW5826E_RESET + tristate "Dell DW5826e PLDR reset support" + default m + depends on ACPI + help + This adds support for the Dell DW5826e PLDR reset via ACPI endif # X86_PLATFORM_DRIVERS_DELL diff --git a/drivers/platform/x86/dell/Makefile b/drivers/platform/x86/dell/Makefile index c7501c25e627..8150283cfd1d 100644 --- a/drivers/platform/x86/dell/Makefile +++ b/drivers/platform/x86/dell/Makefile @@ -28,3 +28,5 @@ obj-$(CONFIG_DELL_WMI_DESCRIPTOR) += dell-wmi-descriptor.o obj-$(CONFIG_DELL_WMI_DDV) += dell-wmi-ddv.o obj-$(CONFIG_DELL_WMI_LED) += dell-wmi-led.o obj-$(CONFIG_DELL_WMI_SYSMAN) += dell-wmi-sysman/ +obj-$(CONFIG_DELL_DW5826E_RESET) += dell-dw5826e-reset.o + diff --git a/drivers/platform/x86/dell/dell-dw5826e-reset.c b/drivers/platform/x86/dell/dell-dw5826e-reset.c new file mode 100644 index 000000000000..52002578ed68 --- /dev/null +++ b/drivers/platform/x86/dell/dell-dw5826e-reset.c @@ -0,0 +1,83 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * dell-dw5826e-reset.c - Dell DW5826e reset driver + * + * Copyright (C) 2026 Jackbb Wu + */ + +#include +#include +#include +#include +#include + +static guid_t palc_dsm_guid = + GUID_INIT(0x5a1a4bba, 0x8006, 0x487e, 0xbe, 0x0a, 0xac, 0xf5, 0xd8, 0xfd, 0xfe, 0x59); + +static int trigger_palc_pldr(struct device *dev, acpi_handle handle) +{ + union acpi_object *obj; + int ret = 0; + + obj = acpi_evaluate_dsm(handle, &palc_dsm_guid, 1, 1, NULL); + if (!obj) { + dev_err(dev, "Failed to evaluate _DSM\n"); + return -EIO; + } + + if (obj->type != ACPI_TYPE_BUFFER) { + dev_err(dev, "Unexpected _DSM return type: %d\n", obj->type); + ret = -EINVAL; + } + + ACPI_FREE(obj); + return ret; +} + +static ssize_t pldr_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + acpi_handle handle = ACPI_HANDLE(dev); + int ret; + + ret = trigger_palc_pldr(dev, handle); + if (ret) + return ret; + + return count; +} +static DEVICE_ATTR_WO(pldr); + +static struct attribute *palc_attrs[] = { + &dev_attr_pldr.attr, + NULL +}; +ATTRIBUTE_GROUPS(palc); + +static int palc_probe(struct platform_device *pdev) +{ + if (!ACPI_HANDLE(&pdev->dev)) + return -ENODEV; + + return 0; +} + +static const struct acpi_device_id palc_acpi_ids[] = { + { "PALC0001", 0 }, + { } +}; +MODULE_DEVICE_TABLE(acpi, palc_acpi_ids); + +static struct platform_driver palc_driver = { + .driver = { + .name = "dell-dw5826e-reset", + .acpi_match_table = palc_acpi_ids, + .dev_groups = palc_groups, + }, + .probe = palc_probe, +}; +module_platform_driver(palc_driver); + +MODULE_DESCRIPTION("Dell DW5826e reset driver"); +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("JackBB Wu"); -- 2.34.1