From: Jakub Kicinski <kuba@kernel.org>
To: Cao Ruichuang <create0818@163.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Stefano Garzarella <stefano.garzarella@gmail.com>,
Simon Horman <horms@kernel.org>,
Bobby Eshleman <bobbyeshleman@meta.com>,
virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] selftests: vsock: avoid races creating Unix socket paths
Date: Fri, 10 Apr 2026 13:47:33 -0700 [thread overview]
Message-ID: <20260410134733.1c10a183@kernel.org> (raw)
In-Reply-To: <177581562073.13887.468247298173578281@163.com>
On Fri, 10 Apr 2026 18:07:00 +0800 Cao Ruichuang wrote:
> vmtest.sh currently uses mktemp -u to precompute Unix socket paths for the
> namespace bridge helpers. That only returns an unused pathname and leaves a
> time-of-check/time-of-use window before socat binds or connects to it.
>
> Create a private temporary directory with mktemp -d and place the
> socket path inside it instead. This removes the pathname race while
> keeping cleanup straightforward.
And you actually run into this as a real problem?
How do you repro the failure?
Basic netdev rules:
- don't post new version of patches in reply to the old ones
- no more than 1 posting in a 24h period
prev parent reply other threads:[~2026-04-10 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-05 19:57 [PATCH 1/1] selftests: vsock: avoid mktemp -u for Unix socket paths CaoRuichuang
2026-04-09 17:00 ` Simon Horman
2026-04-10 3:52 ` [PATCH v2] selftests: vsock: avoid races creating " Cao Ruichuang
2026-04-10 8:33 ` Stefano Garzarella
2026-04-10 9:06 ` Stefano Garzarella
2026-04-10 10:05 ` Cao Ruichuang
2026-04-10 10:07 ` [PATCH v3] " Cao Ruichuang
2026-04-10 20:47 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410134733.1c10a183@kernel.org \
--to=kuba@kernel.org \
--cc=bobbyeshleman@meta.com \
--cc=create0818@163.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=stefano.garzarella@gmail.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox