From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E553D29E0FD for ; Fri, 10 Apr 2026 15:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775835646; cv=none; b=t6Mn18L3N8Z5JJTeePYo2Fl2MvZNxsBEqwAQJawIdZvccm3Z+jAE1FfMvQwI8lRnVnt6ElVF/RHYRBsC2xNvxqmNeYC+PEez5+/pmYLytGZrA27aGIxHf7ecZWFxs0sUT62VKDQND94SrHEQzc9R3d0Q6XI5b3z/Y95FAs0TcWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775835646; c=relaxed/simple; bh=WD2kItpaljpKgAUiK0BAZZLxKk2fz6dofRlZDFLW91k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EKgev3AEsHII9XGtV8Kiw7MelkD2rp6hflVbPcpBqQCsHyEe4zkCCdCkN5Z11mutWkOViDQtyhIYpHnEteo+4Zbup59uO6hTfBDl8WoVQ1PVbvWz6rjBzmkDNKhtXJS43lLbaNckqAKgg9SXFnzPgsIgPf39Vwc7RZvH7TRlLgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FzlL0uh+; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FzlL0uh+" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82418b0178cso1181536b3a.1 for ; Fri, 10 Apr 2026 08:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775835643; x=1776440443; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=swiKP2dfJ7x8QYcvk/9GMzyobZM35ErBhsi1fgDGHl8=; b=FzlL0uh+QG8PbEEfWZCpzqaG2uY2TaAhpqBYKI+LqfJ0CrW3caowuDB8f7vumeqtm1 OXTgQ4iHWaUfm/DI8q5QMN32Oqc8PNU9E+Iv/0DqujAHLqpQLmdHSZ7cpvQ6GD8Gz5BM KMpvN/25w5G7a+0Fd078YlpXnyLHeEP8cB9yNjXCOPEbHbwY1rWsSN6SL7bKPvB9oLDC D3h5Fxj2w7EbUzBcFV/GEoZsnIUw6TEfJv4rJHzREI0AGyLV8ts6UL4rHTawcGrjGhID DDZmrSYltc7ZaYU3D1alpaOIrm9Bi18P4g53LUIMngGOmZf6cL5Z4YRX4LJ2krDbV4wv phaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775835643; x=1776440443; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=swiKP2dfJ7x8QYcvk/9GMzyobZM35ErBhsi1fgDGHl8=; b=HC8jqVlX6CKqnKHMd4dwMcTBY/HTKPwp17bZEm0QVlQGFp8TqfmSAi6SBEJ0ugb/Qe cEPtD1mAwbGik5fmRzNM4/cK8cOq0XyQ+FbFY+OKJcDapOCJhnzWkjMoxFzS+yNdKvDR wDvWdA2QritZ8lzavVDvELpV5igDpX2Y8iPPrqqViqwN1l7RiSgRVYxEbm/kbhSBLZ0D jM+4havcM350JZd0kAThRu58pYIUXh6NosPzmlLZgsf+zqktr6CTHQphs+EeHKaR+yT/ uw1UTgr9YFwJ18MLmUc6SP2nzYeDU4DBhjrgntHyl2QnzjSVL/+33piXzKTIzK108GsA zoWg== X-Forwarded-Encrypted: i=1; AJvYcCV5+L56ysA7hfV6bLX9Hph1U6sdXnZLV0HTL+dyaLalGg2OfEuRhLi1jl//a6zcAweZ3UG7OjNslXWg+N8=@vger.kernel.org X-Gm-Message-State: AOJu0YxUW0t19vLpjal50OhTwGK5mK84DLahcYu+Dnh7a3NDrOcujMZb VICgrkXGWwT17sFLElZyNjkpe6+Byscuq05KXAISW/RgfK3h53q/65Lj X-Gm-Gg: AeBDieuh3G40Ck+q3rJcxF3wlv3QRM3227LRqEpsHj+KYkPbVi4VO/Q3Z48G/CxYK8/ kNBGQb+U/fU95kDOCSXb+Dq0+5c7WwA4ygPnGeTeYbyVvYMswosXi7yknCgMVYMiCScBnFHYWZs 6zivQUtCNd4TLZ5VlYYT9fuCeVS4ng5j+Du1V9FkPXN7FU+Um4W9ibsumeo+LzzJ/wJIo44BM1z 7drpfNZjmixLfyrZiFTeNhcOa+1DNt6ekzusVrVFH+zQZUUA0jGIqFU4dTwm495u/8mDsGMjjQh RcLDYIBVB5UkmRBvLMoxB+XbpJePG7boDh5QOncDqMRUTrn1C5BpARFeki6BX5kf2XAdP7g808e RC4cxzVGz3/dLEm+yT+ntqfHVkGa50V0Rp8jLeRJbZqIIcziyLw0fFd+kluqY5KmiuTNYA3Ta6s NE4uEffZZUZC5Jbg1+FVUIUFx6/NGRVQH1/0iizP2xjebFkEd9F4GXKDBvedTksuFPic41XTRm3 NnHL7Zvd2sm X-Received: by 2002:a05:6a20:2588:b0:39e:f994:f698 with SMTP id adf61e73a8af0-39fe403e6demr4394929637.48.1775835643205; Fri, 10 Apr 2026 08:40:43 -0700 (PDT) Received: from SLSGDTSWING002.tail0ac356.ts.net ([129.126.109.177]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7921a3e6d2sm2678599a12.32.2026.04.10.08.40.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 08:40:42 -0700 (PDT) From: Weiming Shi To: Vinicius Costa Gomes , Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Vladimir Oltean , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Xiang Mei , Weiming Shi Subject: [PATCH net v2] net/sched: taprio: fix NULL pointer dereference in class dump Date: Fri, 10 Apr 2026 23:39:03 +0800 Message-ID: <20260410153902.955227-2-bestswngs@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a TAPRIO child qdisc is deleted via RTM_DELQDISC, taprio_graft() is called with new == NULL and stores NULL into q->qdiscs[cl - 1]. Subsequent RTM_GETTCLASS dump operations walk all classes via taprio_walk() and call taprio_dump_class(), which calls taprio_leaf() returning the NULL pointer, then dereferences it to read child->handle, causing a kernel NULL pointer dereference. The bug is reachable with namespace-scoped CAP_NET_ADMIN on any kernel with CONFIG_NET_SCH_TAPRIO enabled. On systems with unprivileged user namespaces enabled, an unprivileged local user can trigger a kernel panic by creating a taprio qdisc inside a new network namespace, grafting an explicit child qdisc, deleting it, and requesting a class dump. The RTM_GETTCLASS dump itself requires no capability. Oops: general protection fault, probably for non-canonical address 0xdffffc0000000007: 0000 [#1] SMP KASAN NOPTI KASAN: null-ptr-deref in range [0x0000000000000038-0x000000000000003f] RIP: 0010:taprio_dump_class (net/sched/sch_taprio.c:2475) Call Trace: tc_fill_tclass (net/sched/sch_api.c:1966) qdisc_class_dump (net/sched/sch_api.c:2329) taprio_walk (net/sched/sch_taprio.c:2510) tc_dump_tclass_qdisc (net/sched/sch_api.c:2353) tc_dump_tclass_root (net/sched/sch_api.c:2370) tc_dump_tclass (net/sched/sch_api.c:2431) rtnl_dumpit (net/core/rtnetlink.c:6827) netlink_dump (net/netlink/af_netlink.c:2325) rtnetlink_rcv_msg (net/core/rtnetlink.c:6927) netlink_rcv_skb (net/netlink/af_netlink.c:2550) Fix this by substituting &noop_qdisc when new is NULL in taprio_graft(), following the same pattern used by multiq_graft() and prio_graft(). This ensures q->qdiscs[] slots are never NULL, making control-plane dump paths safe without requiring individual NULL checks. Also update the data-plane NULL guards in taprio_enqueue() and taprio_dequeue_from_txq() to check for &noop_qdisc, so that packets are still dropped cleanly without inflating qlen/backlog counters. Fixes: 665338b2a7a0 ("net/sched: taprio: dump class stats for the actual q->qdiscs[]") Reported-by: Xiang Mei Signed-off-by: Weiming Shi --- v2: - Update NULL checks in taprio_enqueue() and taprio_dequeue_from_txq() to test for &noop_qdisc instead of NULL, preventing qlen/backlog counter inflation when noop_qdisc drops packets (Sashiko) --- net/sched/sch_taprio.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index f721c03514f60..XXXXXXXXX 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -634,7 +634,7 @@ static int taprio_enqueue(struct sk_buff *skb, struct Qdisc *sch, child = q->qdiscs[queue]; - if (unlikely(!child)) + if (unlikely(child == &noop_qdisc)) return qdisc_drop(skb, sch, to_free); if (taprio_skb_exceeds_queue_max_sdu(sch, skb)) { @@ -717,7 +717,7 @@ static struct sk_buff *taprio_dequeue_from_txq(struct Qdisc *sch, int txq, int prio; int len; u8 tc; - if (unlikely(!child)) + if (unlikely(child == &noop_qdisc)) return NULL; if (TXTIME_ASSIST_IS_ENABLED(q->flags)) @@ -2183,6 +2183,9 @@ static int taprio_graft(struct Qdisc *sch, unsigned long cl, if (!dev_queue) return -EINVAL; + if (!new) + new = &noop_qdisc; + if (dev->flags & IFF_UP) dev_deactivate(dev); @@ -2196,14 +2199,14 @@ static int taprio_graft(struct Qdisc *sch, unsigned long cl, *old = q->qdiscs[cl - 1]; if (FULL_OFFLOAD_IS_ENABLED(q->flags)) { WARN_ON_ONCE(dev_graft_qdisc(dev_queue, new) != *old); - if (new) + if (new != &noop_qdisc) qdisc_refcount_inc(new); if (*old) qdisc_put(*old); } q->qdiscs[cl - 1] = new; - if (new) + if (new != &noop_qdisc) new->flags |= TCQ_F_ONETXQUEUE | TCQ_F_NOPARENT; if (dev->flags & IFF_UP) -- 2.43.0