From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E23B230BE9 for ; Fri, 10 Apr 2026 17:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775843156; cv=none; b=ATLfpK1Ca5lp4iUfZf21YK421xh+nyrs4GaPplyhDyMv9JOTXWHooiuhDhkegV5Zcw6jXMHjWfnhCDziicZA+vqunGJtOQV89Ha5kmN/Szinfi+jKvOqXYs3VEMNEdFZWU2oWnUUgj37qP6/fNYRzzlJR250KGMBPyNraKUiYCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775843156; c=relaxed/simple; bh=4POTLe2NUK/RskaF0YwKuSKGK3FuzUeSHhB4/BfgEPM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jKkU2KGrQew52vj8F17hKU+N8jgeE1/SNBuU2XNgfBNvfE+MfKv9xcJodMWnUprxjr7/HD4iXKmVqp5nhalaiGGZkhNUl18bEa9cAgDg8EymMlJ5sE6fs5dx8RUqK1FZGEADcY+5PAjpCLIZGy9Jfj2msZHfKz3ltFAHNRyFCss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=RX33QyRI; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="RX33QyRI" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-50d87610513so21556371cf.3 for ; Fri, 10 Apr 2026 10:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1775843154; x=1776447954; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c9JulbfzTz2xBI8tkB9/GJvrbWgX7pghyVXkTDeXqeU=; b=RX33QyRII7oYpjzrkcWcLLU9yrmRuvlbbmnyaE/jjaX1ZoGTYxG9AklJwLjTnyWXVn I6dO+IFF+ZKAR6tVoqwKGyXHqZh3ShVjn+LP1dmLaBQntaoWTpsCBXPyUOIS3pS1B7MU oM3scHyDMWelbDhKZPEQzpC3tIYHkeLDFFh4MyqdUthXuLRP3U1aRhxZMharhdHUUE51 OlD/B2mmYh+RVbCgvPEfMQiVA8vmiKs9zKR2fpKj0SEzdRh9E36+cIvb/kvcN/Sqhwjh 5FRkfHvmTBC3rmtiMd+iMYuBTR2LBnS6FHe4M3b4q5rdJ4et5dT9rkRVzAmyTSXeikeh uBxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775843154; x=1776447954; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c9JulbfzTz2xBI8tkB9/GJvrbWgX7pghyVXkTDeXqeU=; b=LoCCBpCOBGp4IDNBOZoSvL97NxbVkvDPi3+vbVUsyVw8z/aX5cWd+MGslYoFIUHit3 nE+Hvvcu+r9YJlpVSHYzt5GErEskoW+IOoGR65WW4kWDeOGU00SWioC1ol610uuq656k IoHsJULtNqiuw8mcAJGaZjikHFYj2x6IcQueI6IxfDI8uPcZH0sKyb2llSFFqNgR85KP xNmz03ouwbiovrHFYrjjQh09a3zkA3bGckVvOmZXm3VjCerG/YgzhtFNoDW2/bSlVsUW 6QV1XNb8zJew5UAq9N3IkJXb0P7Sx9bD3AVKQ8YQ4JAASFqNknsz9taZ9bxRmFXEgVhz fkLw== X-Forwarded-Encrypted: i=1; AJvYcCWy/RKdoisLFXhshdraVNg6nNqDShMWjwwZK9ij0wc33Np2haRGaOQwv/Sp5oR2kMjQV9Edjml8sX7M2yE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxg3F3cbVCSFcKWLNR/irCIcUXcV27Cvec6tXjYOGvdqyOt3OY3 pAtMRuUPVt0wvdiw9+h/H3OVQd/u/Oa90Je4hKlcG7mhKt5p90dxy/N7YTUmhUNI5wc= X-Gm-Gg: AeBDies2F/xZYbzsZg5EWMhvkftOzqyH/89PhRUnKuND/VHMK4rwm9o/Lq1SqhAoLa9 my//YjDiv2A3ShzgCKpTVryYrBfmJ6NnlpZdejgV3XZfWVrMJ3kc6tDTwKPSVj3F1+wZlM17WTh nYvWvMGAAXLaA4qLUycSSbmpo/dzICQbFwrzG5Hg3kaFmiZtw0u5yILXjf68zaHfeyWvjibEsjW PruEEbvgNJX89/TZterFj+oS2j91g5SKHb9jNDvLdJ5ijNXbLDHnl6TdnLtnT13jmR8M3FKr5Nl 9F2bL1jd5Fm2R+zSQQb+MM/RMhyYWaKbeYB4eLi3f6d20O134KdiHL+YrgfIdxAxQrLIFYJUxSi VahKaSEF9BfJ0BK28D3PZWasPyGtz0T/ayWQDn9jlzAqTCAJnyPXDt/WXfYWuPU7Ge9DIX5NeEn LPLL9IkGG3c9qGnJlc3B00HG/fUGAKIAYV6fO7SSpJQtSj4nUQVR8f03XDo6ojL1r8oy6mZw== X-Received: by 2002:a05:622a:998:b0:50d:830a:4213 with SMTP id d75a77b69052e-50dd5b2ef3dmr67163341cf.6.1775843154537; Fri, 10 Apr 2026 10:45:54 -0700 (PDT) Received: from ziepe.ca (mctnnbsa70w-159-2-73-22.dhcp-dynamic.fibreop.nb.bellaliant.net. [159.2.73.22]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50dd5607b83sm27630251cf.24.2026.04.10.10.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 10:45:54 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wBFvV-0000000FJ94-0MqZ; Fri, 10 Apr 2026 14:45:53 -0300 Date: Fri, 10 Apr 2026 14:45:53 -0300 From: Jason Gunthorpe To: Mostafa Saleh Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, robin.murphy@arm.com, m.szyprowski@samsung.com, will@kernel.org, maz@kernel.org, suzuki.poulose@arm.com, catalin.marinas@arm.com, jiri@resnulli.us, aneesh.kumar@kernel.org Subject: Re: [RFC PATCH v3 2/5] dma-mapping: Move encryption in __dma_direct_free_pages() Message-ID: <20260410174553.GD2551565@ziepe.ca> References: <20260408194750.2280873-1-smostafa@google.com> <20260408194750.2280873-3-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408194750.2280873-3-smostafa@google.com> On Wed, Apr 08, 2026 at 07:47:39PM +0000, Mostafa Saleh wrote: > In the next patches, we will need to avoid encrypting memory allocated > from SWIOTLB, so instead of calling dma_set_encrypted() before > __dma_direct_free_pages(), call it inside, conditional on the memory > state passed to the function. > > Signed-off-by: Mostafa Saleh > --- > kernel/dma/direct.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > index 6efb5973fbd3..ce74f213ec40 100644 > --- a/kernel/dma/direct.c > +++ b/kernel/dma/direct.c > @@ -97,8 +97,11 @@ static int dma_set_encrypted(struct device *dev, void *vaddr, size_t size) > } > > static void __dma_direct_free_pages(struct device *dev, struct page *page, > - size_t size) > + size_t size, bool encrypt) > { This feels like it would be nicer if it could be the swiotlb_page_state instead of a bool, maybe the enum needs a different name. Jason