From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A9FE3E276B for ; Fri, 10 Apr 2026 18:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775844611; cv=none; b=LqGMRPutLcV5ft8I+pgZ5kn6yYoMieegdz+UlgfTnbW5b7uXr7LAkd/BNNVFOm7ud+T7XjNxgtins5aG1yjicQSuZt0wPshL2suRMx/6WqAlYldYTldeSgh9zRC3g2nNhQAI0pu/urXPqipkkREwJgyMmFs+auSZtrjjBEY35sE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775844611; c=relaxed/simple; bh=RiAMebESLDrerCCB8z1EG9HuC2bXXUuvqFJqYdbBxEw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gu7syox5GsK0bfBYz/m9OhDobkj70FR8XkKbECE5+CueX9eF2ITjjJXMWCFzHS5YOMpz4Ao7XkEhDFGI+fD4metZQKtdP3IrhXpR0zxBW9KBoXrKDfhL4SBzX0zp+Fk8/kJt2x2K/L2MKGjX6tIoOUAlaXHYRu3DtA3Tn9930I0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=AeFrUdlk; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="AeFrUdlk" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-89cc797547fso28855486d6.2 for ; Fri, 10 Apr 2026 11:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1775844607; x=1776449407; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6qcUdSYVXIPHlYutMHlgKYsq8bY8kP9mulymhE30xKo=; b=AeFrUdlkTUWparOrp/LLvrX2gTzgnnJjKnTLtA8SoBZvRgJUICoIyCLNsCA5nl7qrt 2oY/fQIQj1pczKtCbLO8Q5J4jUjcj75aXnD6tH8xKPL14AgKh+MF8JJj5clQE9E238bx CWtDoGD47gzmF/HKFJyb6F9R5tjF+Cy1ZE/gMQpP0m19NKkZs14WlGN4I7QwE8zFiiEj 1hiILgRugrHGsa7XP4MxUkbYgFFkxHo5cZBfX3foX3uhWFXmgzmuQ6fSgpbU9qX6wRHp veTcmZGl73SVPQEeHICJIXXuFJ6/8ZYL7tOHDfGB9mi7MCwqF+xTXlqWQiIphlVzyTkH F95A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775844607; x=1776449407; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6qcUdSYVXIPHlYutMHlgKYsq8bY8kP9mulymhE30xKo=; b=qG4u2heQuYjWm2pBeGDNSPZ3t/tioviP9Jib9erk0TAQlDwomGNSDEUafNP7fi+Ng3 knAQAl/vld2iJTxBWJ/pLPNm5sU8l6z9hu4TGK+lcgPMwvBbuAJ1ZUu8Xe/mk8a7dleY EKPAt8SyoGhddTUNe+04CeEYcfu0DX0AadnfP8pernXdKG4q16VfRBweX4xJivz+MEwL Z8ZAQ13cvu46cV1ZJfQwk6QkkTBFu+M1S31R4bH8BpVQDIVJOlzOSva9ZLiPp2IhH8Nt nZKsRmMw0n6y8YExqIR0xWWnwSlwth84de/EejL0aM0ZLyvOGoGl1Xq6pzh++/tLUMST CClQ== X-Gm-Message-State: AOJu0YzAMF172JWVqYbxz8CQI9L6HetXpxR6d/0uKlpLPFkalNhumzS/ fbqmaoEeGP+FHoOGF8FKh1/qY3xMFiRzL5xzxsFZ+I0fZRKg30oykqg73H8LOoYXFcM= X-Gm-Gg: AeBDieupnh/kq/Px0kmjWNacrDBbPkYPtznSD2/y5KsKmTkGRRj1+7XF4GJxF34Ie8j T6jwNdMyt+9xk+FyyKFnp85b+pW26vuhBQ8RyzT5hJj9StcRZ54W464YlYqfWZWjEQWT17bjW9j koOKubY1vucAK9B3kIwxlNlrTr2Hauf15sEzPxYW9Qt/YIxxdFlTUJdsXdJ3FkKQp3knbWPXAcv Zt8622+Uk2O+sMU5VOOvoHbXiT9diJFGIDBXfz0v1yW4o64zs4FOhUBI9ZHZEy80vTg1spYMOtY oeiRXELU82kC4n2nsYASNV4/UIGKm4HgBzCVfR02oLEk09j9+AcK97O4s3GzGDVKviHAlRzXLty fQ8/Se3W9KlrXmnBRvwBaAN+LsltiCcBM6vzevQ4MYBmhzNzr9olgDBTJaDGyfZeEvY8AATaQNU 9mLN3FUXoaIQxU1xMHUUk9haWwd4LkSprmGFULCNeUXk1zQuCTHFjluyKdQo3EwKiWzkUdwQ== X-Received: by 2002:a05:6214:311e:b0:8aa:7239:b027 with SMTP id 6a1803df08f44-8ac860eb50dmr69122416d6.14.1775844607550; Fri, 10 Apr 2026 11:10:07 -0700 (PDT) Received: from ziepe.ca (mctnnbsa70w-159-2-73-22.dhcp-dynamic.fibreop.nb.bellaliant.net. [159.2.73.22]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac84a4355esm29526906d6.19.2026.04.10.11.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 11:10:07 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wBGIw-0000000FPVf-23hv; Fri, 10 Apr 2026 15:10:06 -0300 Date: Fri, 10 Apr 2026 15:10:06 -0300 From: Jason Gunthorpe To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, akrowiak@linux.ibm.com, alex@shazbot.org, linux-s390@vger.kernel.org Subject: Re: [PATCH] VFIO: remove dead notifier code Message-ID: <20260410181006.GF2551565@ziepe.ca> References: <20260407175934.1602711-1-pbonzini@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407175934.1602711-1-pbonzini@redhat.com> On Tue, Apr 07, 2026 at 07:59:34PM +0200, Paolo Bonzini wrote: > group->notifier is dead code. VFIO initializes it and checks it for emptiness on > teardown, but nobody ever registers on it or triggers it. > > Signed-off-by: Paolo Bonzini > --- > Documentation/arch/s390/vfio-ap.rst | 18 ++++++------------ > drivers/vfio/group.c | 3 --- > drivers/vfio/vfio.h | 1 - > drivers/vfio/vfio_iommu_type1.c | 1 - > 4 files changed, 6 insertions(+), 17 deletions(-) Fixes: 421cfe6596f6 ("vfio: remove VFIO_GROUP_NOTIFY_SET_KVM") ? Reviewed-by: Jason Gunthorpe Jason