From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47AB836C5BB for ; Fri, 10 Apr 2026 20:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775851543; cv=none; b=AT51NELRhwuJ/pbZZ6SLct1C6ZRt0mk+1tGu1FiBT6DIX8mOadQix8B+HufdqZyITzO4E0WR1F+CENPRPpQSDz8wC1xJbtSq9tmDZt8fT4JOCwBOvk6NsNFjAaK9o4xj/iP8FvncyRt3XkPXIZz1Tj42AwMnW/PB5v9iCnW1t5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775851543; c=relaxed/simple; bh=fk2FeTa5sC5C/JCX1a5sNfgQLpavS6OsCw5bkUgeGFg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SYLs5H1JHgCt4/SmUsiw30mRVWDdRninyAluCYw5dtEFQAmo8OHdXqfE0TbfnU1blqyCyqMhxCu4beeZMym5DMAVfy4gYBzVUA+Co7mxb8aPQsvLp+fW/WY/TotCSswHwIM5rePQqIv9gFq3AtJyzr6ghu2LfJpfCPWdmnn1RIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=oIMRo0uq; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="oIMRo0uq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775851541; x=1807387541; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fk2FeTa5sC5C/JCX1a5sNfgQLpavS6OsCw5bkUgeGFg=; b=oIMRo0uq/NMclgRGMICSSYasEEUigO7B+zLhn2KQAwS6qz7PxyoTB/PS dH3Vlw54pBPF3ssh0kgp87xcVV/A3w+O6GPnyX7HHwPctg0wR0OvnTlvc a8mIYectfZJN2XFTjlgBKh8JNcXFzJVCr7HaN5pxg01L4d5gxl7B5S7Pz FJj7GCqkVWRNPOGxwpFs98StTKvyeLJ5tnFIwwc2AU0aDCge31aqqCNxG aQLYVuCEcYzPAJjmamiETwAg8aq1I38OtI8yP+C8Xhj2OEG5bhiJemELE q/j0XNp/25IrG2P8IzJzd2HVc7xn6WXXyqCQRuD2XqQ3lJ4Rr0pwyy4FQ A==; X-CSE-ConnectionGUID: 2xvDKZ8cTG2yqnpsVp+7Xg== X-CSE-MsgGUID: WIV3Fe5dSEKFuPoOtXWwFA== X-IronPort-AV: E=McAfee;i="6800,10657,11755"; a="76898069" X-IronPort-AV: E=Sophos;i="6.23,172,1770624000"; d="scan'208";a="76898069" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2026 13:05:40 -0700 X-CSE-ConnectionGUID: SMvz9TcQSoq3RVSDU8qzyg== X-CSE-MsgGUID: kM7dIBIySS6kCOHsD39fdA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,172,1770624000"; d="scan'208";a="228155006" Received: from khuang2-desk.gar.corp.intel.com (HELO agluck-desk3.intel.com) ([10.124.221.106]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2026 13:05:39 -0700 From: Tony Luck To: Fenghua Yu , Reinette Chatre , Maciej Wieczor-Retman , Peter Newman , James Morse , Babu Moger , Drew Fustini , Dave Martin , Chen Yu , David E Box , x86@kernel.org Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, patches@lists.linux.dev, Tony Luck Subject: [RFC PATCH v5 2/7] fs/resctrl: Add interface to disable a monitor event Date: Fri, 10 Apr 2026 13:05:27 -0700 Message-ID: <20260410200532.58602-3-tony.luck@intel.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260410200532.58602-1-tony.luck@intel.com> References: <20260410200532.58602-1-tony.luck@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for re-running AET enumeration on every mount, AET code must be able to disable events on unmount so the next mount starts from a clean slate. Add resctrl_disable_mon_event(eventid) which clears the enabled flag for the given event. Add kerneldoc comments to describe limitations on when events may be enabled or disabled. Signed-off-by: Tony Luck --- include/linux/resctrl.h | 34 ++++++++++++++++++++++++++++++++++ fs/resctrl/monitor.c | 12 ++++++++++++ 2 files changed, 46 insertions(+) diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h index 006e57fd7ca5..a8338656f836 100644 --- a/include/linux/resctrl.h +++ b/include/linux/resctrl.h @@ -414,9 +414,43 @@ u32 resctrl_arch_get_num_closid(struct rdt_resource *r); u32 resctrl_arch_system_num_rmid_idx(void); int resctrl_arch_update_domains(struct rdt_resource *r, u32 closid); +/** + * resctrl_enable_mon_event() - Enable monitoring event + * @eventid: ID of the event + * @any_cpu: True if event data can be read from any CPU. + * @binary_bits:Number of binary places of the fixed-point value expected to + * back a floating point event. Can only be set for floating point + * events. + * @arch_priv: Architecture private data associated with event. Passed back to + * architecture when reading the event via resctrl_arch_rmid_read(). + * + * The file system must not be mounted when enabling an event. + * + * Events that require per-domain (architectural and/or filesystem) state must + * be enabled before the domain structures are allocated. For example before + * CPU hotplug callbacks that allocate domain structures are registered. If the + * architecture discovers a resource after initialization it should enable + * events needing per-domain state before any domain structure allocation which + * should be coordinated with the CPU hotplug callbacks. + * + * Return: + * true if event was successfully enabled, false otherwise. + */ bool resctrl_enable_mon_event(enum resctrl_event_id eventid, bool any_cpu, unsigned int binary_bits, void *arch_priv); +/** + * resctrl_disable_mon_event() - Disable monitoring event + * @eventid: ID of the event + * + * The file system must not be mounted when disabling an event. + * + * Events that require per-domain (architectural and/or filesystem) state + * will require additional cleanup which should be coordinated with the CPU + * hotplug callbacks. + */ +void resctrl_disable_mon_event(enum resctrl_event_id eventid); + bool resctrl_is_mon_event_enabled(enum resctrl_event_id eventid); bool resctrl_arch_is_evt_configurable(enum resctrl_event_id evt); diff --git a/fs/resctrl/monitor.c b/fs/resctrl/monitor.c index 49f3f6b846b2..0def41c26edc 100644 --- a/fs/resctrl/monitor.c +++ b/fs/resctrl/monitor.c @@ -1010,6 +1010,18 @@ bool resctrl_enable_mon_event(enum resctrl_event_id eventid, bool any_cpu, return true; } +void resctrl_disable_mon_event(enum resctrl_event_id eventid) +{ + if (WARN_ON_ONCE(eventid < QOS_FIRST_EVENT || eventid >= QOS_NUM_EVENTS)) + return; + if (!mon_event_all[eventid].enabled) { + pr_warn("Repeat disable for event %d\n", eventid); + return; + } + + mon_event_all[eventid].enabled = false; +} + bool resctrl_is_mon_event_enabled(enum resctrl_event_id eventid) { return eventid >= QOS_FIRST_EVENT && eventid < QOS_NUM_EVENTS && -- 2.53.0