From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FA702F5491 for ; Fri, 10 Apr 2026 21:28:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775856501; cv=none; b=fQbjvWAhx/do/UTEOi8ilJFGLTeXinFLRjKSsHcWlsL8ILoU0594Qdk4DOoDfYHoJ5W5zno6C0KemG1fqXFsasKiNBfl1Eknsae76AfihwHUUyGMvRXcyfDzfpk6L9bS+tfbMKiVI3cKd/Z+EbzEcJFiy8wKoRLmkfJpp0F7W6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775856501; c=relaxed/simple; bh=pSXcBB77xhUAFY02OOPxH4pvoJqH1GUCkRxHUkr5m08=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ovodRP2LgTkhGk/z8RUyk6Js2DXDrLu5kGCRCk1geWZ7eDSFekGMoUf6viX6yvLquTBM1GCyGRz0J1Ta2BCQNnvqHEp1Q6LVN+zzCHZgpr3rN+B8W6EMlTUfaRfir7WDVfe8SF2OSPIPQE5W0jUllIMSXQ/nWI2IF/vgHHmV9Fk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bQrCGzRv; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bQrCGzRv" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-43cfe71e5d3so1660551f8f.0 for ; Fri, 10 Apr 2026 14:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775856499; x=1776461299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=h4zwVlERIznTZv83IMyyoL1Es2Fk7kS1w5EdxpsFxhE=; b=bQrCGzRvf72Posxytg2aPu5T4IO762EC6o263booG0qAQFVCQ4+7cPEWshr7PlWsSv rz4nByQrftd6bk47fL3CbHDm1R+neDd+arFGXIRs+dxzjWf/28AVnJZMEtuQzHLrbfic 4ACcnjWsGb+x7CKsdrzo9diwGgFHQX0J6+dGu7PamFK/FAeL6WW+whus+i/fV7YOcrCH icmCvkE158wSNrkbRhVG5NoysMYcZOshfPioTQebyGi+jw6igXoIs/SuGbiyFTZtISJs TrNETjPjbrDQGAHWMSR//J4rvycK4PingCcnr45jS3iSaBDuVh1A+6XPGwaJYm30bYcq Vkyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775856499; x=1776461299; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h4zwVlERIznTZv83IMyyoL1Es2Fk7kS1w5EdxpsFxhE=; b=TbUg7HQskS0eLvAUlSULoA4xlpNTReIS26T8Yw++Nt3p2PVbGlo/G0ynV4GkyZy9WK g5V1R0DggQBbgV8WPYSRKRskXO2KZ4QvsccZT2lo2Qv9kepLpjA6WRRi8OpkOjSc9CcF Oz93mLV2QcGezXQKG5YTWgyuzmQLGTHz49tneIjP3EqX9A5qyrdiVUOc3LAYpWnoFcR8 MBh9jHgH+iAQ3u7N/sEvlPyvv5ejuFnX6LUsSu/f3YAvtmmPzbCyENpBz40BrGHRJKYQ GMtS67NztbvC0u4XQdx/dpjBYkeC678vAQfP1SFXNL8yanO6AEJBfx9Jut5rJ0YaKdBY GNyQ== X-Forwarded-Encrypted: i=1; AJvYcCV9fdttFKFqhdRdX+/r2OqJ96U3b5zskr8+eiMeCXlIniprPfmPvBp8ABqCpACbLRvVWdS5WEtxwYmNAnw=@vger.kernel.org X-Gm-Message-State: AOJu0YycqxhURaW3l1VbYqUIkxkDCsuhJvK13g6RqQ++cKI7oJKOG9Ea 7i/NMYQARS3tcdlZh5OvmUw/7qbnOSoifuRpzLmPIngFEozqVClTnbbj X-Gm-Gg: AeBDiev5SRTF/AcQ6e6G6uVGXBvcttzjnMG5P75k1NgTdjpXt9kCjm3vgXOmTZu93NV VeUes1mtV3wcSsUHsheODZfU2s23mZP4BZwrOEZyoZrWOWZNyLWAA9VeG7pLISXJ8JXK/eP2+K7 S/Ho5eOCBjJxL5Acl0zugF0p8t8Kz6oKwQ575E9p4AbimiLfH2Z/x7ARnvea0VFonsUaNJ1bsYe UktU7xjflhm/qKvkBuZwfnXhqIhzTq2iUpKNnJgEmneAXWGjhak4J7v4YlVYm4MMe4H0fKw9qyd TLgeLTu7yVpuqtC+VAm6WY1DoGvQ3CJf+OHtO2D3V+XAxDFMKp7fRUjuhDoSOh90uiYBDdT5J8t tH3fDy/ssV8N33nUrO7i2wQH0OZDZjumoMriF/fCvnkh/1Y/bp17yp2gO0dIedcjgPIz4Ft3abW du0xhmoIpBenNJ2hVQQUgveD/BYXpFQCwUO2BbcC2X22dj/ff4UQe3P6vjgMW7bWhP8qnH4w== X-Received: by 2002:a05:6000:184f:b0:43c:fed2:bb72 with SMTP id ffacd0b85a97d-43d6424c6e8mr6975505f8f.19.1775856498661; Fri, 10 Apr 2026 14:28:18 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:d356:742:cb75:6153]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e50015sm11205992f8f.27.2026.04.10.14.28.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 14:28:18 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Alain Volmat , Raphael Gallais-Pou , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH 1/3] drm/sti: remove bridge when sti_hda component_add fails Date: Fri, 10 Apr 2026 23:27:57 +0200 Message-ID: <20260410212801.413827-2-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit when component_add fails in sti_hda_probe remove drm bridge before return Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/sti/sti_hda.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index b7397827889c..1b4ba9097005 100644 --- a/drivers/gpu/drm/sti/sti_hda.c +++ b/drivers/gpu/drm/sti/sti_hda.c @@ -741,6 +741,7 @@ static int sti_hda_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct sti_hda *hda; struct resource *res; + int ret; DRM_INFO("%s\n", __func__); @@ -783,7 +784,10 @@ static int sti_hda_probe(struct platform_device *pdev) platform_set_drvdata(pdev, hda); - return component_add(&pdev->dev, &sti_hda_ops); + ret = component_add(&pdev->dev, &sti_hda_ops); + if (ret) + drm_bridge_remove(&hda->bridge); + return ret; } static void sti_hda_remove(struct platform_device *pdev) -- 2.43.0