From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1C393B27E1 for ; Fri, 10 Apr 2026 21:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775856507; cv=none; b=VTrfN7sUAchCDm8AwuWOuZCChLqVQ0z7Lo4AqkAxvdCFwJujYHsMWU0Wu8TGrFEao0fAA+bGL9hbPx4aLRxttzUYMWkSXrOmeKq8J2yHB/+Alg/YPUo4ApO3AJXnPb5hPeiOy+LRRQ46ijCcwMeerEKIAaapteGHP3OTIdVDnS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775856507; c=relaxed/simple; bh=aF6fkSP56HquW8EABnE6CY2GH0eCTlMOVL2aRbaLKis=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RYCHxayBa8ciEjJg6np2fc5aFOgV1XwOnvyp9D6gOgUUZQDINXncmVDRhT7BWFwZ09B1RdHXwU54zXLznt54Tt66CA1RBAvWL4JA9IkjzkG64P6M3iM1m17cwzp2sHTorK6XX0ms/6nq8uXtZGMt9EFyEe+wHGCjs9B2XveaV68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AIWWGNH3; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AIWWGNH3" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488aa77a06eso39819125e9.0 for ; Fri, 10 Apr 2026 14:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775856504; x=1776461304; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cMYMwDgqRuj4p13g34/4ImBkrRkjiSUEbDo/cw8pGuI=; b=AIWWGNH3j2PbD4pM++duUndrt3BT7a6xh5XbCyByWmDDipPCZvu3baMB8t4ui30SUP hmXrzzSi/pEmngFE6051B17AsgtJ3DqsofM1E+R8siaXPz4bJ0Ye6Mvz+jdcsWdEIvrh JEgW5e28hmY1ucO+/Ec/yK1qUv1tVYv8VSj8d5N6sIQZ75S30lf0FUeDgaQved4uNZ9y F8+g2E7+YRYNjzbHunrSVAf1Edjp5X/ZmyaQX0meCopn4DyNb0saBWw4/59yAOjvwsrn I5+bh+6mfihonFUCk9The6MybLm8PpsDoiCdmt3NiuO8LLon88Y25byO6/J796GNfph/ m1OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775856504; x=1776461304; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cMYMwDgqRuj4p13g34/4ImBkrRkjiSUEbDo/cw8pGuI=; b=laiFUftKj3GOP11SdZ2OYoQ5sYxacEBlOXFfZj4PrTh01OC6f1TjIy5OnGcD6pgBpK 2lgrUSOn4x/JVj4jhY1+J6Tn0CJZFEADcy8MIAHdRl3WO5FjuBRcXsLgGzkQsCnSFmb7 xCgcoJncIihJAZl98zlX1Q8PzdvN0ltuTjHXtE1ijxrr8FzgGaSGcQPKc85CsS1A7X+y ZnruT+IVrfLM5/XDI2KZPnSJnITIU7WA8DC+VLUp2ELw1FYddZdDDtMgAJ455vcYGMJa Ts636jhQKVv4j3Btve1fWpHidSMEk8Ia8m/jw3Jl2/Eu9LPCW5qYVDYDjyd0jj1DOIvH 9S4g== X-Forwarded-Encrypted: i=1; AJvYcCXrDqZ8RU8IyIBaC81nCf9ScJYq5NrpoyD0Br5+QzjvEqy+OI+HMzPC5BcMwhvJfAEb5hfyz+/xzTe6aaY=@vger.kernel.org X-Gm-Message-State: AOJu0YxESi4fXZyX6xe5ODqQo4XZ51MRnW7NiIWHtnLccfKnCZCKO+RM fytmEbZCWTUEmMurwIPIzUHwN8YELmPsJHWQFFRC4CKXzhHBte+t0fTu X-Gm-Gg: AeBDiesUFvF5YXtQrdU9GvYLZyg72ZBGrAQADvYAgin7SXrVRxXRspc1QV3dXh/2Joh 9y27xlnBB/wMkXFQvXOzNNDpXu7KlBz8s51UweFm/puGAjcLJtIPMzjLvCBnXt63vlKKCw8fxGp jcQNoCTpXAb9qxrgMEvJo0TFYxt60Txfmi1cU/2iipDSStixZiXbUMOubjCxmqJ17FbfgfwbX0p CdkKcb8xe0m8eFVbvszHZnqqykO/WkSSzZIco6qHlJmx/mbzSGbeT821RahxZEKD9KiTl0ALIdQ JOPO19prt6TYRvxjE7etT6no6Z+yT8hS4TrA8zOfWCvRC2V0DbV5rlVNjyeFy7deJ78GhurMjSA SKEL8pI940ZY2WPF7JayCMG3TjFpGigI9+PHNHaVpDqdfynlpUlLMEVlWYWgkmKLwf9UK61ITEJ ATYGIKHcEmxn6Otiq8tR5Eit9/1eXIuVg6rc6VdxWNm6hMk4fTyLELxW5Nsvs= X-Received: by 2002:a05:6000:4007:b0:43c:fbde:3101 with SMTP id ffacd0b85a97d-43d642e7cc5mr7285078f8f.41.1775856504051; Fri, 10 Apr 2026 14:28:24 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:d356:742:cb75:6153]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e50015sm11205992f8f.27.2026.04.10.14.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 14:28:23 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Peter Senna Tschudin , Ian Ray , Martyn Welch , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH 3/3] drm/bridge: megachips: remove bridge when irq request fails Date: Fri, 10 Apr 2026 23:27:59 +0200 Message-ID: <20260410212801.413827-4-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260410212801.413827-2-osama.abdelkader@gmail.com> References: <20260410212801.413827-2-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit when devm_request_threaded_irq fails in ge_b850v3_register remove drm bridge before return Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c index c9e6505cbd88..b54b6a9c9307 100644 --- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c +++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c @@ -261,6 +261,7 @@ static int ge_b850v3_register(void) { struct i2c_client *stdp4028_i2c = ge_b850v3_lvds_ptr->stdp4028_i2c; struct device *dev = &stdp4028_i2c->dev; + int ret; /* drm bridge initialization */ ge_b850v3_lvds_ptr->bridge.ops = DRM_BRIDGE_OP_DETECT | @@ -277,11 +278,14 @@ static int ge_b850v3_register(void) if (!stdp4028_i2c->irq) return 0; - return devm_request_threaded_irq(&stdp4028_i2c->dev, + ret = devm_request_threaded_irq(&stdp4028_i2c->dev, stdp4028_i2c->irq, NULL, ge_b850v3_lvds_irq_handler, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "ge-b850v3-lvds-dp", ge_b850v3_lvds_ptr); + if (ret) + drm_bridge_remove(&ge_b850v3_lvds_ptr->bridge); + return ret; } static int stdp4028_ge_b850v3_fw_probe(struct i2c_client *stdp4028_i2c) -- 2.43.0