From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Richard Cheng <icheng@nvidia.com>,
saeedm@nvidia.com, Jonathan.Cameron@huawei.com,
linux-kernel@vger.kernel.org, jan@nvidia.com, newtonl@nvidia.com,
kristinc@nvidia.com, sreddym@nvidia.com, skomatineni@nvidia.com,
vidyas@nvidia.com, kaihengf@nvidia.com, mochs@nvidia.com
Subject: Re: [PATCH] fwctl: Fix class init ordering to avoid NULL pointer dereference on device removal
Date: Fri, 10 Apr 2026 18:49:23 -0300 [thread overview]
Message-ID: <20260410214923.GC3694781@ziepe.ca> (raw)
In-Reply-To: <24bb834c-fb53-4b8a-b053-a18af2bb91cc@intel.com>
On Fri, Apr 10, 2026 at 10:16:19AM -0700, Dave Jiang wrote:
> Yeah, I'm just not coming up with a good solution for the
> driver-core. I presume that the way it's setup to allow 'sp' to be
> NULL because there are scenarios where it is NULL? Not sure if just
> allowing the kernel to OOPs on uninitialized knode is fine because
> it's a programming error or if that should be handled more
> gracefully.
The real issue is the fwctl register failed even though the class
isn't registered. I didn't try to trace down the details but I do find
that a bit surprising the driver core didn't complain during
registration
Jason
next prev parent reply other threads:[~2026-04-10 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 5:19 [PATCH] fwctl: Fix class init ordering to avoid NULL pointer dereference on device removal Richard Cheng
2026-04-09 15:09 ` Dave Jiang
2026-04-10 3:34 ` Richard Cheng
2026-04-10 17:16 ` Dave Jiang
2026-04-10 21:49 ` Jason Gunthorpe [this message]
2026-04-10 14:22 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410214923.GC3694781@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Jonathan.Cameron@huawei.com \
--cc=dave.jiang@intel.com \
--cc=icheng@nvidia.com \
--cc=jan@nvidia.com \
--cc=kaihengf@nvidia.com \
--cc=kristinc@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochs@nvidia.com \
--cc=newtonl@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=skomatineni@nvidia.com \
--cc=sreddym@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox