From: Aniket Gattani <aniketgattani@google.com>
To: mathieu.desnoyers@efficios.com
Cc: aniketgattani@google.com, bsegall@google.com, joshdon@google.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org
Subject: Re: [PATCH 1/2] sched/membarrier: Use per-CPU mutexes for targeted commands
Date: Fri, 10 Apr 2026 23:44:04 +0000 [thread overview]
Message-ID: <20260410234404.2984751-1-aniketgattani@google.com> (raw)
In-Reply-To: <addfe6a5-f773-46e8-b0f8-1699034720eb@efficios.com>
On Fri, 10 Apr 2026 08:48:35 -0400, Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> On 2026-04-09 17:22, Aniket Gattani wrote:
> [...] > static DEFINE_MUTEX(membarrier_ipi_mutex);
> > -#define SERIALIZE_IPI() guard(mutex)(&membarrier_ipi_mutex)
> > +static DEFINE_PER_CPU(struct mutex, membarrier_cpu_mutexes);
> > + I'd prefer:
>
> SERIALIZE_IPI() -> global
>
> SERIALIZE_IPI_CPU(cpu) -> per-cpu mutex
>
> Rather than the -1 trick.
>
> Thanks,
>
> Mathieu
Thanks for the review.
Agreed. I will fix this in v2 and will wait a couple of business days for anyone else to respond.
next prev parent reply other threads:[~2026-04-10 23:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 21:22 [PATCH 0/2] sched/membarrier: Use per-CPU mutexes for targeted commands Aniket Gattani
2026-04-09 21:22 ` [PATCH 1/2] " Aniket Gattani
2026-04-10 12:48 ` Mathieu Desnoyers
2026-04-10 23:44 ` Aniket Gattani [this message]
2026-04-10 12:56 ` Peter Zijlstra
2026-04-10 23:55 ` Aniket Gattani
2026-04-28 12:35 ` Peter Zijlstra
2026-04-09 21:22 ` [PATCH 2/2] selftests/membarrier: Add rseq stress test for CFS throttle interactions Aniket Gattani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410234404.2984751-1-aniketgattani@google.com \
--to=aniketgattani@google.com \
--cc=bsegall@google.com \
--cc=joshdon@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox