From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDB381E633C for ; Sat, 11 Apr 2026 11:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775908185; cv=none; b=b2hufOd9GCxMzgtbHTMRBGmSTFtnJudzIBUZNAlIyYVAEbZ4hIkzooMXouVbcrrTLYq4KeXeLcGf5k/Ac97rUcsIAb9U7itqRCRMOB8tWLbLwBaNEFYz+6ptfbSfrXfsojSAJJY1UEteWN5/RcUinzsFQ4seSc5UgNi7jfxSet8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775908185; c=relaxed/simple; bh=YlDBfTNKDC61NbJ/MWxSYVaEY5En/uqTnBWbyaQ/IXQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=LJqp97m7azXYsNCuDxX+pnlRm20f4tfhRngmFmZoVQj7UHqhLmM4/7I1RZzWoAdhWjc01TCOMuNIFkIL18/DDSDn5NO6u7xIV4AR33dY3J7kN7g/848DETlvifEG9pWbgh07Iqxebiyv9lQtxB8+9SE/6mQZhekoNDqQfW1NYOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KCv13mjB; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KCv13mjB" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8296d553142so1527744b3a.3 for ; Sat, 11 Apr 2026 04:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775908184; x=1776512984; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=05Bl1VMHrlqvAGCe4SZJGpUzfEdAgQQ/S9qmsGrkSYM=; b=KCv13mjBivZ3/LUDSHAxFCHrmXDW+lxp3lTI/uslX5FLw/WORDSE3TK6XbPAWlNwBa 6SOwTQppomE5WclJENnuF+7TtPgxjYmjwpaqiLS6ytvgb7PYUjo/vsxfeLn6O26upcBc eeCby+e5SbDYANnC3T0fvcNR6otzf01L1vRf07l7VldynTqzM++COmkkWhu1fc9gf2DF CdzDupSsn3lgOGHXTmzH5AkHFUQ+XfEBWIvbzr3Hh8w45egtCNGzDWviRzIONC7NhPJV 5e7GYu/6FdG5Z+togoxZOoIS8V40y8KRJ70SDVoPBOFBNOTgs1F4pWmvVAXFFtT/7tVk loIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775908184; x=1776512984; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=05Bl1VMHrlqvAGCe4SZJGpUzfEdAgQQ/S9qmsGrkSYM=; b=f77uaYoO55NAybdd+b5Q/Xqqmn3LzWvhKWuXqlivNrdTM3FnjNo3qkRHAeFlgjfict RbSe+3N+P+znIa1VntEwJHkAUPDsC1wyohLhXxmEyRr7gVNs84JQyn/TdWmPPML7TUCo OqXRaXp8zrnKHfSYN68CdStWy+i68VlcDsaVrNuCEuJNEpNF+RDPlxXxy3htyybGXlvc vu9n7AeHoey2W8tWrOeRBtefiYo7F+pupTbZmt6bD2kzPpIeNdEgBJ3EKZNaDoiw8Bqt gtdsBvgnrJv7bKPG75NM7SVaiScSGT6A4Jkhb4IpDHvS60mwW16qAZ9K20PWIMmm+76Z o4XA== X-Forwarded-Encrypted: i=1; AJvYcCWE4Lu1wnOnRVfVlF45wnSiveYqymbQHCr7YKEijR7OwLsRJ9Tas5q3w7nnZihxTg5kqpiKjlLOQ5D1Mx8=@vger.kernel.org X-Gm-Message-State: AOJu0YwMIlPSZf19iHGMsY6SCQ2CPCfoHkOywKPHTsNGnWoAJon/3HTU aFBgJV6yfKnyrSrMG/kL9nnaTJMRioKgLP+MjgoOf97cBNUPWsakCM+Q X-Gm-Gg: AeBDiesO/kOnhP69TazohuC6RDET/j2jCl8meDgQ4ELLMFGC+zLzJcCBMGA+SK28Zg7 sRhZp7I6fj6p/RRwqRwmbj3soSvheSSZ6DVzfSwsIHA9eD6gvXIiNtPEtEkyVvpnyGvT5SGGlH7 q4XnX1btPxuHXD9sLbhyfBIbIJ/ps0rH1UIHJm0XRmQCwc6YY9gF/OtrfHpTMgH+u/Oqpfu+zg1 Xw0dEFAaSHPmtCADXjOFiMGcrEY7XuI7OqCDfX8c88IQPcrU9/10GEnwH6ZymjW6OENpPyeqFfi wpkQh3JAUb6UaJtgyy87IzVs15LzVfRwbkJUDGx+ANzQYbLGByKR20isKn/3+EJ1Fz2FwNyL6e4 fKbaYxffKuiuNsw7A11LVnLFE5afa+OAJ8iRA02NFdePPaT1HT3CeVw1BQ/0kOw9zpbLz/woOA8 CQN52M3KzzIqlj9WGXhyZDFSJjk54xjy04D47Vo+fwHP/k5C7VS+I1MWBOWHjY8+FuIv84SHM7Q AG6+lePnJ89NGempwjV X-Received: by 2002:a05:6a00:17a7:b0:82c:dd31:b84a with SMTP id d2e1a72fcca58-82f0c2b03a3mr6917094b3a.43.1775908183861; Sat, 11 Apr 2026 04:49:43 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c371825sm5421377b3a.25.2026.04.11.04.49.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 04:49:43 -0700 (PDT) From: Felix Gu Date: Sat, 11 Apr 2026 19:49:38 +0800 Subject: [PATCH] spi: sn-f-ospi: fix incorrect return code for invalid num-cs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260411-ispi-v1-1-af384e81c4c8@gmail.com> X-B4-Tracking: v=1; b=H4sIAFE12mkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDE0ND3czigkxdi1QTU0tTQ5PklLQkJaDSgqLUtMwKsDHRsbW1APW194J WAAAA X-Change-ID: 20260411-ispi-8e459514cdfb To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775908181; l=865; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=YlDBfTNKDC61NbJ/MWxSYVaEY5En/uqTnBWbyaQ/IXQ=; b=RtthSPOeP4fGWtwjriNR1eGEkX1u7LJMJYtl7vs3iNJjEopGY2kihveEU9AJcFeeKUWt3Gujo 6YCxLzoKu88A5Szvua7bpbzRmYEpGm1yHMViFWgi7+imP3fFw3+Xov2 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= Returning -ENOMEM for an invalid num-cs value is semantically wrong. Use -EINVAL instead. Signed-off-by: Felix Gu --- drivers/spi/spi-sn-f-ospi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sn-f-ospi.c b/drivers/spi/spi-sn-f-ospi.c index 3c61c799723b..b459d51cb3a8 100644 --- a/drivers/spi/spi-sn-f-ospi.c +++ b/drivers/spi/spi-sn-f-ospi.c @@ -625,7 +625,7 @@ static int f_ospi_probe(struct platform_device *pdev) of_property_read_u32(dev->of_node, "num-cs", &num_cs); if (num_cs > OSPI_NUM_CS) { dev_err(dev, "num-cs too large: %d\n", num_cs); - return -ENOMEM; + return -EINVAL; } ctlr->num_chipselect = num_cs; --- base-commit: 66672af7a095d89f082c5327f3b15bc2f93d558e change-id: 20260411-ispi-8e459514cdfb Best regards, -- Felix Gu