From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15B022D738F for ; Sat, 11 Apr 2026 05:28:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775885319; cv=none; b=CPVkPLQqWKYCT/hGu69TBVqp4pLEQlypM5jZmLeMmd7yrtua/muw60ObUuFIRMbXLGmR/eNVEiq9iSnrV1sYz+M+JGc/osW4zA9Z1zHLNsm/p34ZdtZTtOOmkYojMCBYQnKtFvL6UM4oAeRKLqJljtwtpH+g7YATWFnoFzL7vAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775885319; c=relaxed/simple; bh=cHlezQzNTFhHadbHMdW3KF+YwpmykR5v11PUP9pfbeA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bjmqTDbPO3w9gPI8MUcr3jP7oEoWv0C9zSSgpUcFljQlR895p0RWecf6N6vIRy5LX7wDP5Enpx3F0EU4IaaamSEEq3XOHchlwJcY/iIp7pgQZG52pZPr/LOEPfE4YFwObdqQEZLAgEzfdcDnWjm4idi+v0+2IWqDFXX1ezrkxVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IzvVe4r8; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IzvVe4r8" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2b2469e5117so14176475ad.1 for ; Fri, 10 Apr 2026 22:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775885317; x=1776490117; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0kdtgv3kF42uEcqXb+PXCIP+Ad+2Y3zNeT/97wbW9NI=; b=IzvVe4r81uBl6Ki9F9WnhZNlRwjxL9gCe88wAQafxxgHgINuIv5OLvYi86bL+OwGWi utGly0HK+ZEMUtxoCxtW1OCTSq9q5bF8DEyUd6JBLkxtXIr2OWM6M6pEu6HFOJI/CAVB B23YkcstdnQplYtuaOzfX3LiHkkb1yRTDfIcihTFncNln9VueLaXqyM0xig1iNkIQHxl mbQzB2OGUxIW6uGu24nEz/ClKZc9ib2+PmKzQeIEFk38ZstS7V5Vyrn8Kk4g2E9z7jQy 7g55SdXnLg3L3wnyKNDkIRO3PjcKt6DeGwdTqxKAHj07nRALIymisqX05vouNoiIlJyj hwsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775885317; x=1776490117; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0kdtgv3kF42uEcqXb+PXCIP+Ad+2Y3zNeT/97wbW9NI=; b=ERcyMsfOB0sC293hgP7Ds6U5bW2HkDVR1DdDLfUDNlKyR4eDEHcNAdsjiWqFiYhd8D baGJeEwElyd3GFEVfxUmj+1KvNoFiZFsQIl/U08tmA5+kOfUtoAmX3gejJZWBxZU8cMq 4ozrUKNC8IhOr7HqVKYblx3aGWG5yB7hifEgI6mA+wVDLvqfKtjtt/lbGBPFlvH5kwlk uXAGe1bmzm5n+1YZv2UV8oHBlB/ec3vFkSLhtuVpUOjnB+6IRfrVJepfvdyIRYN/dNz8 2aPcYvcpLE/acH4lunOOK6Bp0NJBD0kD77HDX+GrWMHPkiZu3x4u0BgLxi4/LdF37nzp ZN2w== X-Forwarded-Encrypted: i=1; AJvYcCUJduhq3WCuKmbcbvaS8lDNRohfn/BH3HsL3CRpm+FN7eKdI1iWK7ey8/ZQdBdal4Ff1YfluEueTelhNgg=@vger.kernel.org X-Gm-Message-State: AOJu0YwXjiJ8LCzHD+CWJOvtCFF63UFb/O9s0+4liFDZZPSS8Iovpmxh L71XNCdr9N0CUbsUbLZ4lxxRLyGuquFrmfUpDHS+K/b8slk7DR+V0BSf X-Gm-Gg: AeBDiesweQ5mtWr3H6XczieIADjipENdR4teStdsF3ZsQ1nTyheO8t+CfGtWgvym8wq 4kDjLeOjT/R6LloCm7PTMxdg0xd8n0X3i3X1d1gxQEZ3XTqqrG0v8MA9LT3qVOA3oj5qEE9fRo8 tEscE764hpsP+vnBbCoWKm6YNnUMAuC46PWW9xvdMnHBJSbXAsFiD7NgdI+FGrr2G2ZkTNvvoYD EAbwLx2k1cPv/FtqZYqoWr90tfOQNFQ/JNfQZxtDUafrX/tkC4RSrrnQQecLMZahztloVO3r2uf ZalkKyegYBnouUY16PrDrt05WjEG+Ok0izyxUnplp3f3vRf2fyZLT6ODapxVhDjnT9Ceav+eXbg QRsXHEAd27W9YER91IIs/GGuEFxWisc/9NAYhRpTIkmnvbCGJHEgG+6tkwviwk3AgJ8XD6EgoQ4 8GSzppsA+pJziVNGbvrj7HoMyrhB19BRXZPNs= X-Received: by 2002:a17:902:ed4c:b0:2b0:506b:e6f8 with SMTP id d9443c01a7336-2b2c722f15emr68659285ad.5.1775885317377; Fri, 10 Apr 2026 22:28:37 -0700 (PDT) Received: from C6-AF-E1-B8-1C-91 ([223.188.110.165]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2d4f09e85sm51939565ad.47.2026.04.10.22.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 22:28:36 -0700 (PDT) From: Adith-Joshua To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, straube.linux@gmail.com, Adith-Joshua Subject: [PATCH] staging: rtl8723bs: replace magic numbers with named constants Date: Sat, 11 Apr 2026 10:58:17 +0530 Message-ID: <20260411052817.354594-1-adithalex29@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace hardcoded magic numbers in rtl8723b_InitBeaconParameters() with descriptive macros to improve readability and maintainability. No functional changes. Signed-off-by: Adith-Joshua --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index 8d259820f103..41f561120af5 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -864,6 +864,18 @@ void rtl8723b_read_chip_version(struct adapter *padapter) ReadChipVersion8723B(padapter); } +#define TBTT_PROHIBIT_HOLD_TIME_MS 0x64 +#define TBTT_PROHIBIT_SETUP_TIME_MS 0x04 + +#define TBTT_PROHIBIT_VALUE \ + ((TBTT_PROHIBIT_HOLD_TIME_MS << 8) | TBTT_PROHIBIT_SETUP_TIME_MS) + +#define BCNTCFG_AIFS 0x66 +#define BCNTCFG_CW 0x0F + +#define BCNTCFG_VALUE \ + ((BCNTCFG_AIFS << 8) | BCNTCFG_CW) + void rtl8723b_InitBeaconParameters(struct adapter *padapter) { struct hal_com_data *pHalData = GET_HAL_DATA(padapter); @@ -878,8 +890,7 @@ void rtl8723b_InitBeaconParameters(struct adapter *padapter) rtw_write16(padapter, REG_BCN_CTRL, val16); - /* TODO: Remove these magic number */ - rtw_write16(padapter, REG_TBTT_PROHIBIT, 0x6404);/* ms */ + rtw_write16(padapter, REG_TBTT_PROHIBIT, TBTT_PROHIBIT_VALUE);/* ms */ /* Firmware will control REG_DRVERLYINT when power saving is enable, */ /* so don't set this register on STA mode. */ if (check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE) == false) @@ -888,7 +899,7 @@ void rtl8723b_InitBeaconParameters(struct adapter *padapter) /* Suggested by designer timchen. Change beacon AIFS to the largest number */ /* because test chip does not contension before sending beacon. by tynli. 2009.11.03 */ - rtw_write16(padapter, REG_BCNTCFG, 0x660F); + rtw_write16(padapter, REG_BCNTCFG, BCNTCFG_VALUE); pHalData->RegBcnCtrlVal = rtw_read8(padapter, REG_BCN_CTRL); pHalData->RegTxPause = rtw_read8(padapter, REG_TXPAUSE); -- 2.53.0