From: kernel test robot <lkp@intel.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Christian Brauner <brauner@kernel.org>
Subject: fs/namespace.c:2867 may_change_propagation() warn: inconsistent indenting
Date: Sat, 11 Apr 2026 06:50:13 +0800 [thread overview]
Message-ID: <202604110609.NRLTTg7G-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7c6c4ed80b874f721bc7c2c937e098c56e37d2f0
commit: cffd0441872e7f6b1fce5e78fb1c99187a291330 use uniform permission checks for all mount propagation changes
date: 8 months ago
config: x86_64-randconfig-161-20260410 (https://download.01.org/0day-ci/archive/20260411/202604110609.NRLTTg7G-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.4.0-5) 12.4.0
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: cffd0441872e ("use uniform permission checks for all mount propagation changes")
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604110609.NRLTTg7G-lkp@intel.com/
smatch warnings:
fs/namespace.c:2867 may_change_propagation() warn: inconsistent indenting
vim +2867 fs/namespace.c
2861
2862 static int may_change_propagation(const struct mount *m)
2863 {
2864 struct mnt_namespace *ns = m->mnt_ns;
2865
2866 // it must be mounted in some namespace
> 2867 if (IS_ERR_OR_NULL(ns)) // is_mounted()
2868 return -EINVAL;
2869 // and the caller must be admin in userns of that namespace
2870 if (!ns_capable(ns->user_ns, CAP_SYS_ADMIN))
2871 return -EPERM;
2872 return 0;
2873 }
2874
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-04-10 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 22:50 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-11 0:55 fs/namespace.c:2867 may_change_propagation() warn: inconsistent indenting kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202604110609.NRLTTg7G-lkp@intel.com \
--to=lkp@intel.com \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ptikhomirov@virtuozzo.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox