From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11548253950 for ; Sat, 11 Apr 2026 10:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775902851; cv=none; b=AqyBi+TLkPbulM/N+fLDh69i+k343F9M2Ws8n/BfEKcxcyVW1b19FoKXHA8UKxTt9W1WHnshjCK7M4V9+WruVYGqKUIaUzlFAoBgyIbca1HHL037lawkFXHaKuXWFdpvM2i9/d+l7bksPfDsQW3uHnDS/UU+kvqcqAa9nd0bjgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775902851; c=relaxed/simple; bh=ZmRm9kdYBDk7rz8ZbtmocwkWC5GPoFQcrzLsFOXz88I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PKYzFBWJCOlLlOD1pAn4qi9WcjW0q4IVF9kSj20P0JjqTRGCfr6KU+VuI9/1XtlwmCGKVyqkji+URGQ2cLetYd0xF16mX/QDig4N/pTj66V3+YOIR3iOkltwnZUFTPogxdhjOaIJOMDu+43AdPrPAULr66aL9P8/kvglL8pQAC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TpAY4gLg; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TpAY4gLg" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488c2690057so27300875e9.0 for ; Sat, 11 Apr 2026 03:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775902848; x=1776507648; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LMe81/am5TvWiY3wr2sfayvId1Z3wpJTYL6BB0Qd3QA=; b=TpAY4gLgVsq+M00CdViaKjjpIzHJPtogr/Tgux03wC0ll6RpaA5gwtjWaUpKfCqRGJ U/1aLT7iSgDcajfMytHkc/hzwHeiO5gPdmX//WPpRXgnmR+1BJxob3dxZ4SFB7Gw91xa TR9ayG+Tkop1vhwvtEaFbw+F/XuvoheuRniktUQoRdsyNwmPXNikgx72WSRW+5faMOst UC0o5yX29p2XaKe54Z+BO5T8QPR7N0RCrshSQjLDxqPlq3w129OsfFFRg/FkhP//cm3K bZdhd6Xvga9lLyJxgrm+nnXBZJda/lo3zX5RFnawzMDo0/SDDAFdZgb4L80jorpphDl/ Zp4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775902848; x=1776507648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LMe81/am5TvWiY3wr2sfayvId1Z3wpJTYL6BB0Qd3QA=; b=PiKIp7Yw4aA+j3FSc9D6hOONLkuPz64ISk6v8dRWZ0J4ss4PbrAtSUlUe2KWrub4yc Fh5odJ3LZVo9oR/L6OwtGwU8V1F4DYJ1Hs7ZHd/JHL7xarIrQepJRr9OspjmIE7dMdoM hq5QRjcH3H+W2vhnQgG8cjuNQgVhIpBd4FKZTy4R5fQhoZ6bjXCFJu1sgwAGS4vhry7y 8IheMWMlaHrxkFNzrMR0bKHqvNmJtuO2ZiFy4bXc9PI1t2aNrRz6dYPvLNkIHtlAb4rn aeRxrOu8fyMO8DuBgwbgQk+G6ZdbnV1XKXOkLGcUZEWsWfKhno3ngV1wOQcjwcgQT5IP uavA== X-Forwarded-Encrypted: i=1; AJvYcCWejEej74lXbG3KvPADHaHvu+uUEI0rEjlE8KuABGSeHo6RfsaibpfkDphg209/tBKTcO3GPX8PTqVTmEU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx955RErpJPay29vZmv7qtiHGjRQOyy0ltZmOWP35vBQFWkCJ8a 5wWTcbpefyQ4UvvNd8NmH5syqsgsUU7YWwmLr50EqSthiu/l/uT4HXSJuV5tLQ== X-Gm-Gg: AeBDievY4HgORL7oRCbWzfc2uhYRwI1rNi7wM4H8xkYsyi/kltNH73wUHHvZPaWF4C4 FpSz6jhFBm5Aqm2ObyZ/beZt97u18wXZ3RE1o0O0svN6z7zUzGHXwlUYQuCQ4CYSRQxaik8e3Rf hpdF5fLEJ4VcQqqHfYtzJoUEOmA0WUPG2AURQPj7dxvJP6dZypSuSEPw6atKPbfISmV2KOmxWHc HPj4y3bblMfZSjoYXiOJmfHj1M8y+0willHw0TWeQeTp6Z6ROc+kvpQwqJ8o6BhU4nNarzwT+1j 6zH31d4QnjXckMkb7uA7FgkD2XRQ6zfBhkH+OMdcsm8nRju8s2hz1B2ie1qKDWBMUdAhCm41XXh L7ZV1aELf0xSVyvcEUI3EalQw8RDKcSoi5Lz5WVVt/0Z+/cwXAkDEhQeejdvMPw2S+0HERFRKey dZi4AYTqfSq0qSoupXiNZgL+SyMGu91che3Ccp/aI= X-Received: by 2002:a05:600c:8907:b0:488:ab1d:dcc5 with SMTP id 5b1f17b1804b1-488d6ac1bafmr53484555e9.27.1775902848377; Sat, 11 Apr 2026 03:20:48 -0700 (PDT) Received: from egonzo (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d681ec15sm41856945e9.20.2026.04.11.03.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 03:20:48 -0700 (PDT) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Dave Penkler Subject: [PATCH 2/2] gpib: Fix inappropriate ioctl error return Date: Sat, 11 Apr 2026 12:20:25 +0200 Message-ID: <20260411102025.2000-3-dpenkler@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260411102025.2000-1-dpenkler@gmail.com> References: <20260411102025.2000-1-dpenkler@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver was returning -ENOTTY in the case the ioctl command was not recognised. Change it to -EBADRQC. Fixes: 9dde4559e939 ("staging: gpib: Add GPIB common core driver") Signed-off-by: Dave Penkler --- drivers/gpib/common/gpib_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpib/common/gpib_os.c b/drivers/gpib/common/gpib_os.c index fca181b8c749..aafc4439b2fa 100644 --- a/drivers/gpib/common/gpib_os.c +++ b/drivers/gpib/common/gpib_os.c @@ -606,7 +606,7 @@ long ibioctl(struct file *filep, unsigned int cmd, unsigned long arg) unsigned int minor = iminor(file_inode(filep)); struct gpib_board *board; struct gpib_file_private *file_priv = filep->private_data; - long retval = -ENOTTY; + long retval = -EBADRQC; if (minor >= GPIB_MAX_NUM_BOARDS) { pr_err("gpib: invalid minor number of device file\n"); @@ -799,7 +799,6 @@ long ibioctl(struct file *filep, unsigned int cmd, unsigned long arg) mutex_unlock(&board->big_gpib_mutex); return write_ioctl(file_priv, board, arg); default: - retval = -ENOTTY; goto done; } -- 2.53.0