From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95DA22E542C for ; Sat, 11 Apr 2026 14:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775918548; cv=none; b=Ynf/7IUCWB70OP2+OqGdD9tz2B4ONZjgFOMp447/+d5VWRgpfiDK9kf2twsFfCzz6HdKUMA6g/b4J6GMFSdi5IeHFyctWiQHUu4EMhmk5/bIExxL++AWzEMUwlvstzZwrehqtph6A+nMsaxZ4pBH17/NcRlrv/at3QcsybuRu6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775918548; c=relaxed/simple; bh=2ICVKZ3NpG3PCtlyO0uDpJGbGb04mqRHQYElJUW5dw0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R4ae9VCSowP80JnmeU5bYX3UF0ALbGnSCfH5fcidMM4Jh/e6PJIGILwV/gZ+jPW22Gs7K2+v7N2ZCx4rIpT+hjwlHBRBZRJ47eAoBNqi4tS68KKptJU5pT/05Wx9GiYVBkqIgmYv67Mz0z8VS6fOkz+KjzXdcp82+4zEkgxZzoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hJj6EB0t; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hJj6EB0t" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43b949bf4easo1812827f8f.0 for ; Sat, 11 Apr 2026 07:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775918546; x=1776523346; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wwDHubDvF2ta0bIvciw+Il/NoP/+nau6OfQepCZXqzI=; b=hJj6EB0tNHcEetb4dh/CRgWxM5PhIV4JWsA0fuc8GSpy1WRRFsbROtDmh35gQJr102 d1RxiK3jWYRrauuT8wDAY9KLQK3NZbLl3I2rBjfJ/ImdwZTLKNsKFLBRDQJwApwZzrcM gxCQWX2yre2ELiLpPQGOIMq8GW0th/Nf6fo6liGwH0mIKK8pNx1HAPChiXEdl/TWorEv OnTQyGGLCuxsOmAvuR2MsN2U1yyBkivC0L83uBZWRQDW7UlYBsuNiI3bkMji3SdNxBKE a+Bhy2bIhSD7A8BaAYdtt3SDpV29Xxs2evDlzu6eQr1nmvuIlY4y/PVvJJ17Nuy+DQlE 4hpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775918546; x=1776523346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wwDHubDvF2ta0bIvciw+Il/NoP/+nau6OfQepCZXqzI=; b=KWsf4PR4Kz7Vt2pv44dr4GH91mSf+dY2GgE/YVgypi3Lop2X93YQ2L4z9QYdJhex3S w5j79FeKFyYg5ovcjfZsLb6JWF4eVKA11bz+9ZZZ2678PTv9sw20QkATFlQZx2OqmBzm Kl8E+Du95I0EsZFXkwzn9cp+gcaw6hM76Vf52e6uZ7kV6v+ZRfyHvMINM4YgMnwFdju/ Pn/NkCFiWKQNjjgUVI0FmPp06mo2g9O7a26k05auEzVRnFITcMynwYX5XNqIvW+DEPI6 OQP8QmviG6Z54zIJIpDUUIXPW8qZ0DKH3fSLVRleSuiAQ5r+h3deywiWSUCLe/e606q/ TzrA== X-Forwarded-Encrypted: i=1; AJvYcCVcY6tliTsNiXjFGtdj6xCbjeil7QJnYaxnfsr4M51OUDeWQs1s4c8Gm0NqvtT0arbYs2t+4AdlSAeA0n8=@vger.kernel.org X-Gm-Message-State: AOJu0YxRzIa9YagsHXBlpWMUB0CZZRZe2tLS/gGwa3JkHzZmw+BYZjKv PLUDQlw+Ft0iTKlsQa4CSN7qq+EC4M2joCPoK0YMYpctYwpSNZ5p7eL/ X-Gm-Gg: AeBDieutevYWa/lag/OGo902CQuZjNrGeKvmqFExEGhLSyB7F8pdQQl9CEfj2cqBjK4 pZolfkCoMZK8S+Q6Qf+hEjHZSXPM2Lo1DEO6JsGJV65PeOc1aA3Flm7QT7oPcUjgjfmXiPcUamU sbFfZmMZedTwndIPujchUENysQtJsuqt26CLmOf3EUkkizh/wVSzqa0/dMbEsYkN0EmskW+UkdL QmVnMi0WKFCXlY+BKc6M8/HiWda6ddB4/3GzTqeHFjfIvyGhdZ0VOn4OWXCnutQ8Vftlc8VZm6a gR1qvzCKZc/5llH/Q4Fl+XN91HJ61+CrdTLAcCWjgJqfo66q+XocQWJIj7NOWuhAFHDf7R0u221 IH4OJkn23iVArblNGu22F15ntOQVkLxluAUpeKyAkd3Sshc+ZftQVA7E9kpUZfGY1gzaX77CGqF UysvFM/42eT6LMNrRWpvBTliAr2cKaZjF1SNcddg5CVZumn+Psi1N9cz8TSMbOfr8Y X-Received: by 2002:a05:6000:4284:b0:43b:9aaa:52db with SMTP id ffacd0b85a97d-43d6497b463mr11027497f8f.19.1775918545737; Sat, 11 Apr 2026 07:42:25 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d6ffd3880sm648412f8f.7.2026.04.11.07.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 07:42:25 -0700 (PDT) Date: Sat, 11 Apr 2026 15:42:23 +0100 From: David Laight To: Dan Carpenter Cc: Michael Ugrin , hansg@kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, andy@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: media: atomisp: fix indentation to use tabs instead of spaces Message-ID: <20260411154223.3091eb45@pumpkin> In-Reply-To: References: <20260411005512.46142-1-mugrinphoto@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 11 Apr 2026 13:51:35 +0300 Dan Carpenter wrote: > On Fri, Apr 10, 2026 at 05:55:12PM -0700, Michael Ugrin wrote: > > Fix whitespace issue where a continuation line used spaces > > instead of tabs for indentation. > >=20 > > Signed-off-by: Michael Ugrin > > --- > > .../staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css= _debug.c b/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug= .c > > index b411ca2f415e0..966d4efb200c5 100644 > > --- a/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c > > +++ b/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c > > @@ -1257,7 +1257,7 @@ ia_css_debug_pipe_graph_dump_stage( > > p--; > > /* Last comma found, copy till that comma */ > > strscpy(enable_info1, ei, > > - p > sizeof(enable_info1) ? siz= eof(enable_info1) : p); > > + p > sizeof(enable_info1) ? sizeof(enable_info1) : p); =20 >=20 > Better to use: >=20 > strscpy(enable_info1, ei, umin(p, sizeof(enable_info1))); >=20 > Same for the other strscpy() calls as well. Or refactor that code so it doesn't use 600+ bytes of stack and lots of scanning of long strings. =46rom a quick scan it seems to be generating a string of xxx,yyy, with the '= ,' replaced by '\n' to avoid anything longer than 25 characters and at most th= ree lines. I'm sure you could write and use a function that lets you have a lot of lin= es like: offset =3D add_flag(info, offset, bi->enable.reduced_pipe, "rp"); Oh, and none of your char_enable_info[] arrays are guaranteed to be aligned either. So all the snprint and strscpy calls into different buffers are pointless. David >=20 > regards, > dan carpenter >=20 >=20