From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9BA738657B for ; Sat, 11 Apr 2026 14:45:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775918746; cv=none; b=fijElvateZCzpXxH9ra1/n8ICa9TaLasD3GqaiIORD13I2W1lD8LOhdyZo8NdJfrf2xICEId2x7K80M9Oc9o/0MOAo9rPXaDFF6X9Q2RVIasKPOiay8pKxXEYHvLpRl1vFWbPh5h+9MqpCgtUiDkPsd9O316fFXQb+Qc7ytLcgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775918746; c=relaxed/simple; bh=6ee/ePMYsnFD5IvFeoBvxzjVKQanY6GW2oFLeAJGuDU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qM1YPFVPt2xf0UseGlgtBNH5Y6OulmZI2R7GtQRFRx1REVIBheIkrRcVUTMzWMyLBDhGBc3jgSn0uQLCsZYAyc+WNGEnMTxLfXNklyOC9eGGzDt93spR0xi/mrBObF9etpv/f1RyrSCI3bf4JzZPyPd5t8QfPAk9HHAEwM8nA5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FTiw9C+Y; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FTiw9C+Y" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488b0046078so29429345e9.1 for ; Sat, 11 Apr 2026 07:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775918743; x=1776523543; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6AZfIjpy54chd/oLiMe2eh5RXXChJ594JYVimVPk7UU=; b=FTiw9C+YFYOcYJJnYrl6P5sMNtYnvaxeY2loX/cvEQsTW1OoFT7WUVJjiwoZSim4nG NxW4BIkPKt1vstubD4tpRB20IIfhWaRlvIYYSS/vQZUZmLFIgMMBhja0CWIENnQQGkSc /SI1vrKedEygJ857O9Ssf1Sijhm79TMv0qlC2gZ73vbGw56M5DiSY4GZfxkrXMM80fso qwXcXRYvQrwWdLwkEj3dmrBkwe7Coqq7rs9ETBpDyQzxKHudTX5AMzGhcCBJMRdVfjC8 89MmymAA3Ww3+utwYhuPA5XlOEDA8vRlJZbjUAeA4ruKYxVShGv1q6LoliqJ/9Db4Dqe yYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775918743; x=1776523543; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6AZfIjpy54chd/oLiMe2eh5RXXChJ594JYVimVPk7UU=; b=qrRYgHDryaWLjyAhtzyULOZJ9qrtvKNQ9nyam6ZEvWkQQu85mlL8UgUe9VLQWu+Ngt YBewilXIE8YtSj/6JWjkbNAL0V1LnRNJd59lBaxENHhEarl9MWOnSPAQQJF8/PzD0uz/ oGVGPtjJVd/jJd7FOagqHVJ6kZfXtUd+ZtysLRh0Po7PK9i01HPV9HZqRi/D/qh2dsMC ZfsiwnO1Zw5T4C/Fj2EJ4CzfEsTRUVGMYnLK98iisibdRUYojqNOe42RISMIMh/hWHo6 4sEUrCit+py0w3gkGdeIxJW47GlxKV9YbhIHy3X0EMGtnhqK5blwuXw1ZElXUWP5Mg4N LKkQ== X-Forwarded-Encrypted: i=1; AJvYcCXREKpAvVz1ySvI51xOk+WxgUYsjSwqajy5KszIe/DwN+3lOAlFKaM+S11lxHbYYpNZIPmz7HlIfNqgWlo=@vger.kernel.org X-Gm-Message-State: AOJu0YwT5p8xW1IXLnyEyKGStmEYZYB0GqqS5GldEwDjrFXgDn0LNtTE XCCroacQ5r86Js/wQ7CS+qYCSeReXPu1Wv4mkU496A/cxBVFaXGsaB6W X-Gm-Gg: AeBDiesfnBABD4kPpAZjZogn4KuRKUxS3TXJN/2Q0W8kp1VZ1p2Is4aMqNM33uUefuK 3orTGkVE027LKepyyezl62gb6XafHTwixIo8o9Kk2CxSHPskweDk2+8spVL4T/9+Nq7wrcFVQup KbGN1WSJ7TV2u6Fa/9T2VWHQFpkt6GDW2ei2QvCaVvpTNPrJ3wgFm0QNzdFt1m8+Gqxa/thDo97 uq+a4xdo0oD37cvZtqNWl1+LGFS/TkPzjyVQtqm4KDfuKTMRUs4r9rHVQEGJXcEefLHG5UOXwwy VXc8CCTgk7k87KSil5NOCimQREz2z3EVZeiiteEYbVHOS+EZOPBTlqqN5Q+2RfaVAQeqpdKwWIc 8tGgQhiBZkzNnKamVNa4fblcBeuczZuIw1q453Mj6lPjmT5MvsoigI8i8wEVpMafV7WZW1nGmmk pPcMmxB7b7+RUcuU7Y+r5Jq3ynV6ELoJk/h2nvM8z1xExv1HH+H2uK7PixaWlYq5xy X-Received: by 2002:a05:600c:460a:b0:488:a824:fdff with SMTP id 5b1f17b1804b1-488e00fdbc3mr13943905e9.22.1775918743193; Sat, 11 Apr 2026 07:45:43 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5b3c597sm151294875e9.12.2026.04.11.07.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 07:45:42 -0700 (PDT) Date: Sat, 11 Apr 2026 15:45:41 +0100 From: David Laight To: Rob Clark Cc: Jie Gan , Akhil P Oommen , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 15/17] drm/msm/a8xx: Preemption support for A840 Message-ID: <20260411154541.3d5d637a@pumpkin> In-Reply-To: References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> <20260327-a8xx-gpu-batch2-v2-15-2b53c38d2101@oss.qualcomm.com> <07fcf759-b53c-4bc8-8e88-48b82713fecb@oss.qualcomm.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 11 Apr 2026 06:56:15 -0700 Rob Clark wrote: > On Fri, Apr 10, 2026 at 7:22=E2=80=AFPM Jie Gan wrote: > > > > > > > > On 3/27/2026 8:14 AM, Akhil P Oommen wrote: =20 ... > > > + struct a7xx_cp_smmu_info *smmu_info_ptr =3D > > > + a6xx_gpu->preempt_smmu[ring->id]; > > > + struct a6xx_preempt_record *record_ptr =3D a6xx_gpu->preempt[ri= ng->id]; > > > + u64 ttbr0 =3D ring->memptrs->ttbr0; > > > + u32 context_idr =3D ring->memptrs->context_idr; =20 > > > > Shall we declare these variables at the top of the function body? > > =20 >=20 > We can use c11 / mixed code/declarations now. It's actually kinda > required for cleanup.h stuff (which I recommend for new code, where > possible.. I've been using it for PERFCNTR_CONFIG ioctl that I'm > working on, and it makes error path cleanup much more straightforward) It is also still frowned upon for normal variables. It does make reading code - especially large functions harder. David >=20 > BR, > -R >=20