From: Greg KH <gregkh@linuxfoundation.org>
To: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] char: ds1620: clean up system_rev declaration and logging.
Date: Sat, 11 Apr 2026 10:51:49 +0200 [thread overview]
Message-ID: <2026041116-surfer-unbounded-0edd@gregkh> (raw)
In-Reply-To: <20260411082112.46588-1-shyamsunderreddypadira@gmail.com>
On Sat, Apr 11, 2026 at 01:50:25PM +0530, Shyam Sunder Reddy Padira wrote:
> Remove the local extern declaration of system_rev and
> included <asm/system_info.h> to use the existing declaration.
>
> Convert printk() calls to pr_err() and pr_info(),
> and fix other checkpatch.pl reported warnings and errors.
>
> No functional changes intended.
Plaese do not do checkpatch cleanups outside of drivers/staging/ unless
the subsystem maintainer says it is ok to do that, or you are the
maintainer of the driver.
Also, checkpatch cleanups need to be "one patch per logical thing".
If you are looking to do basic "how to get involved" tasks, stick to
drivers/staging/ please, that is what it is there for.
thanks,
greg k-h
prev parent reply other threads:[~2026-04-11 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 8:20 [PATCH] char: ds1620: clean up system_rev declaration and logging Shyam Sunder Reddy Padira
2026-04-11 8:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026041116-surfer-unbounded-0edd@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=shyamsunderreddypadira@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox