From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CEFB230264 for ; Sat, 11 Apr 2026 08:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775897539; cv=none; b=O/yD8pIMoHygwobBdF9d9wMYcugze81mkMk/CzIvA1WmGinleZdiWyZvlYE4UzJtDDCdU8Bfh+KbreL7a+Fq7L5tJn7wZePU22yxEWorGdOvHsqaXF11Cf5hJ7IbLy+0s0DI0OC41IoV+2cWNoeddtag9gl2FTtibzN06caWtnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775897539; c=relaxed/simple; bh=40oisyasJXT7XjCSokPn3QyQHx32e/LQTRjxTJ/JEDQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pH40l2uIa4PaX9D2J0iOaIw+rzvrauLp2fisvxvAR5cCkMj3R0HWcCrOk9fjwBMfqQp2xElgunjLEC6IV2aKEjieGJUl8+VdmQ4ztUyx9KchLX5fPYVSZNAJf1MbTPMcoNkgmIbbUf++AHYD+V1uoLVJ16H93N7OpLO1lHRUsmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tyD3im/6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tyD3im/6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67EB6C2BC87; Sat, 11 Apr 2026 08:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1775897538; bh=40oisyasJXT7XjCSokPn3QyQHx32e/LQTRjxTJ/JEDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tyD3im/6gol1ZWtU+M7oNwDCuuTzUa0qP95eVrnMHqeu0muAPe0mgHFr/iZ4k8R8K QbBvzh16HbRB/vlzN3zqa5Fl3cndVqaAJnkKDhchKrze8/oWuqvpbg9zxSpRuxL+dz c0FLRWWDR16Pr50En3XxL6kiJq95fY5VXy4SwG6s= Date: Sat, 11 Apr 2026 10:51:49 +0200 From: Greg KH To: Shyam Sunder Reddy Padira Cc: linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH] char: ds1620: clean up system_rev declaration and logging. Message-ID: <2026041116-surfer-unbounded-0edd@gregkh> References: <20260411082112.46588-1-shyamsunderreddypadira@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260411082112.46588-1-shyamsunderreddypadira@gmail.com> On Sat, Apr 11, 2026 at 01:50:25PM +0530, Shyam Sunder Reddy Padira wrote: > Remove the local extern declaration of system_rev and > included to use the existing declaration. > > Convert printk() calls to pr_err() and pr_info(), > and fix other checkpatch.pl reported warnings and errors. > > No functional changes intended. Plaese do not do checkpatch cleanups outside of drivers/staging/ unless the subsystem maintainer says it is ok to do that, or you are the maintainer of the driver. Also, checkpatch cleanups need to be "one patch per logical thing". If you are looking to do basic "how to get involved" tasks, stick to drivers/staging/ please, that is what it is there for. thanks, greg k-h