From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A130126A0C7 for ; Sun, 12 Apr 2026 02:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775960853; cv=none; b=lBSylej0BIi8bWJ6INZo5SoLjpgFo++Lh63EwVOzwhxTzY9W0oyCXKCQPtZam9vdNmVOAOSz/GfgcCk9JrTSOVQGaib1nKjvGLl+Ul1a1BJOFhYQXTfIqgcNowCQA/V8Dxo2bHVmwWNCCOGwuIwFEN/cKtoquyVE5evK31nOwNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775960853; c=relaxed/simple; bh=EVadKMzdyA05JwtqvG0eCVx3p4RsAmYyt8IXqFx0U7M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QJGkxaEs9AzXHXXHe5A4nqdm6L5nXXb0Hg5wi0Vn5JckvtS+Xw8lFkfDNApYsH1Y7H+91Qh3lbi6hjVsZdqGKIs1Vqhvl9cUCz3dNv+6r4OqXvMFbFFLKKTqe3aRXSYsM9FOqliXfYByH6ILXgrGHHWcQIUdwUa6OmqeKPaOb5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ja/zMrUG; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ja/zMrUG" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-12c3d30564eso1541243c88.1 for ; Sat, 11 Apr 2026 19:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775960852; x=1776565652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cRb3JIVlYGaiJeVlo7rnOgfaUPADTGIibb+C/7j3e0o=; b=Ja/zMrUGPAaJEV9INF4DkPX9Y5D4oWr67Wa2ZCMfxa0QgyIRc7a4YbK5wI39Fe4egX tuM6U0KTma6EFpJKfMQ9KbIVTS+CITNibiJjwmz/lmZrj2ZudDAAKRiosiONhSRUbUDo qWeJMpyN1d/dOiI48mO6b847Ai2KGHJCpYVTpKBW6wOg1k890ZM8r9gg8IjIM+aZQlyS QPIw+HeqZlvdNW+wJJWpHx0H6rK/CulhjCrL7L475T7PBdSGlxnHBrScOhq5BwEXfxQC mxsJC1CcTcznU8A01skckbNKaz+7BvbBFVAyPV0kncRHXAkAMsnZT4JHBn15JmivKgIX 400A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775960852; x=1776565652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cRb3JIVlYGaiJeVlo7rnOgfaUPADTGIibb+C/7j3e0o=; b=f7VbSsmsrBTiABsPxpZlU3kuL5WdO6YDiOuhD/E3rfj9VmeYGoXv7hkGNGE9mXv+bM 10DjEs7zGHhexUIqWtM+LJXeH7NUuGfGWmcYE5LVbysYRpmKPT8Swh5c7WcETUELGc+7 sg4GwaImnsnM6fdW1+UY7ui7DL7k2WozSW8TmldBjLhE6khLOBEurh2mloqkofQVbuME kt8XcHC+S19Ee6RB/VAZJPA1iUhv2sI/sDk7OzrlqWeiJB3D8lrCQDCYeYCm3wLyxS1X DRgzEN2dHtTzGa5r2ALRu1JNEh6Br5xgwQcE4yErB3Oi22ZcPK83n/SIRA62RzgDXJTt eY1A== X-Forwarded-Encrypted: i=1; AJvYcCVaGowPajxYhNrkAJ/pC8zxtWFAzObJ8UzN3Oq5ibb6CEofIwAfqFvqn0CZ8yylKgWrW1sO6c64GMJdm08=@vger.kernel.org X-Gm-Message-State: AOJu0YzOuD9SELN+G0+rwRmvcBNViTeCK2Akv5IpoogJMsEAFKlzFKED 8MLgI6Sm6k9iSGmCt0EbThdGkeQM+oWwjoEHp4uFKZ/ZrmFNWVDzVc41 X-Gm-Gg: AeBDieuEz0c0+QXs6qjug0vESrCtpsJvB4LQhhy3UqUcl8z8p4DB9lm7sHz+iLga8tT ag7WQQihwg8w33HbweYvOCxmbdBnbZDVbRoAdPGC9j58yjMANQMyJLNqNgqbNWUoZd0NgCaIwsx 0Y68rYYnoNrqfDsRPSfWe0fFPV/Sns4rltfwDaDOD6KmIFzzH8+yl1k6H7G0/lhwQm/o3BkYafn 62m+k5M7b1RQCYliLoRhTLeItb9smF1rj2mMdVMcRiQjEFgasDm44t0hCGLCGYc1X014xQCQwjO PVxOryN5UpqMEu4h3OFmtD3fclHJqB+15NZFfI7ajSrbkRGA8JZqcKzdSeAfg1FXHYBiCoGOp+D wSNLSexmuPIRFqIKns/c09C8I73hfEeuhnG2ex3zwg7t8rlEoQf6AlRXfowtlHUJvhpMvGLT6hk DXEdWtjq+9v2+2A0mOo6aehG2E2fhpM6O+PMiUq4f7uN9YgEP1TgJlECRWOrwMT+H6QkxVlYfFW SahZIPCmg== X-Received: by 2002:a05:7022:6282:b0:12a:796b:7cf1 with SMTP id a92af1059eb24-12c34edb8f8mr5438349c88.23.1775960851712; Sat, 11 Apr 2026 19:27:31 -0700 (PDT) Received: from efaec68ba852.tailc0aff1.ts.net ([206.206.192.132]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c34352490sm8757860c88.0.2026.04.11.19.27.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 19:27:31 -0700 (PDT) From: Weiming Shi To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Barret Rhoden , Emil Tsalapatis , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Xiang Mei , Weiming Shi Subject: [PATCH bpf v4 1/2] bpf: Fix use-after-free of arena VMA on fork Date: Sat, 11 Apr 2026 19:27:14 -0700 Message-ID: <20260412022714.1955495-3-bestswngs@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260412022714.1955495-2-bestswngs@gmail.com> References: <20260412022714.1955495-2-bestswngs@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit arena_vm_open() only increments a refcount on the shared vma_list entry but never registers the new VMA or updates the stored vma pointer. When the original VMA is unmapped while a forked copy still exists, arena_vm_close() drops the refcount without freeing the vma_list entry. The entry's vma pointer now refers to a freed vm_area_struct. A subsequent bpf_arena_free_pages() call iterates vma_list and passes the dangling pointer to zap_page_range_single(), causing a use-after-free. The bug is reachable by any process with CAP_BPF and CAP_PERFMON that can create a BPF_MAP_TYPE_ARENA, mmap it, and fork. It triggers deterministically -- no race condition is involved. BUG: KASAN: slab-use-after-free in zap_page_range_single (mm/memory.c:2234) Call Trace: zap_page_range_single+0x101/0x110 mm/memory.c:2234 zap_pages+0x80/0xf0 kernel/bpf/arena.c:658 arena_free_pages+0x67a/0x860 kernel/bpf/arena.c:712 bpf_prog_test_run_syscall+0x3da net/bpf/test_run.c:1640 __sys_bpf+0x1662/0x50b0 kernel/bpf/syscall.c:6267 __x64_sys_bpf+0x73/0xb0 kernel/bpf/syscall.c:6360 do_syscall_64+0xf1/0x530 arch/x86/entry/syscall_64.c:63 entry_SYSCALL_64_after_hwframe+0x77 arch/x86/entry/entry_64.S:130 Fix this by tracking each child VMA separately. arena_vm_open() now clears the inherited vm_private_data and calls remember_vma() to register a fresh vma_list entry for the new VMA. If remember_vma() fails due to OOM, vm_private_data stays NULL and arena_vm_close() skips the cleanup for that VMA. The shared refcount is no longer needed and is removed. Also add arena_vm_may_split() returning -EINVAL to prevent VMA splitting, so that arena_vm_open() only needs to handle fork and the vma_list tracking stays simple. Fixes: b90d77e5fd78 ("bpf: Fix remap of arena.") Reported-by: Xiang Mei Signed-off-by: Weiming Shi --- kernel/bpf/arena.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/kernel/bpf/arena.c b/kernel/bpf/arena.c index f355cf1c1a16..3462c4463617 100644 --- a/kernel/bpf/arena.c +++ b/kernel/bpf/arena.c @@ -317,7 +317,6 @@ static u64 arena_map_mem_usage(const struct bpf_map *map) struct vma_list { struct vm_area_struct *vma; struct list_head head; - refcount_t mmap_count; }; static int remember_vma(struct bpf_arena *arena, struct vm_area_struct *vma) @@ -327,7 +326,6 @@ static int remember_vma(struct bpf_arena *arena, struct vm_area_struct *vma) vml = kmalloc_obj(*vml); if (!vml) return -ENOMEM; - refcount_set(&vml->mmap_count, 1); vma->vm_private_data = vml; vml->vma = vma; list_add(&vml->head, &arena->vma_list); @@ -336,9 +334,17 @@ static int remember_vma(struct bpf_arena *arena, struct vm_area_struct *vma) static void arena_vm_open(struct vm_area_struct *vma) { - struct vma_list *vml = vma->vm_private_data; + struct bpf_map *map = vma->vm_file->private_data; + struct bpf_arena *arena = container_of(map, struct bpf_arena, map); - refcount_inc(&vml->mmap_count); + /* + * vm_private_data points to the parent's vma_list entry after fork. + * Clear it and register this VMA separately. + */ + vma->vm_private_data = NULL; + guard(mutex)(&arena->lock); + /* OOM is silently ignored; arena_vm_close() handles NULL. */ + remember_vma(arena, vma); } static void arena_vm_close(struct vm_area_struct *vma) @@ -347,10 +353,9 @@ static void arena_vm_close(struct vm_area_struct *vma) struct bpf_arena *arena = container_of(map, struct bpf_arena, map); struct vma_list *vml = vma->vm_private_data; - if (!refcount_dec_and_test(&vml->mmap_count)) + if (!vml) return; guard(mutex)(&arena->lock); - /* update link list under lock */ list_del(&vml->head); vma->vm_private_data = NULL; kfree(vml); @@ -415,9 +420,15 @@ static vm_fault_t arena_vm_fault(struct vm_fault *vmf) return VM_FAULT_SIGSEGV; } +static int arena_vm_may_split(struct vm_area_struct *vma, unsigned long addr) +{ + return -EINVAL; +} + static const struct vm_operations_struct arena_vm_ops = { .open = arena_vm_open, .close = arena_vm_close, + .may_split = arena_vm_may_split, .fault = arena_vm_fault, }; -- 2.43.0