From: Ziran Zhang <zhangcoder@yeah.net>
To: hirofumi@mail.parknet.co.jp
Cc: zhangcoder@yeah.net, linux-kernel@vger.kernel.org
Subject: [PATCH v4] FAT: Allow 0xE9 near jump in fat_read_static_bpb()
Date: Sun, 12 Apr 2026 14:59:41 +0800 [thread overview]
Message-ID: <20260412070109.5197-1-zhangcoder@yeah.net> (raw)
In-Reply-To: <87wlyclmvr.fsf@mail.parknet.co.jp>
The fat_read_static_bpb() only accepts a short jump as a valid
bootstrap code signature for DOS 1.x volumes when the dos1xfloppy
mount option is used.
However, according to the Microsoft fatgen103.doc, the BS_jmpBoot
field has two allowed forms: 0xEB 0x?? 0x90 (short jump + NOP)
and 0xE9 0x?? 0x?? (near jump). The specification explicitly states
that either form is acceptable.
This patch relaxes the check to also accept 0xE9 as the first byte of
the jump instruction.
Changes in v4:
- Add original commit log
Signed-off-by: Ziran Zhang <zhangcoder@yeah.net>
---
> Could you add original commit log, instead of changelog?
>
> Thanks.
Done! Please ignore the earlier erroneous v2 v2 and v3.
fs/fat/inode.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 28f78df08..0e7d106ea 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1479,8 +1479,9 @@ static int fat_read_static_bpb(struct super_block *sb,
int error = -EINVAL;
unsigned i;
- /* 16-bit DOS 1.x reliably wrote bootstrap short-jmp code */
- if (b->ignored[0] != 0xeb || b->ignored[2] != 0x90) {
+ /* 16-bit DOS 1.x reliably wrote bootstrap short-jmp or near-jmp code */
+ if ((b->ignored[0] != 0xeb || b->ignored[2] != 0x90) &&
+ (b->ignored[0] != 0xe9)) {
if (!silent)
fat_msg(sb, KERN_ERR,
"%s; no bootstrapping code", notdos1x);
--
2.43.0
next prev parent reply other threads:[~2026-04-12 7:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 8:01 [PATCH] FAT: Allow 0xE9 near jump in fat_read_static_bpb() Ziran Zhang
2026-04-11 17:32 ` OGAWA Hirofumi
2026-04-12 1:39 ` [PATCH v2 v2] " Ziran Zhang
2026-04-12 3:56 ` [PATCH v3] " Ziran Zhang
2026-04-12 6:21 ` OGAWA Hirofumi
2026-04-12 6:59 ` Ziran Zhang [this message]
2026-04-12 7:37 ` [PATCH v4] " OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260412070109.5197-1-zhangcoder@yeah.net \
--to=zhangcoder@yeah.net \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox