From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1914727470 for ; Sun, 12 Apr 2026 11:11:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775992264; cv=none; b=CAbzU0G3aPcJA8XKuQxRKEejvoYx1lZajTyW5omCEQwkp0ZBUFqakTBFsPCXtBZpRtdzqSdZsHcrzwCZY8bDMzxjCTWSg5UZSkeOjy+nI7g1gJKTxs5YRMAk+FuCujRHNP4pQYNVTJTKZWSm+8x85MnvsOHuSD6+lE6Ufwtvsso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775992264; c=relaxed/simple; bh=DN1YYPSHImU/U5TMNDB5Ec47OLtn6flhiZP9gVoHmi8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sN3No484sfiVfvRoxP447+LnVzV78eoEFMQLZfomJf6h7RtlNbSM7zSjmApsXBh5vMKqH2Ot5EzavBhwTX+6IH6M4ac2rp6dNxJAbmsED7j/aLKy0lGDSQN9P99Wk8uHhhs6oqpYqVkWB0rJOKPj9ezTi58TqvWFBDf1umG9IvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jWQjcj8V; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jWQjcj8V" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c70ea5e9e9dso1359262a12.1 for ; Sun, 12 Apr 2026 04:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775992261; x=1776597061; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=akueeEYc2Me3zisgTMBqzXUfPeZV9sXVNUmdWR6Vztk=; b=jWQjcj8VVeylOlGBTrPtSkigwqQ7U+0srmsoFsPkuBP8KUVgxPOaA94CCXlr3qQ9Q0 3yFAu/HHQZcBF5LuZNqRZ3EykrW8R8rhA6u7IlB4GnEKAUWl2syz4qYsfu7IDSenDqwA YhoJgu1aph2Hvnc0QGExzn6fnehjgxfXYmT1+yukvKrW9k8ISMihgZ5+e049+iLFB8YG gmXdpfZxaD9f5qDy9o7nJxYcWBQJeulqKIwDyQsyAh06bMfsdlMZCRgPIjjb8fW9GhV6 3OS4mywTGOx0w9blvXdGRFgzALE35TPxTHQ703uMOlJHzCyhPzQVVjgVoDWHrLgGaJ+9 0cIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775992261; x=1776597061; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=akueeEYc2Me3zisgTMBqzXUfPeZV9sXVNUmdWR6Vztk=; b=oVz+8x4GDhGB7HBa5DpzVfosT+KqOWexLHbXUYs+pmq5M4L1JDjEEMPtSGCk0aCY6D 2QYgB9rZlgt9pgL5yKHebfFXylr8mdEit+KEBUFdfeK5Dmv2ewtZFCqPrYIifGLdx0dT NzaKBThE4EBGNeP2sBBzZ196zeRqJ8NzDzpiIgetD0s58nmv2MC2wd4ZHXVelsZsuITD nSJFGA9GpAYhqhbOvzmZ/lonyaiV7L1g+lwUHS2tuRdol3LtFDTyAx19Qg+CHZUBh6Ko LdBPJt+UGiHsxEoh9hIilMJTyVufvI2yrbML5OZT8QMeopoZcXsNi+BkrNgNRWmVPyz0 Om+g== X-Forwarded-Encrypted: i=1; AJvYcCXEGfG6wtz6ePIlHnYZwtQX19wnju/d+Crw9nj4FHHi/vt9PbzpbBQag7WHeoJNvevJCT0rlw0ARwQukww=@vger.kernel.org X-Gm-Message-State: AOJu0YzJsVH+rtPk6fMexX42oQFqbRn6Kop/TXjSDWqcPaKutxmiBOro WfLrHke4Nw9dYOz1LvsghuNxHtq1ooxVSIUKAWsDoXbUazF1676Y2eNB X-Gm-Gg: AeBDietS6cARQdU84sZXkupT7BxM/D/LOjI201vikbozKQpjtG3hEYldPDHqqiyWDNj bXBSe5n2bfr6YDr35uIIzP+C7h5HtzelbgaRe2kQcp9AU6WkxC7uzHLEq6lDTFu6YiEiCPQTcsW EBt9Pf3XgrJm0d6TTK7quDcTxy13qRPIoPxUsxCCS4DzqjIl5ALTGDzABZoPQYyKrTdpgPUBauv LjGv5d9bDpeDDn+0gwnB5d2klnAYyM7StsZc22p98ig7KcY5KVkcCTr1Ea28WB1VoK8sTJQSzil VfhZ3b4LQgXBvI6yPG9Mbna84AXl1315GaDtEkWMOs+WLo5SUCCPMLlCVJW+VBRwBrIoq5xUsBx F6cU7qzMRm3R/+vTavF8RnMCaSl3dsWfaU7H7Qd7m4SljkLEw2hUQPD+3GBLU7qNb4N4hGDKU0o Ct5crKadwMTS+nB4+EWqMvExSl8etw756V3aF3NDfv X-Received: by 2002:a05:6a21:338f:b0:398:787c:d2e4 with SMTP id adf61e73a8af0-39fe3d0e8e0mr10815770637.17.1775992261411; Sun, 12 Apr 2026 04:11:01 -0700 (PDT) Received: from DESKTOP-82PPU4A.localdomain ([202.8.116.169]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7934c9ef38sm2522981a12.12.2026.04.12.04.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 04:11:00 -0700 (PDT) From: Ujjal Roy To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Nikolay Aleksandrov , Ido Schimmel , David Ahern , Shuah Khan , Andy Roulin , Yong Wang , Petr Machata Cc: Ujjal Roy , bridge@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH net-next v4 0/5] net: bridge: mcast: support exponential field encoding Date: Sun, 12 Apr 2026 11:10:42 +0000 Message-ID: <20260412111047.1326-1-royujjal@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Description: This series addresses a mismatch in how multicast query intervals and response codes are handled across IPv4 (IGMPv3) and IPv6 (MLDv2). While decoding logic currently exists, the corresponding encoding logic is missing during query packet generation. This leads to incorrect intervals being transmitted when values exceed their linear thresholds. The patches introduce a unified floating-point encoding approach based on RFC3376 and RFC3810, ensuring that large intervals are correctly represented in QQIC and MRC fields using the exponent-mantissa format. Key Changes: * ipv4: igmp: get rid of IGMPV3_{QQIC,MRC} and simplify calculation Removes legacy macros in favor of a cleaner, unified calculation for retrieving intervals from encoded fields, improving code maintainability. * ipv6: mld: rename mldv2_mrc() and add mldv2_qqi() Standardizes MLDv2 terminology by renaming mldv2_mrc() to mldv2_mrd() (Maximum Response Delay) and introducing a new API mldv2_qqi for QQI calculation, improving code readability. * ipv4: igmp: encode multicast exponential fields Introduces the logic to dynamically calculate the exponent and mantissa using bit-scan (fls). This ensures QQIC and MRC fields (8-bit) are properly encoded when transmitting query packets with intervals that exceed their respective linear threshold value of 128 (for QQI/MRT). * ipv6: mld: encode multicast exponential fields Applies similar encoding logic for MLDv2. This ensures QQIC (8-bit) and MRC (16-bit) fields are properly encoded when transmitting query packets with intervals that exceed their respective linear thresholds (128 for QQI; 32768 for MRD). * selftests: net: bridge: add MRC and QQIC field encoding tests Updates bridge selftests to validate both linear and non-linear (exponential) encoding for MRC and QQIC fields, ensuring protocol compliance across IGMPv3 and MLDv2. Impact: These changes ensure that multicast queriers and listeners stay synchronized on timing intervals, preventing protocol timeouts or premature group membership expiration caused by incorrectly formatted packet headers. Test results: Giving results only from vlmc_query_intvl_test and vlmc_query_response_intvl_test of the script bridge_vlan_mcast.sh. Without patchset, here is the result. - TEST: Vlan multicast snooping enable [ OK ] - TEST: Vlan mcast_query_interval global option default value [ OK ] - INFO: Vlan 10 mcast_query_interval (QQIC) test cases: - TEST: Number of tagged IGMPv2 general query [ OK ] - TEST: IGMPv3 QQIC linear value 60 [ OK ] - TEST: MLDv2 QQIC linear value 60 [ OK ] - TEST: IGMPv3 QQIC non linear value 160 [FAIL] - Wrong QQIC in generated IGMPv3 general queries - TEST: MLDv2 QQIC non linear value 160 [FAIL] - Wrong QQIC in generated MLDv2 general queries - TEST: Vlan mcast_query_response_interval global option default value [ OK ] - INFO: Vlan 10 mcast_query_response_interval (MRC) test cases: - TEST: IGMPv3 MRC linear value 60 [ OK ] - TEST: IGMPv3 MRC non linear value 160 [FAIL] - Wrong MRC in generated IGMPv3 general queries - TEST: MLDv2 MRC linear value 30000 [ OK ] - TEST: MLDv2 MRC non linear value 60000 [FAIL] - Wrong MRC in generated MLDv2 general queries With these patchset, here is the result. * TEST: Vlan multicast snooping enable [ OK ] * TEST: Vlan mcast_query_interval global option default value [ OK ] * INFO: Vlan 10 mcast_query_interval (QQIC) test cases: * TEST: Number of tagged IGMPv2 general query [ OK ] * TEST: IGMPv3 QQIC linear value 60 [ OK ] * TEST: MLDv2 QQIC linear value 60 [ OK ] * TEST: IGMPv3 QQIC non linear value 160 [ OK ] * TEST: MLDv2 QQIC non linear value 160 [ OK ] * TEST: Vlan mcast_query_response_interval global option default value [ OK ] * INFO: Vlan 10 mcast_query_response_interval (MRC) test cases: * TEST: IGMPv3 MRC linear value 60 [ OK ] * TEST: IGMPv3 MRC non linear value 160 [ OK ] * TEST: MLDv2 MRC linear value 30000 [ OK ] * TEST: MLDv2 MRC non linear value 60000 [ OK ] v4: - Removed binary application and related codes for selftests - Decided hard coded match based on extra arguments for selftests - Ran shellcheck on modified selftests code and fixed - Updated comments on patch[1,2,3,4] as per review - Added 'Reviewed-by:' as requested on patch4 v3: - Updated the series title for better clarity; old one is here https://lore.kernel.org/all/20260326150742.50289-1-royujjal@gmail.com/ - Added key changes section for new selftests patch - Updated netdev style comments and addressed review comments - Fixed MLDv2 MRC conversion logic during query generation - Mentioned intervals in units wherever applicable - Dropped type casting and fixed indentations v2: - Retargeted the series to net-next as suggested - Fixed a compilation warning in the MLD rename change - Kept reverse xmas tree order in IGMP exponential encoding change - Added bridge selftests to validate IGMPv3 Query MRC and QQIC handling Ujjal Roy (5): ipv4: igmp: get rid of IGMPV3_{QQIC,MRC} and simplify calculation ipv6: mld: rename mldv2_mrc() and add mldv2_qqi() ipv4: igmp: encode multicast exponential fields ipv6: mld: encode multicast exponential fields selftests: net: bridge: add MRC and QQIC field encoding tests include/linux/igmp.h | 167 +++++++++++++++- include/net/mld.h | 183 +++++++++++++++++- net/bridge/br_multicast.c | 22 +-- net/ipv4/igmp.c | 6 +- net/ipv6/mcast.c | 19 +- .../net/forwarding/bridge_vlan_mcast.sh | 150 +++++++++++++- 6 files changed, 491 insertions(+), 56 deletions(-) base-commit: 3f3a2aefbc661b837c8e344f944982d61c2ae037 -- 2.43.0