From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 048C4282F0A for ; Sun, 12 Apr 2026 12:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775997907; cv=none; b=OUzuyCkjyzpqG6wuZqH5LUv9N1W/Dh1l8pqHDUSQZevIkkLkanoLd758ITsUspKm3vaR45nU9eofHVk+W43+WtjlciM5RTTjxhmXi/lzh5kOGXAvP4faKld/FURnEQ3iy6DD2K1oA9+27u0tWVYMMHuVuJBkmke7Q5irTQllTl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775997907; c=relaxed/simple; bh=8Ln9L+1bUr1auVhrM1bMb8RKDwIuVqKervYg3i/L+/4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eaccCx8V9JM+MnnO41DDHLeqECK2PoQmD2ut/x9VZc+FceDZHrDUi177RbXmp2zehMPf0G3g0Y0Z5JBwQQ6dEQuzhrbpD3nGxiQcIFKihn6KWayGC3PA68dDtBxaoM4cD2319uDVVimR7S4abxLsIrEhTbealr5WfS40qOxdG4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QOOGO3K/; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QOOGO3K/" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35d9827661bso1998443a91.3 for ; Sun, 12 Apr 2026 05:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775997905; x=1776602705; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gvU9RvpBK2u7s6ovScuGMG+gjl6YN1La+ofcMQ5MbNc=; b=QOOGO3K/Tpb2g2ixVQWmRjGzjVV+IXEaZ0aRmrm3UUxo7YwMNoeIypR4wZJ8j60hEj BPZV6TfQ7Jtx7G9qsGij6p77OJnlozD5G3lFFNxZ1m5u3E8vbN3ME06493rby3g53c3x em2calVPZ0Pg6lb/FNjjOxlVBtsU/hvWq5EwBx3/Wa+bXpIakrH5vpsrc7akXQVnTv0g S/f5F557Of225IKdyhP4EHDKhO7BdGM6Bv/yL1BemjqaS6j9rvshVesMUVH2K+zBC9G0 /s9o4xDGijjPW1svIHY3hxhRvTQtzqQXNmZQYEPN8f5wMt+4pGLsm/ZxuevT/dBS3GxD PVbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775997905; x=1776602705; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gvU9RvpBK2u7s6ovScuGMG+gjl6YN1La+ofcMQ5MbNc=; b=nhiED1JGehOvLJwijCBUn0Gx7gXfA7fBhuA8cpKOJoLZ3S12bAWqOmYfieq1f8F1+t YYUjVEeUMlNN+2/+qSTf1mNhBVQh2j1vgnM8liYZxWLshyGLm9L4t5ZJfEvb7g7lYARn G/I8crt2zjsXrsuBVol+MQ52YQ0kXWKAeGnebLSnprCtKhwaQELOfz2jZ9YwvXo85qk0 uMun7Hc44XKpT72VM8XDwyIdI27L80XDb3gmqbRqZwcQfBMS9CUqBjC/m+BtuuQFEoXC 63ITXWZ3lDBkagKEbBfyH1aYN/4YkogXJqzUXBoiQowjG5BOkbsRnrpqxlOkXbQRr95Y yslg== X-Forwarded-Encrypted: i=1; AFNElJ9kAOYg+mMP8Bk+a4MSA82woFEm5LOz1ClDapOSGqGHPxOU/mN1ec9RV2FiqvYsxv4iosyO9te1SdfThWM=@vger.kernel.org X-Gm-Message-State: AOJu0YyJemdHpVfE1zvh0yONoDPI1/JIGStu+6+f/nEDxc/wZAGDW3ry u4ACzn+zrteOB39uwcZK9AfrUlNkm4pFwcX+k4XrcT/k4WqYpneJLwSC X-Gm-Gg: AeBDievXwCtTesI7cBzvnlaU2BMHx5BBK/Jgga7sH2wd7FlsxwweoD/j8hDEbjZgLaL 1IswrK/saDo+8H+DKiICXL+gkeMaWZzj5gMrWYDnwPFzfFXRyoVDFsBF8hJtpt9uOEmcENT21TS bNSygirhAUdQXmrJoOqUi3K+tIVk6uF/pCCUWYf4Mwkhhx5suXuGbzBcHMTkmhYvq9qLny4ntFO DBMbr660fClQChNSm3vAaNEBa1sb5Syffq36Ti45Z5Oexn5HxqUm0an/TCPkDpZv16OVKcpl5SJ wSc6bd5jQRPy6BFesrylMVeR+FxL1Jmr0FTyOmSzeW8I55r7G0mYuol215vAp2oUu9T8IEjKbSi 9oO1d5WuMgIyevANnkyDB3j5Ui5B9fIcVLBA2lrhOBFtRWQ56ghu8hp3SNAEAfsfHvW7u/PTV6y dTxVnw8qx93yioihL4jGgoK1ZE3uRtBYN417b1tWZjO4fz1oOdbo4fsBM3FHqZJB+nEbxh1ARCA Ye5UwEoftXwBmykWPhq2L99Zs8S X-Received: by 2002:a17:902:ba94:b0:2b2:5840:80c4 with SMTP id d9443c01a7336-2b2d5a291e5mr70378175ad.25.1775997905142; Sun, 12 Apr 2026 05:45:05 -0700 (PDT) Received: from localhost.localdomain (ec2-54-199-123-161.ap-northeast-1.compute.amazonaws.com. [54.199.123.161]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2d4f431c3sm80273025ad.79.2026.04.12.05.45.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 12 Apr 2026 05:45:04 -0700 (PDT) From: Xiaobo Liu To: Allison Henderson , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, Xiaobo Liu Subject: [PATCH] RDS: Fix memory leak in rds_rdma_extra_size() Date: Sun, 12 Apr 2026 20:44:55 +0800 Message-ID: <20260412124455.2008-1-cppcoffee@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Free iov->iov when copy_from_user() or page count validation fails in rds_rdma_extra_size(). This preserves the existing success path and avoids leaking the allocated iovec array on error. --- net/rds/rdma.c | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/net/rds/rdma.c b/net/rds/rdma.c index aa6465dc7..91a20c1e2 100644 --- a/net/rds/rdma.c +++ b/net/rds/rdma.c @@ -560,6 +560,7 @@ int rds_rdma_extra_size(struct rds_rdma_args *args, struct rds_iovec *vec; struct rds_iovec __user *local_vec; int tot_pages = 0; + int ret = 0; unsigned int nr_pages; unsigned int i; @@ -578,16 +579,20 @@ int rds_rdma_extra_size(struct rds_rdma_args *args, vec = &iov->iov[0]; if (copy_from_user(vec, local_vec, args->nr_local * - sizeof(struct rds_iovec))) - return -EFAULT; + sizeof(struct rds_iovec))) { + ret = -EFAULT; + goto out; + } iov->len = args->nr_local; /* figure out the number of pages in the vector */ for (i = 0; i < args->nr_local; i++, vec++) { nr_pages = rds_pages_in_vec(vec); - if (nr_pages == 0) - return -EINVAL; + if (nr_pages == 0) { + ret = -EINVAL; + goto out; + } tot_pages += nr_pages; @@ -595,11 +600,20 @@ int rds_rdma_extra_size(struct rds_rdma_args *args, * nr_pages for one entry is limited to (UINT_MAX>>PAGE_SHIFT)+1, * so tot_pages cannot overflow without first going negative. */ - if (tot_pages < 0) - return -EINVAL; + if (tot_pages < 0) { + ret = -EINVAL; + goto out; + } } - return tot_pages * sizeof(struct scatterlist); + ret = tot_pages * sizeof(struct scatterlist); + +out: + if (ret < 0) { + kfree(iov->iov); + iov->iov = NULL; + } + return ret; } /* -- 2.34.1