From: Jakub Kicinski <kuba@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Tim Bird <tim.bird@sony.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] keys, dns: drop unused upayload->data NUL terminator
Date: Sun, 12 Apr 2026 14:10:04 -0700 [thread overview]
Message-ID: <20260412141004.22c6686c@kernel.org> (raw)
In-Reply-To: <20260409225703.158552-4-thorsten.blum@linux.dev>
On Fri, 10 Apr 2026 00:57:02 +0200 Thorsten Blum wrote:
> In dns_resolver_preparse(), do not NUL-terminate ->data and allocate one
> byte less. The NUL terminator is never used and only ->datalen bytes are
> accessed.
I can't see where this is used at all.
Please write better commit messages, there's no way this 1 byte
is worth the amount of time I wasted trying to review this :/
next prev parent reply other threads:[~2026-04-12 21:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 22:57 [PATCH net-next v2 1/2] keys, dns: drop unused upayload->data NUL terminator Thorsten Blum
2026-04-09 22:57 ` [PATCH net-next v2 2/2] KEYS: annotate struct user_key_payload with __counted_by Thorsten Blum
2026-04-15 2:25 ` Jarkko Sakkinen
2026-04-12 21:10 ` Jakub Kicinski [this message]
2026-04-12 23:04 ` [PATCH net-next v2 1/2] keys, dns: drop unused upayload->data NUL terminator Thorsten Blum
2026-04-13 0:05 ` Jakub Kicinski
2026-04-13 0:31 ` Thorsten Blum
2026-04-13 18:00 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260412141004.22c6686c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thorsten.blum@linux.dev \
--cc=tim.bird@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox