From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 318D83064A9 for ; Sun, 12 Apr 2026 14:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776004678; cv=none; b=KpdWhkkEh11Is5fnFsrWuwLfQNwdp9KWXIWq/3QWoX4EYOfDeDmGpd3KtgTXJs2bT8Wpa2ULfCDnDu6vVi9vZxJtK6WlPLPxSCQ/iiBSwImgbyHDO9kwsKANquEZU19w3OahmDzPjQcKOcTi7FmKtwYS0O9ejbkY9w4JuQT4EYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776004678; c=relaxed/simple; bh=8HGVCGy0raN1geN6ut5D1K+q14q4DMHNCtQIRiRSJYI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dddcg6O2uBQtZsLpMMlYJBwBCib51MQGKUkDYYC+r3CJp1Zl30VkbRIzmr5df/1NTkWrcfQkvkMSDWOtuy9UiamygAzVQVbGjxc9BaPwqgo7jTLA8lFVRF6cUUVkkOKwDyzF7IZEWkoEjGg7d0WFOS6fn/8pWKrAGWo92N/ZP6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p9leKiaN; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p9leKiaN" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso38733245e9.1 for ; Sun, 12 Apr 2026 07:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776004675; x=1776609475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CEi9Jc/jK7jsLU4s75S6thPaEgweaYMPU9OSl2lWaSo=; b=p9leKiaNWQ8L67zFiy+bn9Fc7tdrsw6j003Egrf3DdaQ/+yXGp6ue0rYiL/OnJP1Ui isXCgD3GuvGPhof79FACO66q/VbNe/7vjENhUL1ALCjXVsif/t7FeCL3kV7aPpFby16z u9vUp0ff4uVoqEDtC9G1uPsfaC7wX7ej6rxFOBcfOnRUFTvrMNCR8XhiKNmUEwdCMq6S p26sKxkOhesTPXTGcTKB15vPa3q3RY09jL6SxyJtWoGERRsJGJZYyS9abxi6YTic3t6b SJ8/OINdG9saRf9bWNpBn6HToj1qEIMXM4M6wlEET3TdDTF+d3arE/LotE2xy+rGd+xo Q/dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776004675; x=1776609475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CEi9Jc/jK7jsLU4s75S6thPaEgweaYMPU9OSl2lWaSo=; b=olQF8oM0OL0SlIBrppJ9DVliQQPrOCVW1BVwUQQjHB7JqcdS/1jVUZm5AeqYZTSTMv pMHzAzB4SppmN/iXsuxzcpNmmfYW3df4JTmOqwDCjANbLI8dfPRgjH5J3lNsgEp/4hTO gHAcgPPNyHAazuYdZxPa2IczX+HzNgLryDG14TUbWGgIp7/W81qCrUd+QeR422e2Vqz1 Ef8u3npQLfyhRHuSWfETlyIEEbXdfhx2l0RetmnJFPj3euTbSskJ7ErUlH8S+kVXFNGy cTqPg+91zOUa4dYh3D90Z+3RdIMFGGu8npMWHOp8WzgnSCqjU5eaWAdGZVngtJ5X0Ifr nfQg== X-Forwarded-Encrypted: i=1; AJvYcCWJAXSnBsYS4o9z0DoOF3Or8+gUKpwu+0uaDJn5Lxlzl6C86WpWUucFZJnxQVk3pOf88SPhjiVgxLaLLkc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywn9KZzszFSDRSDuksUpiY33Hap/g+q5oggDDwXmMB923SpBcri X5kH1/11hhgtz9DWYlx8lnXFX00RnaqnuPoYlIqjdzv4kjh0mMQPGxq+ X-Gm-Gg: AeBDievMNnmVnudiyBWFrZ2e9c2bpl5EKZY+W0fMjqXA8of7nomVzxE28umYyKKLA43 UxNSjdTROl3647WWyUaCerCXjULdWYMoWwpwF/6qbXVMX626aBY9tjs2gPzvOw4E0RXUpAIomwM 2s6lZehI+VzBC27DBWWq0No+4KmlPHvGRlCENRtFSQQ4js2WLhQpS/j29fFh+1Zt9UwYctaXyY7 blfuXBMxraC4BZx2SbrvOBebAq58QCo913QTACYQAdYM+0nY7gTHlg/gN0woUIRl5y1oHgw7E7V zYcPGm2BPtwnGDUfmLjuIS/o6OJxfibxWnVBfyC0qmtUlgVR05C5FgmufhHWsRvRGNfHOppKOZx luLLVjwu8dmxreYJL90aHcKpXiKqPej5HOS5hD40scOLsC2cEo4Brt/TzFhin7mCDnlpRfFXNOo q2zgIGZBRtb9F2xN65b1woPRNMXhnvtc+XpmR3XrZQs97kdawS+KlunLr1cz/nxCCp X-Received: by 2002:a05:600c:609a:b0:485:3e00:944a with SMTP id 5b1f17b1804b1-488d68ae78amr136527135e9.9.1776004675286; Sun, 12 Apr 2026 07:37:55 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d533e596sm232913945e9.6.2026.04.12.07.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 07:37:55 -0700 (PDT) Date: Sun, 12 Apr 2026 15:37:53 +0100 From: David Laight To: Nguyen Duc Thinh Cc: Luka Gejak , gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] staging: rtl8723bs: rename dot11AuthAlgrthm to fix CamelCase Message-ID: <20260412153753.17c2c122@pumpkin> In-Reply-To: <20260412130012.5832-3-ducthinh100812@gmail.com> References: <20260412130012.5832-1-ducthinh100812@gmail.com> <20260412130012.5832-3-ducthinh100812@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 12 Apr 2026 20:00:12 +0700 Nguyen Duc Thinh wrote: > The variable dot11AuthAlgrthm and its associated enum values > violate the kernel naming convention. Rename them to the > snake_case equivalent, dot11_auth_algrthm. ... > - if (!(psta->state & _FW_LINKED)) > + if !(psta->state & _FW_LINKED) You didn't even compile it. There are lot of unrelated changed that make this far too big as well. David