From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f47.google.com (mail-dl1-f47.google.com [74.125.82.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B02E3803C2 for ; Sun, 12 Apr 2026 21:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776028286; cv=none; b=FcQYSz5NJI6Eq3KvB01O446f8SpDk6PG9Zsd8q2T3iMyod4RBB5DyOP+uLw1UsFgA2ooCSyG8EL+yOuTC9xxxJg3ntSBTgxjCQw2a1TrDNg5qsAoYfXhoBoEGxXU9ugTXAnqv/M2M+ji7PtWSnOIN4y9/XOq1OjnqUX8xF0ahuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776028286; c=relaxed/simple; bh=as/Y6rgrCLbxvFJK4woRt4WCiXpZGU5Bmcl75dpz1Ic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BW+WL9rMF5AgRwFWje2nBJ990HC1hZVRqGW3npGwJhVisQcYhdgIdvEkmLcNvTcPkT65BW/8kqzs1m9CIsYhOr7RTVyH5p5WNZBY9PXznsoAnIXVfbvUTNS+d9RiXSF02RGD5o21g5rqCLzpo8CH6ab978wbjAp7HyJd8OhbtwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UZhMmfqY; arc=none smtp.client-ip=74.125.82.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UZhMmfqY" Received: by mail-dl1-f47.google.com with SMTP id a92af1059eb24-12c1a170a50so3343272c88.0 for ; Sun, 12 Apr 2026 14:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776028285; x=1776633085; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6Epvlpqxnk7CA+C9ymJCfGqy8SHrtqDJZ4fsM6TY9RM=; b=UZhMmfqY8i6TiedDCEqOwCLh2DM0mNU9tH/OS4oxpi25wxqkZZOQO8OmOsw841YD7/ N6eQOJIabg8o3PiEQGiUyQaokyoPWZLJ6GYBjDI9XcmUMNgJIK/e35RibHnjpqkbFTUm lqxQTLBIcJrhvdAv78FQfewRZ7kMtUs43jh2tnoG948HtEM7T7RCFNUlc1/oU0lm2vgo TKCVM5P0owwxe9XpUR1pw81veIZk6I2IwUqY0LGR/c845Mrh3YDQjTAiXU4MUruIjBQ5 UBVRu8yIEq17KjsFreW9KFpyVwStkudfzUK6+Plz5jzGaPfxOTEEmM1opmjmdJa3bsp5 dKYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776028285; x=1776633085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6Epvlpqxnk7CA+C9ymJCfGqy8SHrtqDJZ4fsM6TY9RM=; b=TWbA75ZIt8NNfCzUnTbRtz1g3v/iWTLh+pS2I+EPKmlA4oyErNm1QfA22kFUt1XN5A g20liR8cxWQJUHyvcEx4M5WAKflzM8Pva6m4YXasKQXK9oUAqpItbMZIiYGlnDOdWD17 YOoWmvjKDnF9aBWm7/b6ru/eKjY0PcaLEQw3a4pt7jsDf4PrTGazdbrxObzBL5vm2s+y 4La55CALbVr7ZtHSq9pffEzskmnm90Y/Ebv9vocp/D2mmxCh4/NWW6LER+2EVtDxngW+ wY2mgOhlH6UbNyRp6xCC+2qNzdWDSYvRC4fSZFQr9nwW00xGpdQ5v2WrKaOowU0gKfZu DZGg== X-Forwarded-Encrypted: i=1; AJvYcCWt+KG3YR46Ioos6huIEoP2MBSZYtX5G+lhKwMnsVQyG6ubwW4btHR/zen5HW2OW5HiQNAOgFCByIAODJ0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7c8ykSn8dv1wf1uRE/KWr2AJkUmhvqJY0PxtDvY6bHeqmq7fW kHWG9gUj7aAaG3npHvfiaL0ApaIJp8+hRljQrq0xdTNY+gyof4v20i/d X-Gm-Gg: AeBDiesTWU+xBfBb+wmwtUhlmQxlyidXuqen4jWoluW4AycOX5hjTdmh0lm6717tbLD 8HbAzqiWg91IBuryXMhT0XFydwPDUJw6bNRA1kndxNtuOzsk7qdbvPA50BnOUTlxGqYyf7c/I85 3aSNJDCayTway063iFZ7Amwj33brYdv57JO1zGeqhT3YvNOBqduwdTN4TVJTAy/LgYNCXxtRW4B 7/kFW7H9wSHFYxkQ2xXH+FGy3b4afdawLGMP7cfkRCecHiowHw8LkH6NX+mSKEZKUcrDhmBV4wk KGrBDQg/KsQvMRaq7fVk+63bFJQ05URbzPuvHbaM/gEQdqWH6CHz5F2QumZeyFxGpx7VcyAo2DP gTQxWdAXPuV9H1qAg8lKJIdELIgAe5ttw1SYZYrYgblLec0RXwaTEZYuZbwKx+O4PWHihciQ3WC 2Iorym7vsN8v/CPnujx8nhAYU+wdwoVvF1LEs2T9oOWmAe3GUN98B2b84jZjauAcEOrJQiJyd2d 8Aw X-Received: by 2002:a05:7022:ec07:b0:119:e55a:9c04 with SMTP id a92af1059eb24-12c34ef9715mr6188284c88.32.1776028284605; Sun, 12 Apr 2026 14:11:24 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c346fb141sm11520856c88.12.2026.04.12.14.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 14:11:24 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v10 01/16] platform/x86: lenovo-wmi-helpers: Fix memory leak in lwmi_dev_evaluate_int() Date: Sun, 12 Apr 2026 14:11:06 -0700 Message-ID: <20260412211121.2220556-2-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260412211121.2220556-1-derekjohn.clark@gmail.com> References: <20260412211121.2220556-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Rong Zhang lwmi_dev_evaluate_int() leaks output.pointer when retval == NULL (found by sashiko.dev [1]). Fix it by moving `ret_obj = output.pointer' outside of the `if (retval)' block so that it is always freed by the __free cleanup callback. No functional change intended. Reviewed-by: Mark Pearson Fixes: e521d16e76cd ("platform/x86: Add lenovo-wmi-helpers") Cc: stable@vger.kernel.org Link: https://sashiko.dev/#/patchset/20260331181208.421552-1-derekjohn.clark%40gmail.com [1] Signed-off-by: Rong Zhang Signed-off-by: Derek J. Clark --- drivers/platform/x86/lenovo/wmi-helpers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/lenovo/wmi-helpers.c b/drivers/platform/x86/lenovo/wmi-helpers.c index 7379defac500..018d7642e2bd 100644 --- a/drivers/platform/x86/lenovo/wmi-helpers.c +++ b/drivers/platform/x86/lenovo/wmi-helpers.c @@ -46,7 +46,6 @@ int lwmi_dev_evaluate_int(struct wmi_device *wdev, u8 instance, u32 method_id, unsigned char *buf, size_t size, u32 *retval) { struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL }; - union acpi_object *ret_obj __free(kfree) = NULL; struct acpi_buffer input = { size, buf }; acpi_status status; @@ -55,8 +54,9 @@ int lwmi_dev_evaluate_int(struct wmi_device *wdev, u8 instance, u32 method_id, if (ACPI_FAILURE(status)) return -EIO; + union acpi_object *ret_obj __free(kfree) = output.pointer; + if (retval) { - ret_obj = output.pointer; if (!ret_obj) return -ENODATA; -- 2.53.0