From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26DDA318B85 for ; Sun, 12 Apr 2026 22:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776032604; cv=none; b=bCdOpEDTi6XiFuchNk50U90EKi3jH+XNQgfu0tpNrkdhRB9T/uK2dRnaC9mGUQxHuItkRrNUpaDxivqLrv8j01scV8yyqNKVqIH1d/LfJ1HvkhLbDk5qUsqmC9IEo8K1r41botr4VmW3G9o7xv2forX70xUI4ApyAfbN6hmf0XI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776032604; c=relaxed/simple; bh=T64TpRZBA41DEg/wfVctlRr721wwtVyqIF/IwfaxjSo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=QakoVxd5qKu+HHMMD2sb1g7znyNovxoHY79qPRdMBGJbNosbT73dndFoFuqSm2LLQfwXOB/BBODpxpGQZZR4Qe+uEduR4qSgFQyHSwC3JIuGu9hG/zMehYY5O/rIYsfd5l+SvJig2sp/b0vt/jYjWBzoXaGbu+9P0/VgQXgxr78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HNW5BGwg; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HNW5BGwg" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso35959095e9.3 for ; Sun, 12 Apr 2026 15:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776032600; x=1776637400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RYvN4jrk/CUbJx1nSdCPQaZt228zm3wxlCIscdqWqbo=; b=HNW5BGwgnYs44etUV5uT+jkbxrE4a3lx1GwKedEgmdcRw7O6IlvwVX0OvehadlKR8R f5+DvVSO0ar2HK1sTk7mTQugqVPf4s2RXKf+3oL6i1Y3y4Wveb7mbMbMgfWJ4cGVWX2P 4JdclhgqGNDc8NEh5WOn1a40I19GgsmXu4ZF+DhnYx3fl2uO94jloJx/pQbQl14wHZHy 0d6j6umllMTxHLOU/KRs93HxlC9Q7CvYsJG3P5SermkWWULSgTB7NfCj3Qv2ibgx1KMs ZwuCh/YW9glg1ntZsiT9mLyPlL1jPNXfZCsmnK9kOGhn+h8PYxTQiWQgEEixK56YXv3g IFRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776032600; x=1776637400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RYvN4jrk/CUbJx1nSdCPQaZt228zm3wxlCIscdqWqbo=; b=em3fAYeG4Fx8LJrMsmd9jnqkrBDQ2zmHF1Qq8m0+HPppv4zhMj/rEDIOmgavQ9ZoJb PsNtcTS6oly2Oebm+t/xr2xXeocmrue8qhh2AjdSCsp8S/M13GzSsB1Ho5u5d2mD5jqA kQz7A3g5KFCbsyAjgT4L+3jtCHPacBm+SKMcg8NyFjP1I2FD8+9smvDiLwyPW134TPya bu9iphVDbUP65uM1GI3rtRYGkYm0ColjyRxIRqTvYC21NdYGKDjhtNO4CPGDLafGv/rn 2e5p/klIm7S9Sn+uBbW6ujNmBhtf9FuFJkHUeBoy6tu6BNtEBL1UDTmY/TRMxTVzjuC+ o4YQ== X-Forwarded-Encrypted: i=1; AJvYcCUfZpqiwl9X+OVwUmAB3bkSpYZNGvJ9Ar5HhmlK/RkDcCI0zxK0NuZ7Yz2xsaK8ZXUA9qQnS8sn962ii5I=@vger.kernel.org X-Gm-Message-State: AOJu0YwXMjtf7IW5GEIoK6G+1Eg6CmPMuViSH/TLU+PnfdqCY7N4fvjJ qmpTjv6iZOj0nEQBaTWyRu53vs6Ich/likpsZXp+cKRqh0JOMue13xzo X-Gm-Gg: AeBDiesKIi4B4LOL8g9+JUqFmyzHHc/MrWV1ejPPyPlnP5Mje0+Jg9rV7vPCtzB4sRF yPCW7epb1GO62YO20L/e2glwY7ljFnMrfClVCOM0qgIV8pyW1+7BguM9aw46IxKHCqtYrdf+Vzb 5h8yeUw9kJLXKoWDOmune2kVkP4JyYP9l/8pQN/HHrUXaLnQfsoAnCfKFGM50xbTgtFPhoUhT0U BdhHUUUO9VA4Ihw+dp69KKi5KpZ4FB00RUPiFupVZf/td1K5o1rQU3W7x7eM744+jIki34dggaM ihiP3IcCSXLHjkTEgACio+fIQaRi/LEgPuWV4oQhyuqjwPykAq/4W/J04OBhDxnSTDww0ZFx+JH OaPEMOtltEKduGrAUtH0cDm2saE04YcxpxZGRSNWRQCn+yUuEuWjlxMnx47hgZsuBI1af//qnqd GP82gx+Jpw7VC0pj8VA/LU8IIyvcyzZVYyLLZ4dMOyxiNxBjGQlQcM5mVAZQ== X-Received: by 2002:a05:600c:8710:b0:485:3abe:ab86 with SMTP id 5b1f17b1804b1-488d67bbd1dmr162322955e9.4.1776032600295; Sun, 12 Apr 2026 15:23:20 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:20d3:ec44:33ae:6a91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d762decf6sm10528536f8f.8.2026.04.12.15.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 15:23:19 -0700 (PDT) From: Gabriel Rondon To: Greg Kroah-Hartman Cc: Christian Gromm , Parthiban Veerasooran , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3] staging: most: video: remove redundant cleanup in comp_exit() Date: Sun, 12 Apr 2026 23:23:18 +0100 Message-Id: <20260412222318.65045-1-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <2026040838-washbowl-handbrake-ae03@gregkh> References: <2026040838-washbowl-handbrake-ae03@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit most_deregister_component() already calls disconnect_channel() for every linked channel via bus_for_each_dev() in core.c, which invokes comp_disconnect_channel() to remove each entry from the video_devices list and tear down the V4L2 device. The manual cleanup loop in comp_exit() duplicates this work and is guarded by a stale comment claiming that "mostcore currently doesn't call disconnect_channel() for linked channels" — but the core has since been fixed to do exactly that. Remove the redundant manual cleanup loop, the outdated comment, and the BUG_ON() assertion that checked for a condition that can no longer occur. Signed-off-by: Gabriel Rondon --- Changes since v2: - Remove the cleanup loop and BUG_ON() entirely instead of replacing BUG_ON() with pr_warn(). most_deregister_component() already calls disconnect_channel() for every linked channel via bus_for_each_dev() in core.c, which handles the teardown. (Greg Kroah-Hartman) Changes since v1: - v2 used pr_warn() instead of WARN_ON() to avoid a crash with panic-on-warn (Greg Kroah-Hartman). Superseded by the v3 approach above. drivers/staging/most/video/video.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c index 04351f8ccccf..98988b0d9330 100644 --- a/drivers/staging/most/video/video.c +++ b/drivers/staging/most/video/video.c @@ -555,29 +555,8 @@ static int __init comp_init(void) static void __exit comp_exit(void) { - struct most_video_dev *mdev, *tmp; - LIST_HEAD(free_list); - - /* - * As the mostcore currently doesn't call disconnect_channel() - * for linked channels while we call most_deregister_component() - * we simulate this call here. - * This must be fixed in core. - */ - spin_lock_irq(&list_lock); - list_replace_init(&video_devices, &free_list); - spin_unlock_irq(&list_lock); - - list_for_each_entry_safe(mdev, tmp, &free_list, list) { - list_del_init(&mdev->list); - comp_unregister_videodev(mdev); - v4l2_device_disconnect(&mdev->v4l2_dev); - v4l2_device_put(&mdev->v4l2_dev); - } - most_deregister_configfs_subsys(&comp); most_deregister_component(&comp); - BUG_ON(!list_empty(&video_devices)); } module_init(comp_init); -- 2.33.0